[0.17.14] ingrediates disappearing when crafting interrupted

[krenshala]

I've noticed over the last couple of versions (not sure when it started) that if you interrupt a crafting in progress you lose some or all of the ingredients being used by it for the crafting process. E.g, the most recent example was when I placed 32 iron plates, 15 gears and 12 green circuits into an assembler 1 to make electric miners. After created two miners, I deconstructed the assembler while it was building the third miner but before it completed that build. I'm not sure how many plates and ears I got back (I think it was the correct 12 and 5, as I had 5 gears still) but I received zero green circuits back, when I should have received 6 green circuits (input 12, made 2 electric miners that use 3 each, then canceled the crafting).

Reproduction Steps:
1) build an assembler, and set a recipie
2) add enough ingredients to build more than one item
3) interrupt the build process by pushing the 'set current recipie' button OR deconstructing the assembler while it is working on the recipie
4) count the items you receive back from the assembler - you will be missing raw materials.

Verification steps I just performed:
14 copper plates into an assembler 1 set to make copper wire
interrupted the crafting (by pressing the 'set current recipie' button) when it had 4 plates left, but only 18 wires created
received 4 plates and 18 wires, so 4 plates + 18 wires = 13 plates, not the 14 put into the assembler

There are no errors in the current log. I had this happen with the electric miners example above shortly before exiting the game (call it about 2200 seconds in, as I checked these forums for about 5 minutes before exiting to submit this bug report).

60.945 Generated mipmaps for atlas of size 16384x456
60.956 Generated mipmaps for atlas of size 16384x1264
60.962 Custom inputs active: 6
61.061 Factorio initialised
70.649 Loading map C:\Users\krenshala\AppData\Roaming\Factorio\saves\kren is a lazy bastard.zip: 3969185 bytes.
70.952 Loading Level.dat: 6744224 bytes.
70.956 Info Scenario.cpp:147: Map version 0.17.14-0
71.155 Loading script.dat: 328 bytes.
71.172 Checksum for script C:/Users/krenshala/AppData/Roaming/Factorio/temp/currently-playing/control.lua: 1848333929
261.052 Info AppManager.cpp:275: Saving to _autosave2 (blocking).
262.106 Info AppManagerStates.cpp:1738: Saving finished
862.719 Info AppManager.cpp:275: Saving to _autosave3 (blocking).
863.718 Info AppManagerStates.cpp:1738: Saving finished
1464.335 Info AppManager.cpp:275: Saving to _autosave1 (blocking).
1465.332 Info AppManagerStates.cpp:1738: Saving finished
2506.647 Info AppManagerStates.cpp:1738: Saving finished
2523.916 Quitting: user-quit.
2524.049 DSound: Stopping voice
2524.049 DSound: Joining thread
2524.050 DSound: Exit _dsound_update; tid=6292

[tehfreek]

I'm wondering if this is related to:

• Fixed that canceling production in assembling machine did return the products in progress.

viewtopic.php?p=400172

[krenshala]

Hmmm. I'd missed that one (too busy downloading the first 0.17 release ). That does seem to be talking about what I'm seeing.

[tehfreek]

The thing is that it says "products" and not "ingredients", so I'm wondering whether the changelog is inaccurate, or if this has introduced a bug.

[Kacoda]

I think this is a bug as well. It shouldn't return the products currently being built, which is working as mentioned. But not returning the contemporary ingredients is a little too much, no? I mean it's kind of fine with simple things, but if you abort sth more expensive that'd be quite a waste of raw materials which feels rather fishy...

[tehfreek]

Absolutely it's a bug. Whether it's a bug in the assembler or the release notes has not been specified.

[BlueTemplar]

I've never seen canceling production to return products in progress?
I'm pretty sure that this changelog means "ingredients" rather than "products"... (to be similar to what happens with fuel?)

[tehfreek]

I just tested in 0.16.51 using Kovarex Enrichment and it definitely returns all ingredients on cancel or mining even if the cycle has already started.