[Dominik][0.17.16] Cannot paste recipe due to (intermediate) fluid mixing

[boskid]

Attached save with replay

Steps to reproduce:
1/ place assembler (source)
2/ setup it to "crude oil barrel" and rotate it to have input from bottom

3/ place assembler (dest)
4/ put water line above dest assembler
5/ try copy settings from source assembler to destination assembler (shift+lmb then shift+rmb, or using ctrl+C - they both are not working)

paste-failed-img.png (492.84 KiB) Viewed 3844 times

What happend:
- nothing, assembler recipe was not set and assembler was not rotated (as it has no recipe with fluids)

What should happen:
- assembler should get proper recipe with a proper rotation
- recipe and building rotation should be atomic: both should be applied or both unchanged

I assume this is intermediate state: when copying settings, first recipe is copied (with check against fluid mixing but using default assembler rotation), then rotation is copied (this can be easily confirmed by using third recipe like acid barreling and no pipes from top: recipe will be copied but rotation of assembler will not be applied due to fluid mixing)

[Rseding91]

Thanks for the report however that's working correctly: copy-pasting recipes specifically does not copy the direction of the machine.

[boskid]

Thanks for the report however that's working correctly: copy-pasting recipes specifically does not copy the direction of the machine.

Ok i see, but still there is something wrong. When using Ctrl+C to copy/paste over existing assembler with pipe above paste will fail but when there is no pipe above, paste will set recipe and rotate (see attachment with replay). I consider Ctrl+C to be "ad-hoc blueprint" and blueprints should copy direction

--- edit:
I also added save with replay for second case: when blueprint is partialy applied: recipe is set but assembler may not be rotated - this is proof for statement that copy is "multi part" - first set recipe, then rotate

[Dominik]

Hi, this was a tricky one. There are just so many paths on which the mixing needs to be checked and this one still did not get rewritten. So I did now and it works correctly Thanks!

[factoriouzr]

Hi, this was a tricky one. There are just so many paths on which the mixing needs to be checked and this one still did not get rewritten. So I did now and it works correctly Thanks!

Fix fluid inputs on buildings setting the fluid type of attached pipes to 0 of that particular fluid type. This prevents using for eg blueprints that put water pipes in place on oil refineries before you set them to the recipe which uses water.

Logically input pipes have no bearing the type of fluid in an attached pipe that is empty. Having 0 oil in attached pipes when no fluid source is attached, oil or water, makes absolutely no sense and prevents attaching pipes to a water source. The pipes should be completely empty and when water goes through them, the oil refinery should just ignore that input as it did before 0.17.

[factoriouzr]

This is still a bug

[boskid]

This is still a bug

Ref: 68175

If you want, create separate bug report, most likely it will be moved to 'ideas and suggestions' or 'not a bug' (unless more details provided)

[Dominik]

We know about this and there are other posts on this subject around.

[factoriouzr]

We know about this and there are other posts on this subject around.

Is the blueprint functionality going to be restored then or do we have to live with this huge limitation?