[0.17.4] Cliff Deconstruction not issued (MR)

This subforum contains all the issues which we already resolved.
Post Reply
Amuxix
Inserter
Inserter
Posts: 28
Joined: Sat Nov 26, 2016 2:21 pm
Contact:

[0.17.4] Cliff Deconstruction not issued (MR)

Post by Amuxix »

I placed a blueprint on top of some cliffs by shift+clicking so that the bots would deconstruct the cliffs, it worked for almost all of it but a small corner of a cliff prevented the placement of a solar panel and it did not get deconstructed automatically.

Remove the ghost and issuing its placement again did order the deconstruction, both with the blueprint and the solar panel alone.

Look at previous auto saves I concluded that it ordered to deconstruct some nearby cliffs bug upon deconstructing It changed cliffs a bit so that it interfered in a different place.
Attachments
Cliff not deconstructing.png
Cliff not deconstructing.png (1.21 MiB) Viewed 8740 times
Bug.zip
After nearby cliff is deconstructed.w
(8.13 MiB) Downloaded 138 times
Bug 0.zip
Before nearby cliffs are deconstructed.
(8.08 MiB) Downloaded 157 times

Syhn
Inserter
Inserter
Posts: 43
Joined: Mon Jan 22, 2018 9:13 pm
Contact:

Re: [0.17.4] Cliff Deconstruction not issued

Post by Syhn »

It has to do with the fog of war I believe. You can see the cliff is mostly in another chunk so it isn't checked when placing the ghost when the chunk with the cliff isn't visible.

Amuxix
Inserter
Inserter
Posts: 28
Joined: Sat Nov 26, 2016 2:21 pm
Contact:

Re: [0.17.4] Cliff Deconstruction not issued

Post by Amuxix »

For me it wasn't the fog of war, it was the fact that destroying part of a cliff changes the remaining cliff a bit, and in doing so the bit that was changed now also prevented the construction.

User avatar
invisus
Filter Inserter
Filter Inserter
Posts: 284
Joined: Fri Sep 21, 2018 5:33 pm
Contact:

Re: [0.17.4] Cliff Deconstruction not issued

Post by invisus »

Amuxix wrote:
Wed Mar 06, 2019 12:24 am
For me it wasn't the fog of war, it was the fact that destroying part of a cliff changes the remaining cliff a bit, and in doing so the bit that was changed now also prevented the construction.
Meaning, cliffs were deconstructed as they should be, but not enough of the cliff was removed to allow the construction to happen?

Rseding91
Factorio Staff
Factorio Staff
Posts: 13178
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [0.17.4] Cliff Deconstruction not issued

Post by Rseding91 »

Thanks for the report. I'm aware of this issue and was wondering if it would show up "in the wild" after adding in the ability to deconstruct cliffs.

Unfortunately I don't know of any solution to it except to disallow marking cliffs for deconstruction when using shift + place - which seems like it's not going to make anything better for this edge case.
If you want to get ahold of me I'm almost always on Discord.

Amuxix
Inserter
Inserter
Posts: 28
Joined: Sat Nov 26, 2016 2:21 pm
Contact:

Re: [0.17.4] Cliff Deconstruction not issued

Post by Amuxix »

Yeah I realized it would be a hard fixed when I reported this.
Have you considered checking if the resulting cliff after the destruction overlaps any ghost and if so also trigger a deconstruction on that new cliff?

Ishimuro
Inserter
Inserter
Posts: 24
Joined: Fri Sep 01, 2017 9:50 pm
Contact:

Re: [0.17.4] Cliff Deconstruction not issued (MR)

Post by Ishimuro »

Image

is it possible to get a kind of alert if bots stuck at construction tasks?

knightelite
Fast Inserter
Fast Inserter
Posts: 132
Joined: Fri Oct 05, 2018 3:49 pm
Contact:

Re: [0.17.4] Cliff Deconstruction not issued (MR)

Post by knightelite »

I've run into this a few times recently, and it would be nice to have a solution.

ribsngibs
Long Handed Inserter
Long Handed Inserter
Posts: 70
Joined: Mon Mar 28, 2016 5:42 am
Contact:

Re: [0.17.4] Cliff Deconstruction not issued (MR)

Post by ribsngibs »

Still running into this in [1.0.0].

It's a super minor issue: to fix it all I have to do to fix it is throw cliff explosives on the offending cliff (which doesn't do damage to any other items), or mark the bad cliff piece with deconstruction planner, but still, it's... unexpected... for a game which behaves so consistently/bug-free/perfectly otherwise.

skraaaaa
Burner Inserter
Burner Inserter
Posts: 7
Joined: Fri Jun 28, 2019 10:59 pm
Contact:

Re: [0.17.4] Cliff Deconstruction not issued (MR)

Post by skraaaaa »

Also running into this issue in 1.0. viewtopic.php?f=7&t=89258

Argach
Manual Inserter
Manual Inserter
Posts: 3
Joined: Mon Mar 12, 2018 8:21 pm
Contact:

Re: [0.17.4] Cliff Deconstruction not issued (MR)

Post by Argach »

same here viewtopic.php?f=47&t=91502

As I am basically building my whole factory with bots on the map (yes, my base is one big logistic network), I only see that something is off when the idle number of bots is not the same as the total number of bots. Depending on the size of the factory this can be tedious.

xeode
Burner Inserter
Burner Inserter
Posts: 10
Joined: Thu Apr 01, 2021 9:32 am
Contact:

Re: [0.17.4] Cliff Deconstruction not issued (MR)

Post by xeode »

Hi there,

Glad to find this bug report as presumed something was wrong with my game. This does seem to happen quite a lot when running rails, but pretty much anything ghost-built over a cliff section can have it happen.

Though I appreciate the ability to paste over cliffs and automatically generate cliff destruction tasks for construction robots please can I understand what the road block is with generating appropriate cliff destruction tasks? If there's already code that determines which cliff sections are to be left/generated as a result of a cliff destruction event (cliff sections positioned on the map and rendered etc) why is the reverse not possible when generating the required cliff destructions?

If there's a reason this is very hard to code for (to get the code that generates destruction tasks based on a required build area input, to be able to arrive at the same result that the cliff destruction code does) then are there perhaps any brute force solutions such as clearing an additional tile in every direction to be 'on the safe side'?

This happens every 500 tiles or so when building tracks in a straight line and it's not always apparent (is easily missed when moving quickly I find). This is something that's annoying when it happens in front of you but if you miss that a robot is patiently waiting over an infringing cliff section after you've already left the area (or potentially after troubleshooting when trains don't go the way they should).

This doesn't seem to be a corner case or an edge case and seems to happen to me several times an hour. It's also all the more frustrating because I can't fathom why this would be unsolvable either, seeming as it does to be two bits of code that regularly come to different results and which should on the face of it share a common calculus and fit hand-in-glove. Hopefully even if there is some unsolvable issue in calculating the right destruction tasks, there might be a way to brute force some buffer clearances, or failing these just to get the game engine to 'cheat' when deciding between itself and itself which destruction tasks are required to result in the build area being fully cleared. This isn't like accounting where we need every dollar that goes in to come out and be accounted for. If a code change were to result in more cliff explosives being used than were strictly required, I don't see that as a larger problem than ghost construction being inconsistent when building in worlds that use cliffs (which I know not everyone bothers with). Though I'd love the source discrepancy to be addressed and no cheating/waste to be required.

Thanks for any thoughts or info anyone has on this.

Kind regards,
xeode

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5206
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [0.17.4] Cliff Deconstruction not issued (MR)

Post by eradicator »

Had two of these yesterday. One rail and one train stop.


robo-decliff-bug.png
robo-decliff-bug.png (240.22 KiB) Viewed 6346 times
robo-decliff-bug2.png
robo-decliff-bug2.png (253.53 KiB) Viewed 6346 times
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

evg-zhabotinsky
Inserter
Inserter
Posts: 22
Joined: Wed Dec 09, 2020 3:53 pm
Contact:

Re: [0.17.4] Cliff Deconstruction not issued (MR)

Post by evg-zhabotinsky »

Same here, happened dozens of times to me. Stopped counting occurences when robots started showing on map, as it is now easier to detect.

Possible solutions, as I see it:
1. Stop cliffs changing hitboxes upon neighbor changes, if possible.
2. Pre-compute final hitbox and order wider deconstruction if necessary.
3. Just mark one more cliff at each end when deconstructing by shift-placing.

Post Reply

Return to “Resolved Problems and Bugs”