[Klonan] [0.17.3] Crash when loading 0.16 vanilla PvP

[Llama]

When loading a PvP save from 0.16 I get a crash when rocket launch events happen, browsing options or starting round.

I don't suppose it's the same as this, as mine crashes in 0.17.3 vanilla whilst loading a 0.16 vanilla save.
This bug report is about mods in PvP:
viewtopic.php?f=11&t=65652&p=403155&hil ... sh#p403155

I will be creating a new game for 0.17 anyway, but I wanted to observe performance between versions, and the crash info may help you/others.

There are 3 ways I can create a crash:
1) Load late-game save file and wait for rocket launch (not included, is too large) before changing any PvP options or Starting Round.
2) Load save file and LMB click Balance Options in the PvP menu.
3) Load save file and LMB click Start Round.

It happens every time I do one of the above actions, I started off loading my most recent save and worked my way back to loading the very first save (~5h?) and it crashes even with an early save with no rockets and not much researched / fewer bonuses.

[Klonan]

Can you provide the 0.16 save file?

[Llama]

Hi Klonan, save file is attached (Jimandy016a.zip)

[Klonan]

Thanks for the save,

It is fixed for the next version,
Loading the save in 0.17 shouldn't error now.

[Llama]

I'm still getting a crash a few seconds after loading a PvP scenario from 0.16 in 0.17.7, either as a hosted multiplayer game or in singleplayer.

To reproduce, load save file (Jimandy016a.zip) attached to first post, and LMB click Confirm when prompted about migrations. It then crashes, as seen in attached screenshot and logs.

0.17.6 didn't crash over time, but would create a new game when you choose PvP settings (created new round). 0.17.7 does not ask for PvP settings (correct behaviour in my opinion) but then crashes (when incorrectly applying old pvp.lua settings?)

[Klonan]

Right, this was due to a change in the color names,
I have fixed it for the next next release, and for now here is a fixed save game for 0.17.8 (Will be out soon)

[Llama]

I can confirm your modified save works in 0.17.8 for me, glad we could get to the bottom of it and fix for the next release.

Many thanks to you and the team for the effort you've been putting in