[posila][0.16.51] framerate drop when drawing mutiple wires

[gheift]

Hello,

I noticed a hugh framerate drop, when the game has to draw multiple wires. I attached a minimal save, where I could reproduce the issue. A also added a trace I recorded using

Code: Select all

perf record -F 100000 -p $(pidof factorio) -g

.

Kind regards,
Gerhard

perf report -n --stdio

Code: Select all

# To display the perf.data header info, please use --header/--header-only options.
#
#
# Total Lost Samples: 2723
#
# Samples: 218K of event 'cycles:ppp'
# Event count (approx.): 86655088015
#
# Children      Self       Samples  Command        Shared Object                  Symbol                                                                                                                                                                                                                                                                                                                                                                                          
# ........  ........  ............  .............  .............................  ................................................................................................................................................................................................................................................................................................................................................................................................
#
    13.38%     0.00%             0  factorio       [unknown]                      [k] 0000000000000000
            |
            ---0
               |          
               |--1.39%--ogl_draw_bitmap_region_optimised
               |          
                --0.97%--al_transform_coordinates

     6.57%     0.00%             0  factorio       [unknown]                      [.] 0x3f8000003f800000
            |
            ---0x3f8000003f800000
               |          
               |--1.18%--ElectricPole::drawWireInternal
               |          
                --0.92%--Math::sin

     6.50%     0.00%             0  factorio       [unknown]                      [.] 0xfffff85900001d24
            |
            ---0xfffff85900001d24
               |          
                --6.49%--0x3f8000003f800000
                          |          
                          |--1.18%--ElectricPole::drawWireInternal
                          |          
                           --0.92%--Math::sin

     4.00%     0.00%             0  factorio       radeonsi_dri.so                [.] 0x000000000074f450
            |
            ---0x74f450
               |          
               |--2.10%--0x32a2780
               |          |          
               |           --1.37%--0x345c710
               |          
                --1.88%--0x42c310
                          0x32a2490

[Rseding91]

Thanks for the report however I can't reproduce what you're seeing.

I suspect it's related to your graphics card and or drivers since the logic for rendering wires is identical to rendering the inserters and the tiles they all sit on. The only difference is more wires means more things drawn which can overload the graphics card if it can't keep up.

[posila]

Thanks for the report.
Even though rendering was rewritten and greatly optimized for 0.17, your save uncovered performance problem even in the new renderer, so that's fixed.

But the core of the problem is that circuit connector sprites are not included in atlases with "Video memory usage" set to "High", so drawing of circuit connectors is not batched resulting in 10000 draw calls, which is quite bad, so we need to look into that too.

Ref: 69876

[posila]

Thanks for the report.
In the end I realized inserter has unique circuit connector, so I can just modify its flags so inserter base and the circuit connector end up in the same atlas and sprite batching can work properly.
Fixsed for 0.17.49