caninsert() ignores inventory size

[Dark]

This is a minor issue.

entity.caninsert() returns true despite the fact that entity's inventory is zero sized.

Workaround code:

Code: Select all

  if entity.caninsert{name=item_name, count=count} then
    entity.insert{name=item_name, count=1}  -- the real test
    if entity.getinventory(defines.inventory.fuel).getitemcount(item_name) >= 1 then
      if count - 1 > 0 then
        entity.insert({name=item_name, count=count-1})
      end
    end
  end

[slpwnd]

What entity is this exactly?

[Dark]

It is a car, with zero in fuel and inventory storage.

Mod that automatically placed fuel in any player build entities conflicted with it.

definition

Code: Select all

  { 
    type = "car",
    name = "AI-spotlight-proxy",
    icon = "__AdvancedIllumination__/graphics/icons/spotlight.png",
    flags = {"placeable-player", "not-on-map", "building-direction-8-way"},
    max_health = 50,
    corpse = "medium-remnants",
    dying_explosion = "huge-explosion",
    order="a",
    collision_box = {{-0.15, -0.15}, {0.15, 0.15}},
    selection_box = {{-0.5, -0.5}, {0.5, 0.5}},
    tile_height = 1,
    tile_width = 1,
    acceleration_per_energy = 0,
    breaking_speed = 0.0,
    rotation_speed = 0.0,
    weight = 1,
    inventory_size = 0,
    friction = 5e-3,  
    burner = 
    {
      effectivity = 1,
      fuel_inventory_size = 0
    },
    consumption = "0kW",
    pictures =
    {
      filename = "__AdvancedIllumination__/graphics/proxy/directions-small.png",
      line_length = 8,
      frame_width = 30,
      frame_height = 30,
      shift={0, 0},
      axially_symmetrical = false,
      direction_count = 8,
      scale=1.0,
    },

  }

[slpwnd]

So the car and the character had dummy methods for caninsert (always returning true instead of checking the actual contents of their inventories). This will be fixed in the 0.10.4. Just a side note - caninsert will return true if anything can be inserted (so caninsert for 100000000 will succeed even if there is a single space).

[Dark]

Thanks. Still better than always true, a check for how much was actually inserted can be done manually.
BTW, can "insert" method return inserted amount? That would make things trivial.