[LTN 1.7.1] copy ltn stop name bug

Adds new train stops forming a highly configurable logistic network.

Moderator: Optera

Post Reply
Zanostra
Long Handed Inserter
Long Handed Inserter
Posts: 82
Joined: Mon Apr 03, 2017 8:03 pm
Contact:
Contact Zanostra

[LTN 1.7.1] copy ltn stop name bug

Post by Zanostra »

I'm pretty sure I found a bug when using shift+mouse to copy/paste a ltn stop name.
I have all versions up to date and I can recreate the bug whenever I want to.
When there are more ltn-stops sharing the same name, say "station 1", and you use shift+mousebuttons to copy/paste another ltn-stops name and settings "station 2" over the ltn-stop "station 1" until there is only one "station 1" left, that stop becomes invalid.
The game doesn't crash, but you get a notification every second until you change the name of that stop, even changing it into the name it already had will do.
Last edited by Optera on Thu Feb 01, 2018 5:54 pm, edited 1 time in total.
Reason: added version
Top
User avatar
Optera
Smart Inserter
Smart Inserter
Posts: 2920
Joined: Sat Jun 11, 2016 6:41 am
Contact:
Contact Optera

Re: copy ltn stop name bug

Post by Optera »

Only Depots may share names.
Stations with duplicate name will go into an error state signaled by pink led.
Top
Zanostra
Long Handed Inserter
Long Handed Inserter
Posts: 82
Joined: Mon Apr 03, 2017 8:03 pm
Contact:
Contact Zanostra

Re: copy ltn stop name bug

Post by Zanostra »

that's not the problem, it doesn't matter if they are depot or not.

this is the situation with the names:
situation 1.png
situation 1.png (219.65 KiB) Viewed 2458 times
I used shift+rightmouse to copy station "bye", and shift+leftmouse to paste it to one of the stations "hy".
situation 2.png
situation 2.png (277.98 KiB) Viewed 2458 times
station "hy" is the last of his name, depot or not, started with 25 duplicates or 2, or in whatever order you paste them away, all doesn't matter.
the last single station that stays behind when his duplicates are pasted over, will give this message.
Top
User avatar
steinio
Smart Inserter
Smart Inserter
Posts: 2638
Joined: Sat Mar 12, 2016 4:19 pm
Contact:
Contact steinio

Re: copy ltn stop name bug

Post by steinio »

Can reproduce.

Actions:
- place 3 LTN train stops
- shift+right click on 1st, shift+left click on 2nd - no error
- shift+right click on 3rd, shift+left click on 2nd - error invalid station
Debug Log
Image

Transport Belt Repair Man

View unread Posts
Top
User avatar
Optera
Smart Inserter
Smart Inserter
Posts: 2920
Joined: Sat Jun 11, 2016 6:41 am
Contact:
Contact Optera

Re: copy ltn stop name bug

Post by Optera »

Fixed in next release.

Added an additional check against removing wrong stop ids and turned off rename handling for on_pre_entity_settings_pasted.
If I recall i added rename handling to on_pre_entity_settings_pasted back in 0.14 when on_entity_renamed wasn't reliable.
Top
Post Reply

Return to “Logistic Train Network”