Quickbar confusion when playing without character

[neoc]

If playing with player.character=nil, quickbar and main inventory are swapped:

player.get_inventory(defines.inventory.player_quickbar) will give you the main inventory while

player.get_inventory(defines.inventory.player_main) will give you the quickbar.

Since I can't see any good reason for this behavior, I consider it a bug.

[bobingabout]

If it does work as you say, then I would say it is a bug.

[posila]

That's because without character your are in god mode, and therefore you should be using different constants

Code: Select all

defines.inventory.god_quickbar	
defines.inventory.god_main

Personally, I think it is annoying and unnecessary behavior, but I can't foresee consequences of changing it and previously it was qualified as Not a bug by other developers, I am going to do the same.

[neoc]

That's because without character your are in god mode, and therefore you should be using different constants

Code: Select all

defines.inventory.god_quickbar	
defines.inventory.god_main

Personally, I think it is annoying and unnecessary behavior, but I can't foresee consequences of changing it and previously it was qualified as Not a bug by other developers, I am going to do the same.

I still can't see why those constants are defined in the opposite way. You could just define them as the normal ones and everything should be fine.

[Rseding91]

Changing the inventory index order changes the order they're iterated when you do something like "insert" or "remove_item".

[neoc]

Changing the inventory index order changes the order they're iterated when you do something like "insert" or "remove_item".

That means you're not using the definitions in the code but iterate over numbers, how dare you!

Well, it's a minor issue, but annoying when I have to manually fix mods like autofill every time (I strongly prefer playing in RTS mode without a character, playing with a character is just too annoying and pointless to me).

[Rseding91]

Mod(s) should really just use player.get_quickbar() and player.get_inventory() which does exactly what you'd want for character entities or the god controller.

[neoc]

Mod(s) should really just use player.get_quickbar() and player.get_inventory() which does exactly what you'd want for character entities or the god controller.

Didn't know these APIs, thanks for the hint, I will try to get the author of autofill to fix this!