[wheybags] [16.6] Crash in ingame mod portal when clicking back while refreshing

[Daniel599]

Steps to repeat this crash are as follows.
1. load mod portal
2. install new mod
3. refresh mod portal
4. before mod portal finished refreshing click back
5. experience crash

[Loewchen]

Code: Select all

   0.002 2017-12-19 09:24:32; Factorio 0.16.6 (build 34439, win64, steam)
   0.002 Operating system: Windows 10 (version 1709) 
   0.003 Program arguments: "I:\Installed Games\SteamLibrary\steamapps\common\Factorio\bin\x64\Factorio.exe" "--wait-to-close" "20148" 
   0.003 Read data path: I:/Installed Games/SteamLibrary/steamapps/common/Factorio/data
   0.003 Write data path: C:/Users/noone/AppData/Roaming/Factorio [132093/476041MB]
   0.003 Binaries path: I:/Installed Games/SteamLibrary/steamapps/common/Factorio/bin
   0.009 System info: [CPU:        Intel(R) Core(TM) i5-3570K CPU @ 3.40GHz, 4 cores, RAM: 16344MB]
   0.011 Display options: [FullScreen: 1] [VSync: 1] [UIScale: custom (120.0%)] [MultiSampling: OFF] [Screen: 255] [Lang: en]
   0.012 Available display adapters: 1
   0.012  [0]: \\.\DISPLAY1 - NVIDIA GeForce GTX 960 {0x05, [0,0], 1920x1080, 32bit, 60Hz}
   0.012 Create display on adapter 0. Size 1536x864 at position [182, 90].
   0.175 Initialised Direct3D:[0] NVIDIA GeForce GTX 960; driver: nvldumdx.dll 23.21.13.8859
   0.175 D3DFMT_A8 is not supported format for surfaces.
   0.175 D3DFMT_L8 is not supported format for surfaces.
   0.183   Video memory size (dedicated video/dedicated system/shared system/available): 2016/0/8172/4088 MB
   0.256 DSound: Starting _dsound_update thread
   0.256 DSound: Enter _dsound_update; tid=4184
   0.257 Device reset internal.
   0.260 Desktop composition is active.
   0.260 WARNING: You have vsync and desktop composition enabled on Direct3D. Consider disabling vsync to increase performance on some configurations.
   0.260 Graphics settings preset: high
   0.261 Graphics options: [Graphics quality: normal] [Video memory usage: all] [Light scale: 100%] [DXT: false] [Shader: 1]
   0.261                   [Parallel sprite loading: 1] [Max texture size: 0/8192] [Bmp cache: 0] [Sprite slicing: 1] [Low quality rotation: 0]
   0.381 Loading mod settings PowerAndArmor 1.16.30 (settings.lua)
   0.381 Loading mod settings YARM 0.7.302 (settings.lua)
   0.383 Loading mod core 0.0.0 (data.lua)
   0.402 Loading mod base 0.16.6 (data.lua)
   0.551 Loading mod FARL 2.0.1 (data.lua)
   0.600 Loading mod autofill 2.0.1 (data.lua)
   0.650 Loading mod BlackMarket 1.0.34 (data.lua)
   0.709 Loading mod Electric Furnaces 2.3.1 (data.lua)
   0.761 Loading mod PowerAndArmor 1.16.30 (data.lua)
   0.817 Loading mod YARM 0.7.302 (data.lua)
   0.872 Loading mod base 0.16.6 (data-updates.lua)
   0.934 Loading mod FARL 2.0.1 (data-updates.lua)
   0.984 Loading mod PowerAndArmor 1.16.30 (data-updates.lua)
   1.034 Loading mod FARL 2.0.1 (data-final-fixes.lua)
   1.098 Loading mod PowerAndArmor 1.16.30 (data-final-fixes.lua)
   1.151 Checksum for core: 1649222139
   1.151 Checksum of base: 1679652734
   1.151 Checksum of FARL: 1212406221
   1.151 Checksum of autofill: 350303756
   1.151 Checksum of BlackMarket: 1891867370
   1.151 Checksum of Electric Furnaces: 3450164885
   1.151 Checksum of PowerAndArmor: 2046476215
   1.151 Checksum of YARM: 1786542758
   1.287 Loading sounds...
   1.365 Info PlayerData.cpp:67: Local player-data.json unavailable
   1.365 Info PlayerData.cpp:70: Cloud player-data.json available, timestamp 1513693133
   1.630 Loaded shader file I:/Installed Games/SteamLibrary/steamapps/common/Factorio/data/core/graphics/shaders/game.cso
   1.631 Loaded shader file I:/Installed Games/SteamLibrary/steamapps/common/Factorio/data/core/graphics/shaders/zoom-to-world.cso
   1.631 Loaded shader file I:/Installed Games/SteamLibrary/steamapps/common/Factorio/data/core/graphics/shaders/alpha-mask.cso
   1.649 Crop bitmaps.
   1.868 Initial atlas bitmap size is 16384
   1.874 Created atlas bitmap 16384x8547 [none]
   2.192 Created atlas bitmap 16384x2930 [shadow]
   2.274 Created atlas bitmap 16384x682 [decal]
   2.295 Created atlas bitmap 8192x1496 [mipmap]
   2.311 Created atlas bitmap 8192x800 [mipmap, smoke]
   2.324 Created atlas bitmap 8192x2500 [linear-minification, mipmap, terrain]
   2.351 Created atlas bitmap 8192x1140 [no-crop, trilinear-filtering, icon, light]
   2.368 Created atlas bitmap 8192x238 [alpha-mask]
   6.950 Sprites loaded
   6.950 Convert atlas 8192x1496 to: mipmap 
   6.983 Convert atlas 8192x800 to: mipmap 
   7.001 Convert atlas 8192x2500 to: min-linear 
   7.058 Convert atlas 8192x1140 to: trilinear-filtering 
   7.083 Convert atlas 8192x238 to: alpha-mask
   7.307 Custom inputs active: 5
   7.460 Factorio initialised
  16.235 Info HttpSharedState.cpp:54: Downloading https://mods.factorio.com/api/mods?page_size=max
  18.901 Info HttpSharedState.cpp:54: Downloading https://mods.factorio.com/api/mods?page_size=max
  38.818 Info HttpSharedState.cpp:127: Status code: 200
  53.335 Info HttpSharedState.cpp:54: Downloading https://mods.factorio.com/api/mods/Bottleneck
  53.916 Info HttpSharedState.cpp:127: Status code: 200
  55.599 Info ModPortal.cpp:286: Downloading /api/downloads/data/mods/365/Bottleneck_0.9.0.zip?username=Daniel599&token=<private> to C:\Users\noone\AppData\Roaming\Factorio\temp\Bottleneck_0.9.0.zip
  55.600 Info HttpSharedState.cpp:54: Downloading https://mods.factorio.com/api/downloads/data/mods/365/Bottleneck_0.9.0.zip?username=Daniel599&token=<private>
  56.543 Info HttpSharedState.cpp:127: Status code: 200
  57.217 Info HttpSharedState.cpp:54: Downloading https://mods.factorio.com/api/mods?page_size=max
  57.916 Info AppManager.cpp:861: Restarting Factorio
  58.022 Error CrashHandler.cpp:286: Exception Code: c0000005, Address: 0x00007ff6a1b7b06e
ModuleBase: 0x00007ff6a0fa0000, ImageSize: 012da000, RelativeAddress: 00bdb06e
  58.022 Error CrashHandler.cpp:292: Access Violation: Read at address 00000000000000F8
  58.022 Error CrashHandler.cpp:308: Exception Context:
rax=0000060af544253a, rbx=00000000000000f8, rcx=00000000000000f8,
rdx=0000000000000000, rsi=0000000000000000, rdi=0000028a9b0f8020,
rip=00007ff6a1b7b06e, rsp=000000a3928ffbe0, rbp=0000000000000000,
 r8=0000000038f9ce84,  r9=0000000000000000, r10=0000000000000000,
r11=0000000000000246, r12=00007ff6a1d50a10, r13=112e0be826d694b3,
r14=0000028a412a6e90, r15=0000028a412a6fe8
  58.022 Crashed in I:\Installed Games\SteamLibrary\steamapps\common\Factorio\bin\x64\Factorio.exe (0x00007ff6a0fa0000 - 0x00007ff6a227a000)
Factorio crashed. Generating symbolized stacktrace, please wait ...
c:\cygwin64\tmp\factorio-azf3kj\libraries\stackwalker\stackwalker.cpp (923): StackWalker::ShowCallstack
c:\cygwin64\tmp\factorio-azf3kj\src\util\logger.cpp (371): Logger::writeStacktrace
c:\cygwin64\tmp\factorio-azf3kj\src\util\logger.cpp (470): Logger::logStacktrace
c:\cygwin64\tmp\factorio-azf3kj\src\util\crashhandler.cpp (127): CrashHandler::writeStackTrace
c:\cygwin64\tmp\factorio-azf3kj\src\util\crashhandler.cpp (334): CrashHandler::SehHandler
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFC6EBF94F0)
00007FFC6EBF94F0 (KERNELBASE): (filename not available): UnhandledExceptionFilter
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFC71AA8508)
00007FFC71AA8508 (ntdll): (filename not available): memset
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFC71A90F56)
00007FFC71A90F56 (ntdll): (filename not available): _C_specific_handler
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFC71AA4C3D)
00007FFC71AA4C3D (ntdll): (filename not available): _chkstk
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFC71A1D1B8)
00007FFC71A1D1B8 (ntdll): (filename not available): RtlWalkFrameChain
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFC71AA3B6E)
00007FFC71AA3B6E (ntdll): (filename not available): KiUserExceptionDispatcher
f:\dd\vctools\crt\crtw32\stdcpp\thr\mutex.c (82): mtx_do_lock
c:\cygwin64\tmp\factorio-azf3kj\src\http\curlmanager.cpp (99): CurlManager::removeHandle
c:\cygwin64\tmp\factorio-azf3kj\src\modportal\modportal.cpp (227): ModPortal::processRequestsLoop
c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.12.25827\include\thr\xthread (232): std::_LaunchPad<std::unique_ptr<std::tuple<void (__cdecl RouterBase::*)(void) __ptr64,ClientRouter * __ptr64>,std::default_delete<std::tuple<void (__cdecl RouterBase::*)(void) __ptr64,ClientRouter * __ptr64> > > >::_Go
c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.12.25827\include\thr\xthread (211): std::_Pad::_Call_func
d:\th\minkernel\crts\ucrt\src\appcrt\startup\thread.cpp (115): thread_start<unsigned int (__cdecl*)(void * __ptr64)>
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFC70ED1FE4)
00007FFC70ED1FE4 (KERNEL32): (filename not available): BaseThreadInitThunk
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFC71A6EF91)
00007FFC71A6EF91 (ntdll): (filename not available): RtlUserThreadStart
  59.601 Error Util.cpp:67: Unexpected error occurred. If you're running the latest version of the game you can help us solve the problem by posting the contents of the log file on the Factorio forums.
Please also include the save file(s), any mods you may be using, and any steps you know of to reproduce the crash.
  82.403 Creating crash dump.
  82.977 CrashDump success

[wheybags]

Fixed for 0.16.7.
Thanks for the report!