[Oxyd] [16.2] Server crashes when added to steam favorites!

[XGhozt]

I'm not sure how many people use this... but I noticed that if I add a server the Steam "Servers" Favorites tab, it crashes Factorio 0.16.x 100% of the time.

Here's the log:

Code: Select all

Factorio crashed. Generating symbolized stacktrace, please wait ...
 158.969 Warning Logger.cpp:446: Symbols.size() == 13, usedSize == 11
#0  0x0000000000b0213d in Logger::logStacktrace(StackTraceInfo*) at /tmp/factorio-Aflnxh/src/Util/Logger.cpp:471
#1  0x00000000008a2aea in Logging::flush() at /tmp/factorio-Aflnxh/src/Util/Logging.cpp:61
#2  0x00000000008cc5af in Logging::logAndAbortOrThrow(char const*, unsigned int, LogLevel, std::string const&) at /tmp/factorio-Aflnxh/src/Util/Logging.cpp:79
#3  0x00000000009ad242 in Logging::logAndAbortOrThrow(char const*, unsigned int, LogLevel, char const*, ...) at /tmp/factorio-Aflnxh/src/Util/Logging.cpp:73
#4  0x00000000009ad2b9 in NetworkMessageType::reliable() const at /tmp/factorio-Aflnxh/src/Net/NetworkMessage.cpp:197
#5  0x00000000009ad394 in NetworkMessageHeader::NetworkMessageHeader(Deserialiser&) at /tmp/factorio-Aflnxh/src/Net/NetworkMessage.cpp:80
#6  0x00000000009aefcc in NetworkMessageHeader::operator=(NetworkMessageHeader&&) at /tmp/factorio-Aflnxh/src/Net/NetworkMessage.hpp:84 (discriminator 1)
#7  0x00000000009af323 in UnparsedNetworkMessage::setupHeaderFromDeserialiser() at /tmp/factorio-Aflnxh/src/Net/UnparsedNetworkMessage.cpp:115 (discriminator 1)
#8  0x000000000148910f in TransmissionControlHelper::receive(UnparsedNetworkMessage&) at /tmp/factorio-Aflnxh/src/Net/TransmissionControlHelper.cpp:124
#9  0x00000000000081b3 in RouterBase::readPacketsLoop() at /tmp/factorio-Aflnxh/src/Net/RouterBase.cpp:53
#10 (nil) in execute_native_thread_routine at tmpm6IF0.fake.c:?
 164.546 Warning Logger.cpp:446: Symbols.size() == 12, usedSize == 10
 164.546 Error NetworkMessage.cpp:197: Wrong network message type 31
Logger::writeStacktrace skipped.
 164.546 Error CrashHandler.cpp:128: Map tick at moment of crash: 55814
 164.546 Error Util.cpp:67: Unexpected error occurred. If you're running the latest version of the game you can help us solve the problem by posting the contents of the log file on the Factorio forums.
Please also include the save file(s), any mods you may be using, and any steps you know of to reproduce the crash.

I tested a few random public servers where I could find the IP address of and I was able to crash all of them. This seems like a pretty bad bug so I thought it was worth posting.

Edit: Unless I remove the server from my favorites, it just keeps crashing.

Edit2: Looks like 0.15.x servers do not crash (not fully tested, but I tried a few).

[Loewchen]

Post the complete log please, and change the title to the actual version of the game.

[XGhozt]

Post the complete log please, and change the title to the actual version of the game.

Thanks for the quick response.

This is repeatable on any public 0.16.0 0.16.1 and 0.16.2 server (hence the x). I just booted it up and added it to the server favorites and watched the log as it crashed. You really don't need the full log, this is reproducible and nothing out of the ordinary happened on the first 10 seconds the server was up. I looked at the "browse public server" list, picked 5 random servers and crashed all of them by adding it to my steam server favorites. The first part of the log includes my server IP, username, and other details I'd rather not post publicly.

If you can't reproduce this then I will censor and post it, but I find that unlikely.

[GeneralDotV2]

Attached is a server-side crash log of one of the servers that were crashed.

I just tried it myself with the same results.
Video of it being done. http://cdn.win-serv.com/ShareX/GeneralD ... 3%20AM.mp4

[Oxyd]

Thanks for finding this. Steam is trying to speak some protocol Factorio doesn't understand and the server crashes. Fixed in 0.16.4.

[XGhozt]

Thank you!