[posila] [0.16.2] two_direction_only = false is ignored

[steinio]

Hi,

the two_direction_only = false seems to be irgnored for storage tanks.
Only north and south are displayed.

Code: Select all

two_direction_only = false,
  	pictures =
    {
      picture =
      {
        north =
        {
          filename = "__StoneWaterWell__/graphics/stone-waterwell.png",
          priority = "extra-high",
          shift = {0.3, 0.8},
          width = 256,
          height = 256
        },
        east =
        {
          filename = "__StoneWaterWell__/graphics/stone-waterwell.png",
          priority = "extra-high",
          shift = {0.3, 0.8},
          x = 256,
          width = 256,
          height = 256
        },
        south =
        {
          filename = "__StoneWaterWell__/graphics/stone-waterwell.png",
          priority = "extra-high",
          shift = {0.3, 0.8},
          x = 512,
          width = 256,
          height = 256
        },
        west =
        {
          filename = "__StoneWaterWell__/graphics/stone-waterwell.png",
          priority = "extra-high",
          shift = {0.3, 0.8},
          x = 768,
          width = 256,
          height = 256
        }
    },

Greetings, steinio.

[posila]

Can you provide mod you have problem with, please?

[steinio]

Here you are.

Very good work so far, thank you for releasing 0.16.

Sorry for the console spam, debugging currently.
Please remove all game.players lines in control.lua.

Greetings, steinio.

Edit: The preview in hand is rotatable in all 4 directions.

[posila]

I am back.
So it is not a bug, remove tile_width from your prototype definition and it will work correctly. tile_width overrides assumed size of entity calculated from collision box, so your entity was considered to by 1x5 and therefore rotatable only by 180 degrees.

By the way ... we did some changes to offshore-pump definition (namely - way to slightly change buildability conditions), so maybe you would be able to use offshore-pump for this entity, instead of storage-tank, depending on how you need it to work.

[steinio]

I am back.
So it is not a bug, remove tile_width from your prototype definition and it will work correctly. tile_width overrides assumed size of entity calculated from collision box, so your entity was considered to by 1x5 and therefore rotatable only by 180 degrees.

By the way ... we did some changes to offshore-pump definition (namely - way to slightly change buildability conditions), so maybe you would be able to use offshore-pump for this entity, instead of storage-tank, depending on how you need it to work.

Thank you very much for your help.

The changes to the offshore pump sounds great and would replace the scripting but i guess it's out of my modding capabilities.
I'm just pushing the great skin of the well to new Factorio versions.

Greetings, steinio.