[kovarex] [15.33] Miner ghosts not on ore will still remove trees

This subforum contains all the issues which we already resolved.
User avatar
Seaish
Inserter
Inserter
Posts: 27
Joined: Fri Aug 25, 2017 9:40 pm
Contact:

[kovarex] [15.33] Miner ghosts not on ore will still remove trees

Post by Seaish »

This is pretty minor (ha) but worth documenting. If you shift-click a miner or a blueprint with a miner on some trees where there is no ore, it will still mark the trees for deconstruction even though it will never place the miner. I would expect the trees to be left alone, since there is no way to place the miner there. I'm not running any mods whatsoever. This is on multiplayer but probably can be reproduced on any configuration.

I also tried shift-clicking with landfill, but I imagine since trees can exist on land, behavior was as expected.

This probably happens because the order here is: User action -> if there are trees, remove them -> if miner entity, check for ore -> if no ore, break -> place ghost. It probably should be: User action -> if miner entity, check for ore -> if no ore, break -> if there are trees, remove them -> place ghost.
kovarex
Factorio Staff
Factorio Staff
Posts: 8298
Joined: Wed Feb 06, 2013 12:00 am
Contact:

Re: [kovarex] [15.33] Miner ghosts not on ore will still remove trees

Post by kovarex »

You are right.
But changing the order isn't that easy, as the buildability check method is far from trivial and checks all the things together. I believe that splitting the code isn't worth the almost non-existent problems arising from this.
Jap2.0
Smart Inserter
Smart Inserter
Posts: 2513
Joined: Tue Jun 20, 2017 12:02 am
Contact:

Re: [kovarex] [15.33] Miner ghosts not on ore will still remove trees

Post by Jap2.0 »

That's interesting - this doesn't seem to happen in Grey goo mk. I. Perhaps that has to do with logic regarding the Recursive blueprints mod, or perhaps it had to do with an old version.
There are 10 types of people: those who get this joke and those who don't.
User avatar
Seaish
Inserter
Inserter
Posts: 27
Joined: Fri Aug 25, 2017 9:40 pm
Contact:

Re: [kovarex] [15.33] Miner ghosts not on ore will still remove trees

Post by Seaish »

That sounds valid. Thanks for checking.
User avatar
ickputzdirwech
Filter Inserter
Filter Inserter
Posts: 798
Joined: Sun May 07, 2017 10:16 am
Contact:

Re: [kovarex] [15.33] Miner ghosts not on ore will still remove trees

Post by ickputzdirwech »

This has been fixed. When you try this now just nothing happens.
Mods: Shortcuts for 1.1, ick's Sea Block, ick's vanilla tweaks
Tools: Atom language pack
Text quickly seems cold and unfriendly. Be careful how you write and interpret what others have written.
- A reminder for me and all who read what I write
Post Reply

Return to “Resolved Problems and Bugs”