[0.15.10] map seed clears when changing settings preset

[malventano]

*edit* after looking into this further, it looks like the wrong blank is being cleared when changing the basic settings preset. The exchange string should actually be cleared, not the seed. Currently, the exchange string (incorrectly) remains after a preset has been changed, but the exchange string clears (as expected) if any resource settings, etc. are changed.

I recently made an exchange string of a notable map and wanted to restart it with a different resource preset. When pasting the string, resource settings from the string are also imported (as expected).
- If resource settings are changed on the resource settings tab, the map still starts as expected (same seed, etc) with the resource changes applied.
- If another default preset (basic settings tab) is selected, the seed is blanked and the player starts on a random map.
- If the seed was re-pasted after selecting a different default, the exchange string field is then blanked, but the player starts on the expected map.

...I'm not exactly sure of the expected behaviors here, but blanking the seed when changing the preset appears to be a bug, since the player may want to use just a different preset with the seed from the exchange string that they just entered, and changing the preset without noticing the seed went away results in starting on a vastly different map.

[Rseding91]

This is a side effect of having all settings reset to default when changing presets. See: viewtopic.php?f=11&t=45333&p=261133 The map seed is part of the settings and the default is "no seed" so when switching presets it clears everything back to the state when loading the game then applies the preset on top of it.

A preset can have its own map seed which would be filled when selecting the preset so this technically isn't a bug but working as intended.

[malventano]

Wait a sec, are you saying that some presets have specific seeds? I ask because that doesn't appear to be the case. All current presets appear to use random seeds, but each preset changes the other settings. If anything, it appears that the seed itself is never part of a preset.

In any case, changing the preset is still keeping the map exchange string populated, which looks to be a bug, because changing any individual setting clears the string, yet changing a preset (which changes *many* settings) does not clear it.

[Rseding91]

Wait a sec, are you saying that some presets have specific seeds? I ask because that doesn't appear to be the case. All current presets appear to use random seeds, but each preset changes the other settings. If anything, it appears that the seed itself is never part of a preset.

The current base-game presets don't. But any preset can.

In any case, changing the preset is still keeping the map exchange string populated, which looks to be a bug, because changing any individual setting clears the string, yet changing a preset (which changes *many* settings) does not clear it.

Ok, I fixed that for 0.15.11.

[malventano]

The current base-game presets don't. But any preset can.

Aah, ok, makes more sense now.

In any case, changing the preset is still keeping the map exchange string populated, which looks to be a bug, because changing any individual setting clears the string, yet changing a preset (which changes *many* settings) does not clear it.

Ok, I fixed that for 0.15.11.

Awesome. I appreciate you guys' impressive effort on this amazing game.