[0.14.22] Canceling deconstruction planner still changes BY

[mophydeen]

Canceling a deconstruction planner order still changes the build by playerName.

It should only change the name if there is a change to the entity.

Possible solution: add an extra value, field eg. 'marked by'
This could work for blueprints aswell.

a blueprint or a deconstruction order are not 'build ...'

[Rseding91]

That's by design. Marking it for deconstruction changes the entity and canceling deconstruction changes it again.

[mophydeen]

That's by design. Marking it for deconstruction changes the entity and canceling deconstruction changes it again.

This makes it impossible to know who build it if someone drags a deconstruction planner over it.

[Rseding91]

That's by design. Marking it for deconstruction changes the entity and canceling deconstruction changes it again.

This makes it impossible to know who build it if someone drags a deconstruction planner over it.

Yes, it's not a built-by property. It's a last-modified-by property.

Changing circuit conditions, rotating, changing recipes and so on will also update the value.

[darkfrei]

Yes, it's not a built-by property. It's a last-modified-by property.

Changing circuit conditions, rotating, changing recipes and so on will also update the value.

Can we suggest on_pre_marked_to_deconstruction?

[Rseding91]

Yes, it's not a built-by property. It's a last-modified-by property.

Changing circuit conditions, rotating, changing recipes and so on will also update the value.

Can we suggest on_pre_marked_to_deconstruction?

Why?

[DaveMcW]

Why?

Anti griefing mod.

Compare the player who last modified it to the player trying to deconstruct it.

[mophydeen]

what I would do:

* lastModifiedBy: someName (always visible for entities)
* markedBy: someName (only visible when marked for deconstruction or blueprint)
blueprint's markedBy is transfered to lastModifiedBy in case a robot build it. An other player in case he build it manualy.

tip: dont call it 'build by X' if it's modifiedBy.


just my 2c.

[Rseding91]

Why?

Anti griefing mod.

Compare the player who last modified it to the player trying to deconstruct it.

That's the wrong reason for such an event. Besides I've already got a proper solution to prevent griefing for 0.15.

[mophydeen]

Why?

Anti griefing mod.

Compare the player who last modified it to the player trying to deconstruct it.

That's the wrong reason for such an event. Besides I've already got a proper solution to prevent griefing for 0.15.

[darkfrei]

That's the wrong reason for such an event. Besides I've already got a proper solution to prevent griefing for 0.15.

Good news, everyone!

Why event.entity.last_user and event.player_index are always same?