Savegame taking as Excessively long time to load.

Bugs that are actually features.
Stevetrov
Fast Inserter
Fast Inserter
Posts: 134
Joined: Tue Jun 14, 2016 7:04 am
Contact:

Savegame taking as Excessively long time to load.

Post by Stevetrov »

My current save game is around 44MB so not massive but not small either.

It is a work in progress for my next mega-base, I have noticed intermittently that it can take a very long time to load (over 12 minutes) the progress bar fills up in a few seconds and then stops there.

It seems to be keeping a single CPU busy during this time judging by the CPU monitor and the memory doesn't seem to be going up or down. Factorio is running on my SSD, I have 16GB of RAM and about 50% of that is currently free. Factorio is using ~2.6GB of memory. My laptop has an i7 ivy bridge processor.

The only thing that is unusual about this base is that I have about 1,000,000 solar panels on the map as I have built the electricity generation but not the rest of the base.

The save is currently using a number of mods, but I have tried loading it without mods and it takes nearly as long to load.
The mods are:
UPS-up
Long reach
Created artefacts
squeeze through
creative mode
FARL
ScoreExtended
ZCS-Trash landfill
arumba lights
bobinserters

But as I said the game takes as long to load without the mods.

I am happy to share the save file if you tell me where to send it too.

This isn't a game breaking bug because once its loaded everything works fine.

I found a mention of someone having a similar bug but it was related to a mod they had created. Of course it could still be related to one of the mods I have currently loaded or something i have had loaded in the past but I have no idea how to find this out.

Thanks in advance.

Steve
User avatar
Klonan
Factorio Staff
Factorio Staff
Posts: 5410
Joined: Sun Jan 11, 2015 2:09 pm
Contact:

Re: Savegame taking as Excessively long time to load.

Post by Klonan »

Can you upload the save game here, along with a .zip of your mods folder
Stevetrov
Fast Inserter
Fast Inserter
Posts: 134
Joined: Tue Jun 14, 2016 7:04 am
Contact:

Re: Savegame taking as Excessively long time to load.

Post by Stevetrov »

Had problems uploading them to your website so I uploaded them to google instead.

https://drive.google.com/open?id=0B1Xuk ... klsM1VHdHc (mods folder)

https://drive.google.com/open?id=0B1Xuk ... W04LUpvWGs (savegame)

Thanks

Steve
Rseding91
Factorio Staff
Factorio Staff
Posts: 15938
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: Savegame taking as Excessively long time to load.

Post by Rseding91 »

You're using a mod that makes a 100x100 area electric pole.

That causes a massive slowdown in how electric networks are loaded in that every single electric pole and every single entity that can connect to power on load now has to search a 100x100 area around itself to see if there's a pole it should be connected to.

If you remove the "creative mode" mod, load the save and wait the 10 minutes it will then save and be loadable in normal times.
If you want to get ahold of me I'm almost always on Discord.
User avatar
hansinator
Fast Inserter
Fast Inserter
Posts: 160
Joined: Sat Sep 10, 2016 10:42 pm
Contact:

Re: Savegame taking as Excessively long time to load.

Post by hansinator »

Rseding91 wrote:You're using a mod that makes a 100x100 area electric pole.

That causes a massive slowdown in how electric networks are loaded in that every single electric pole and every single entity that can connect to power on load now has to search a 100x100 area around itself to see if there's a pole it should be connected to.

If you remove the "creative mode" mod, load the save and wait the 10 minutes it will then save and be loadable in normal times.
Ah that explains it, finally! Any chance it gets optimized?
Nexela
Smart Inserter
Smart Inserter
Posts: 1828
Joined: Wed May 25, 2016 11:09 am
Contact:

Re: Savegame taking as Excessively long time to load.

Post by Nexela »

It is optimized :) don't use poles with such big range, Think of creative-mode as more a testing mod.
Rseding91
Factorio Staff
Factorio Staff
Posts: 15938
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: Savegame taking as Excessively long time to load.

Post by Rseding91 »

I've looked into it but except in these extreme cases it's plenty fast. The problem is by making a 100x100 pole you've increased the amount of work it has to do by a factor of 123. The largest pole in the base game is 9x9.
If you want to get ahold of me I'm almost always on Discord.
Sparkysam
Long Handed Inserter
Long Handed Inserter
Posts: 50
Joined: Sun Dec 04, 2016 12:09 am
Contact:

Re: Savegame taking as Excessively long time to load.

Post by Sparkysam »

Rseding91 wrote:I've looked into it but except in these extreme cases, it's plenty fast. The problem is by making a 100x100 pole you've increased the amount of work it has to do by a factor of 123. The largest pole in the base game is 9x9.
It's not rare at all every game I play is like this constantly because of a single threaded performance of this game instead of multi. I don't have a 100x100 pole but yet my game is around the same size but still is exactly the same unless I configure my server and client to low clock speed and slower games speeds.
Rseding91
Factorio Staff
Factorio Staff
Posts: 15938
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: Savegame taking as Excessively long time to load.

Post by Rseding91 »

Sparkysam wrote:
Rseding91 wrote:I've looked into it but except in these extreme cases, it's plenty fast. The problem is by making a 100x100 pole you've increased the amount of work it has to do by a factor of 123. The largest pole in the base game is 9x9.
It's not rare at all every game I play is like this constantly because of a single threaded performance of this game instead of multi. I don't have a 100x100 pole but yet my game is around the same size but still is exactly the same unless I configure my server and client to low clock speed and slower games speeds.
What? You're saying your game takes 10 minutes to load?
If you want to get ahold of me I'm almost always on Discord.
Stevetrov
Fast Inserter
Fast Inserter
Posts: 134
Joined: Tue Jun 14, 2016 7:04 am
Contact:

Re: Savegame taking as Excessively long time to load.

Post by Stevetrov »

Rseding91 wrote:You're using a mod that makes a 100x100 area electric pole.

That causes a massive slowdown in how electric networks are loaded in that every single electric pole and every single entity that can connect to power on load now has to search a 100x100 area around itself to see if there's a pole it should be connected to.

If you remove the "creative mode" mod, load the save and wait the 10 minutes it will then save and be loadable in normal times.
Ah that would explain it. Thanks for the very high quality customer service provided at the weekend!!!
User avatar
hansinator
Fast Inserter
Fast Inserter
Posts: 160
Joined: Sat Sep 10, 2016 10:42 pm
Contact:

Re: Savegame taking as Excessively long time to load.

Post by hansinator »

Rseding91 wrote:I've looked into it but except in these extreme cases it's plenty fast. The problem is by making a 100x100 pole you've increased the amount of work it has to do by a factor of 123. The largest pole in the base game is 9x9.
I was thinking about a different approach than searching for poles, but it does make no sense because as you have laid out it is plenty fast except for such corner-cases where people are using "cheats". As it also only occurs during loading I'd say it is bearable.
Rseding91
Factorio Staff
Factorio Staff
Posts: 15938
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: Savegame taking as Excessively long time to load.

Post by Rseding91 »

hansinator wrote:
Rseding91 wrote:I've looked into it but except in these extreme cases it's plenty fast. The problem is by making a 100x100 pole you've increased the amount of work it has to do by a factor of 123. The largest pole in the base game is 9x9.
I was thinking about a different approach than searching for poles, but it does make no sense because as you have laid out it is plenty fast except for such corner-cases where people are using "cheats". As it also only occurs during loading I'd say it is bearable.
The current system exists as it does to allow electric poles to migrate size correctly when they're changed. I've looked into it and it's simply the massive increase in work that has to be done when you have something that large.

It's almost never good for performance when you take any number and crank it up to crazy levels :)
If you want to get ahold of me I'm almost always on Discord.
User avatar
hansinator
Fast Inserter
Fast Inserter
Posts: 160
Joined: Sat Sep 10, 2016 10:42 pm
Contact:

Re: Savegame taking as Excessively long time to load.

Post by hansinator »

Rseding91 wrote:The current system exists as it does to allow electric poles to migrate size correctly when they're changed. I've looked into it and it's simply the massive increase in work that has to be done when you have something that large.
You know I can't stop answering smart-ass suggestions if you keep the discussion alive ;-) What I was thinking about is to start from all poles and calculate a temporary bitmap (using bytes to represent a bit, for speed) representing powered tiles. The entities could use that as a lookup-table instead of searching for poles. It roughly performs independent of pole-effect-radius. However, just forget about this, for reasons stated in above posts :D

Edit: Filling a bitmap sequentially in a contiguous region of memory should be blazingly fast.
Sparkysam
Long Handed Inserter
Long Handed Inserter
Posts: 50
Joined: Sun Dec 04, 2016 12:09 am
Contact:

Re: Savegame taking as Excessively long time to load.

Post by Sparkysam »

Rseding91 wrote:
Sparkysam wrote:
Rseding91 wrote:I've looked into it but except in these extreme cases, it's plenty fast. The problem is by making a 100x100 pole you've increased the amount of work it has to do by a factor of 123. The largest pole in the base game is 9x9.
It's not rare at all every game I play is like this constantly because of a single threaded performance of this game instead of multi. I don't have a 100x100 pole but yet my game is around the same size but still is exactly the same unless I configure my server and client to low clock speed and slower games speeds.
What? You're saying your game takes 10 minutes to load?
I some cases yes after a desync, but most of the time it feel like it due to being around 80MB big and like 1GB uncompressed
Rseding91
Factorio Staff
Factorio Staff
Posts: 15938
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: Savegame taking as Excessively long time to load.

Post by Rseding91 »

Sparkysam wrote:I some cases yes after a desync, but most of the time it feel like it due to being around 80MB big and like 1GB uncompressed
That's because it's a desync report which is a different form of save file to let us debug what caused the desync. It's typically 10-20 times larger than the normal save and contains both the server state and the peer state at the time of desync.

Additionally that's not "time to load" - that's "time to download desync report from the server". The load time is when the game shows "loading" and the progress bar moves towards 100%.

If you do get desyncs (and you're not using mods that cause desyncs) please make bug reports here with the desync reports so we can fix them.
If you want to get ahold of me I'm almost always on Discord.
Post Reply

Return to “Not a bug”