[.14.21] Bob Inserters 0.14.2 Multiplayer Tick bug

[Nexela]

Bob, Found a bug with using inserters gui in multiplayer.

using game.connected_players the index returned from a for loop is NOT the player index http://lua-api.factorio.com/latest/LuaG ... ed_players
Without this change the gui will close immediately for some players when opening after players in mp disconnect/leave

Fixed code below by replacing index with player.index

on_tick

Code: Select all

script.on_event(defines.events.on_tick, function(event)
  if game.tick % 20 == 0 then
    if global and global.bobmods and global.bobmods.inserters then
      for _, player in pairs(game.connected_players) do
        if global.bobmods.inserters[player.index] then
          local entity = global.bobmods.inserters[player.index].entity
          if entity and (not entity.valid or not player.can_reach_entity(entity)) then
            bobmods.inserters.delete_gui(player.index)
          end
        else
          bobmods.inserters.create_global_table(player.index) -- Create for this specific online player.
        end
      end
    else
      for index, player in pairs(game.players) do -- Create for all if there are none.
        bobmods.inserters.create_global_table(index)
      end
    end
  end
end)

[bobingabout]

It's stuff like this that shows I'm pretty much just guessing with the whole thing. If it seems to work, it ships.

[Nexela]

You do a pretty good job of guessing

I would have never been able to figure out what the problem was if I had just not used game.connected_players in my own mod.

[bobingabout]

Well, it's done, uploading.

Actually, I fixed the code myself without copying yours, using your description of the issue, and came to the same result. except using variable _ for dummy, I just renamed index to i.

[Nexela]

I like to use _ otherwise luacheck throws warnings about unused variables

[bobingabout]

to which I'd say. what the heck is luacheck?

[Nexela]

https://github.com/mpeterv/luacheck#overview I can't live without it I typically use = instead of == in an if statement and luacheck yells at me as soon as I move to the next line.