[.14.21] Hard Crash on invalid ammo?

[Nexela]

Reporting this due to hard crash vs script crash
Game crashes to desktop during loop

Code: Select all

if ammo.valid_for_read then ammo.drain_ammo(1) end. 

code flow ->
entity-with-trigger-event (line:244)
find closest player with ammo and run function if found (line:149)
drain ammo spawn small poison clouds (line:129)

load the save with the mod, shoot into a group of trees (might have to shoot more then once, ammo is used at a rate of 1 per tree in range)

After adding ammo.valid checks before the ammo.valid_for_read checks in all the right places the crashes went away. Still happen but are more rare.

Expected Outcome: No crash

[Rseding91]

I'm not able to reproduce the crash. in anyway - it always works perfectly for me.

Can you post the log file? Does it show anything? If not, can you reproduce the crash on another computer? Maybe it's a hardware issue on yours.

[Nexela]

Had the log ready and forgot to post it. recreating them now.

Make sure you are shooting into big groups of trees, and spam shooting.

Had this error pop on Arumba's mp server, as well as locally on my PC testing in both SP and MP.

This log was generated shooting the termite ammo from the spawn position into the trees.

Local_log

0.000 2016-12-17 10:14:52; Factorio 0.14.21 (build 25327, win64, alpha)
0.000 Operating system: Windows 7 Service Pack 1
0.000 Program arguments: "E:\Games\Factorio_Web\Factorio_Experimental\bin\x64\factorio.exe"
0.000 Read data path: E:/Games/Factorio_Web/Factorio_Experimental/data
0.000 Write data path: E:/Games/Factorio_Web/Factorio_Experimental
0.000 Binaries path: E:/Games/Factorio_Web/Factorio_Experimental/bin
0.020 System info: [CPU: Intel(R) Core(TM) i7-4770K CPU @ 3.50GHz, 8 cores, RAM: 16267MB]
0.020 Display options: [FullScreen: 0] [VSync: 0] [UIScale: 100%] [MultiSampling: OFF] [Screen: 255]
0.021 Available display adapters: 1
0.021 [0]: \\.\DISPLAY1 - NVIDIA GeForce GTX 970 {0x05, [0,0], 1920x1080, 32bit, 60Hz}
0.022 Create display on adapter 0. Size 1280x720 at position [310, 162].
0.625 Initialised Direct3D:[0] NVIDIA GeForce GTX 970; driver: nvd3dumx.dll 21.21.13.7306
0.627 Video memory size (dedicated video/dedicated system/shared system/available): 4007/0/7877/3690 MB
0.669 DSound: Starting _dsound_update thread
0.669 DSound: Enter _dsound_update; tid=10972
0.669 Device reset internal.
0.672 Desktop composition is active.
0.672 Graphics options: [Graphics quality: normal] [Video memory usage: all] [Light scale: 100%] [DXT: false]
0.764 Loading mod core 0.0.0 (data.lua)
0.781 Loading mod base 0.14.21 (data.lua)
1.080 Loading mod Nanobots 1.0.5 (data.lua)
1.133 Loading mod Nanobots 1.0.5 (data-updates.lua)
1.179 Checksum for core: 1291735968
1.179 Checksum for mod base: 786624017
1.179 Checksum for mod Nanobots: 3293723923
1.457 Info PlayerData.cpp:55: Local player-data.json available, timestamp 1481977032
1.457 Info PlayerData.cpp:62: Cloud player-data.json unavailable
1.648 Initial atlas bitmap size is 16384
1.651 Created atlas bitmap 16384x8546
2.192 Created atlas bitmap 4096x968
2.211 Created atlas bitmap 4096x3652
7.738 Sprites loaded
7.738 Convert atlas 4096x968 to: trilinear-filtering
7.772 Convert atlas 4096x3652 to: mipmap
8.258 Loading sounds...
10.155 Custom inputs active: 0
10.155 Info Updater.cpp:749: Downloading https://updater.factorio.com/get-availa ... iVersion=2
10.519 0 packages available to download (experimental updates enabled).
10.579 Factorio initialised
141.726 Loading map E:\Games\Factorio_Web\Factorio_Experimental\saves\Devel\nanobots-crash.zip
141.850 Info Scenario.cpp:152: Map version 0.14.21-0
141.862 Checksum for script E:/Games/Factorio_Web/Factorio_Experimental/temp/currently-playing/control.lua: 1057114497
141.867 Checksum for script __Nanobots__/control.lua: 2042384197
144.681 Error CrashHandler.cpp:139: Exception Code: c0000005, Address: 0x000000013f9ec8aa
ModuleBase: 0x000000013f970000, ImageSize: 011e6000, RelativeAddress: 0007c8aa
144.681 Error CrashHandler.cpp:149: Exception Context:
rax=0000000000000000, rbx=0000000032160418, rcx=0000000000000000,
rdx=0000000000000001, rsi=0000000000000001, rdi=0000000032160418,
rip=000000013f9ec8aa, rsp=0000000008b7f2f0, rbp=0000000008b7f470,
r8=000000000ae91610, r9=000000003214ac68, r10=000000013f970000,
r11=0000000008b7f360, r12=0000000000000700, r13=0000000032160418,
r14=000000003214ac50, r15=00000000057ae870
144.681 Crashed in E:\Games\Factorio_Web\Factorio_Experimental\bin\x64\factorio.exe (0x000000013f970000 - 0x0000000140b56000)
Factorio crashed. Generating symbolized stacktrace, please wait ...
c:\cygwin64\tmp\factorio-bf8mp7\libraries\stackwalker\stackwalker.cpp (906): StackWalker::ShowCallstack
c:\cygwin64\tmp\factorio-bf8mp7\src\util\logger.cpp (337): Logger::writeStacktrace
c:\cygwin64\tmp\factorio-bf8mp7\src\util\logger.cpp (391): Logger::logStacktrace
c:\cygwin64\tmp\factorio-bf8mp7\src\util\crashhandler.cpp (105): CrashHandler::writeStackTrace
c:\cygwin64\tmp\factorio-bf8mp7\src\util\crashhandler.cpp (175): CrashHandler::SehHandler
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 000000007795BC10)
000000007795BC10 (kernel32): (filename not available): UnhandledExceptionFilter
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 0000000077B60108)
0000000077B60108 (ntdll): (filename not available): EtwEventSetInformation
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 0000000077AF7958)
0000000077AF7958 (ntdll): (filename not available): _C_specific_handler
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 0000000077B0812D)
0000000077B0812D (ntdll): (filename not available): RtlDecodePointer
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 0000000077AF855F)
0000000077AF855F (ntdll): (filename not available): RtlUnwindEx
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 0000000077B2BCB8)
0000000077B2BCB8 (ntdll): (filename not available): KiUserExceptionDispatcher
c:\cygwin64\tmp\factorio-bf8mp7\src\item\itemstack.cpp (861): ItemStack::remove
c:\cygwin64\tmp\factorio-bf8mp7\src\trigger\shooter.cpp (186): Shooter::useAmmo
c:\cygwin64\tmp\factorio-bf8mp7\src\entity\character.cpp (1528): Character::shoot
c:\cygwin64\tmp\factorio-bf8mp7\src\entity\character.cpp (444): Character::update
c:\cygwin64\tmp\factorio-bf8mp7\src\surface\chunk.cpp (502): Chunk::update
c:\cygwin64\tmp\factorio-bf8mp7\src\surface\surface.cpp (860): Surface::update
c:\cygwin64\tmp\factorio-bf8mp7\src\map\map.cpp (1132): Map::update
c:\cygwin64\tmp\factorio-bf8mp7\src\game.cpp (144): Game::update
c:\cygwin64\tmp\factorio-bf8mp7\src\scenario\scenario.cpp (842): Scenario::update
c:\cygwin64\tmp\factorio-bf8mp7\src\mainloop.cpp (761): MainLoop::gameUpdateStep
c:\cygwin64\tmp\factorio-bf8mp7\src\mainloop.cpp (630): MainLoop::gameUpdateLoop
c:\cygwin64\tmp\factorio-bf8mp7\src\util\workerthread.cpp (34): WorkerThread::loop
c:\program files (x86)\microsoft visual studio 14.0\vc\include\thr\xthread (247): std::_LaunchPad<std::unique_ptr<std::tuple<void (__cdecl WorkerThread::*)(void) __ptr64,WorkerThread * __ptr64>,std::default_delete<std::tuple<void (__cdecl WorkerThread::*)(void) __ptr64,WorkerThread * __ptr64> > > >::_Run
c:\program files (x86)\microsoft visual studio 14.0\vc\include\thr\xthread (210): std::_Pad::_Call_func
d:\th\minkernel\crts\ucrt\src\appcrt\startup\thread.cpp (115): thread_start<unsigned int (__cdecl*)(void * __ptr64)>
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00000000778D59CD)
00000000778D59CD (kernel32): (filename not available): BaseThreadInitThunk
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 0000000077B0A561)
0000000077B0A561 (ntdll): (filename not available): RtlUserThreadStart
147.049 Error CrashHandler.cpp:106: Map tick at moment of crash: 1938
147.049 Error Util.cpp:77: Unexpected error occurred. If you're running the latest version of the game you can help us solve the problem by posting the contents of the log file on the Factorio forums.
Please also include the save file(s), any mods you may be using, and any steps you know of to reproduce the crash.

partial server log (server crash didn't generate a crash message on clients, just on server)
This crash happens when shooting the ammo-nano-deconstructers on entities marked for deconstruction.

server

c:\cygwin64\tmp\factorio-skvdcq\src\item\itemstack.cpp (861): ItemStack::remove
c:\cygwin64\tmp\factorio-skvdcq\src\trigger\shooter.cpp (186): Shooter::useAmmo
c:\cygwin64\tmp\factorio-skvdcq\src\entity\character.cpp (1528): Character::shoot
c:\cygwin64\tmp\factorio-skvdcq\src\entity\character.cpp (444): Character::update
c:\cygwin64\tmp\factorio-skvdcq\src\surface\chunk.cpp (502): Chunk::update
c:\cygwin64\tmp\factorio-skvdcq\src\surface\surface.cpp (860): Surface::update
c:\cygwin64\tmp\factorio-skvdcq\src\map\map.cpp (1132): Map::update
c:\cygwin64\tmp\factorio-skvdcq\src\game.cpp (144): Game::update
c:\cygwin64\tmp\factorio-skvdcq\src\scenario\scenario.cpp (842): Scenario::update
c:\cygwin64\tmp\factorio-skvdcq\src\mainloop.cpp (761): MainLoop::gameUpdateStep
c:\cygwin64\tmp\factorio-skvdcq\src\mainloop.cpp (630): MainLoop::gameUpdateLoop
c:\cygwin64\tmp\factorio-skvdcq\src\util\workerthread.cpp (34): WorkerThread::loop
c:\program files (x86)\microsoft visual studio 14.0\vc\include\thr\xthread (247): std::_LaunchPad<std::unique_ptr<std::tuple<void (__cdecl WorkerThread::*)(void) __ptr64,WorkerThread * __ptr64>,std::default_delete<std::tuple<void (__cdecl WorkerThread::*)(void) __ptr64,WorkerThread * __ptr64> > > >::_Run
c:\program files (x86)\microsoft visual studio 14.0\vc\include\thr\xthread (210): std::_Pad::_Call_func
d:\th\minkernel\crts\ucrt\src\appcrt\startup\thread.cpp (115): thread_start<unsigned int (__cdecl*)(void * __ptr64)>
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 0000000076E5652D)
0000000076E5652D (kernel32): (filename not available): BaseThreadInitThunk
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 0000000076F8C521)
0000000076F8C521 (ntdll): (filename not available): RtlUserThreadStart
10529.648 Error CrashHandler.cpp:106: Map tick at moment of crash: 5217935
10529.648 Error Util.cpp:77: Unexpected error occurred. If you're running the latest version of the game you can help us solve the problem by posting the contents of the log file on the Factorio forums.

[Rseding91]

Fixed for 0.15.

[Nexela]

Awesome! Is there anything I can do on my end or just wait for .15, Not a big deal if I have to wait. The mod might not even be necessary for .15

Thanks for looking into it.

[Rseding91]

Awesome! Is there anything I can do on my end or just wait for .15, Not a big deal if I have to wait. The mod might not even be necessary for .15

Thanks for looking into it.

Don't drain the item stack to empty during that event