0.14.21 Infinite map download after desync

[mexmer]

Hi, i desynced then game did some local save, and reconnected, first it said - downloading 17MB ... that looked well, then ... guess it started increasing size and i closed it, after i did see



after i restarted game, it downloaded correctly, difference in size is quite obvious

log

factorio-previous.bck.log

(132.42 KiB) Downloaded 83 times

[Loewchen]

The download window does not tell you how big the complete download is, it just tells you how much it already downloaded. The file is bigger when created for a desync report because it contains additional information to diagnose the issue.
NaB.

[mexmer]

The download window does not tell you how big the complete download is, it just tells you how much it already downloaded. The file is bigger when created for a desync report because it contains additional information to diagnose the issue.
NaB.

Desync report was not created (we checked on both computers), also sorry to tell you, but like i said, it didn't end, it was going up by 1 MB every 2second, starting at 17MB.
there was definetly something wrong with the server save after desync, since when game created temporal local copy, it had just 12MB.


also if you look to log i uploaded, you can see than game is in desync loop, which is probly why download was going idenfinetly.

[Loewchen]

Desync report was not created

It could not, you did not finish the download.

also sorry to tell you, but like i said, it didn't end, it was going up by 1 MB every 2second, starting at 17MB.

But you killed it after 134s before it was completed, what makes you think it would not have finished when the download was complete?

there was definetly something wrong with the server save after desync, since when game created temporal local copy, it had just 12MB.

That would be completely fine since:

The file is bigger when created for a desync report because it contains additional information to diagnose the issue.

also if you look to log i uploaded, you can see than game is in desync loop, which is probly why download was going idenfinetly.

The log only shows a single desync, but even a loop would not show that there is anything wrong beyond the desync issue itself. Unless I am misunderstanding you, the behaviour and sequence of events look fine to me.

[mexmer]

so, according to you, it's correct, that after desync you get download, that is at least 6 times bigger than original game? (eg. normal behavior) - well 6times bigger is when i gave up, because size was increasing and download time remained constant.
or you saying, that counter for download after desync shows incorrect values (hence just informative random values and not bug)

or what exactly here is "not a bug"?

mind, this is in log

Code: Select all

10892.094 Downloading file C:\Users\Josef Micka\AppData\Roaming\Factorio\temp\mp-download.zip (170634241 B, 339234 blocks)
10892.095 Info ClientMultiplayerManager.cpp:539: MapTick(-1) changing state from(DesyncedSavingLocalVariantOfMap) to(DesyncedDownloadingMap) 

as you can see, it states 17MB, yet as you can see from screenshot, it was not half way trough at almost 100MB ... hence there is a bug, either it's in server, or in client.
assuming CLIENT display byte count as it receives (not just some random values created in void), it did never stop receiving data from server after 17MB, so that is still correct behavior?

usually, you get download (reconnect time save), then you "catch up to server", but client never got to that phase.

[mexmer]

as a side note, this is from log after i closed game and connected again

Code: Select all

 163.982 Info ClientRouter.cpp:219: ConnectionAccepted
 166.481 Info ClientMultiplayerManager.cpp:669: Received mapReadyForDownload
 166.481 Downloading file C:\Users\Josef Micka\AppData\Roaming\Factorio\temp\mp-download.zip (23578125 B, 46875 blocks)
 166.482 Info ClientMultiplayerManager.cpp:539: MapTick(-1) changing state from(ConnectedWaitingForMap) to(ConnectedDownloadingMap)
 199.050 Finished download (32 s, 23 MB, 723 kB/s)

you can assume, that "temporary" download issued by server after desync got "somewhat" broken, since obviously it will not magically increase by 6MB in 4 minutes.

[Loewchen]

so, according to you, it's correct, that after desync you get download, that is at least 6 times bigger than original game? (eg. normal behavior)

Yes, should be around 13x.

well 6times bigger is when i gave up, because size was increasing and download time remained constant.
or you saying, that counter for download after desync shows incorrect values (hence just informative random values and not bug)

No, what I am saying is, that you confuse the currently downloaded data with the file size.

Code: Select all

10892.094 Downloading file C:\Users\Josef Micka\AppData\Roaming\Factorio\temp\mp-download.zip (170634241 B, 339234 blocks)
10892.095 Info ClientMultiplayerManager.cpp:539: MapTick(-1) changing state from(DesyncedSavingLocalVariantOfMap) to(DesyncedDownloadingMap) 

as you can see, it states 17MB, yet as you can see from screenshot, it was not half way trough at almost 100MB ... hence there is a bug, either it's in server, or in client.
assuming CLIENT display byte count as it receives (not just some random values created in void), it did never stop receiving data from server after 17MB, so that is still correct behavior?

You might want to look at that number again...

usually, you get download (reconnect time save), then you "catch up to server", but client never got to that phase.

That would require the client to wait for the download to finish and not kill the application.

[mexmer]

so, according to you, it's correct, that after desync you get download, that is at least 6 times bigger than original game? (eg. normal behavior)

Yes, should be around 13x.

well 6times bigger is when i gave up, because size was increasing and download time remained constant.
or you saying, that counter for download after desync shows incorrect values (hence just informative random values and not bug)

No, what I am saying is, that you confuse the currently downloaded data with the file size.

Code: Select all

10892.094 Downloading file C:\Users\Josef Micka\AppData\Roaming\Factorio\temp\mp-download.zip (170634241 B, 339234 blocks)
10892.095 Info ClientMultiplayerManager.cpp:539: MapTick(-1) changing state from(DesyncedSavingLocalVariantOfMap) to(DesyncedDownloadingMap) 

as you can see, it states 17MB, yet as you can see from screenshot, it was not half way trough at almost 100MB ... hence there is a bug, either it's in server, or in client.
assuming CLIENT display byte count as it receives (not just some random values created in void), it did never stop receiving data from server after 17MB, so that is still correct behavior?

You might want to look at that number again...

usually, you get download (reconnect time save), then you "catch up to server", but client never got to that phase.

That would require the client to wait for the download to finish and not kill the application.

gosh, you right, it is 170MB

my apologiew then, download was not going to be infinite.

still having multiple times bigger save after desync, i would think there is and issue with server snapshot after desync.

[mexmer]

can't get "screenshot" of initial download size now, but i still believe it said 17MB, that's why i was stuck with that value in head, someone might want to check formating function of download message, just in case

anyways, thanks for you patience.