[MOD 0.14.x] Better Storage Tanks 0.3.6

[Reinard-kun]

Type: Mod
Name: Better Storage Tanks
Description: Factorio mod that allows picking up storage tanks without dumping their contents.
License: MIT
Version: 0.3.6
Release: 2016-09-18
Tested-With-Factorio-Version: 0.14.14
Category: Item
Tags: Tanker, Liquid, Storage Tank
Download-Url: Mod portal
Source-Url: GitHub repository

Long description

Long description
Usage:
Just mine a storage tank with any liquid in it and it will magically appear in your inventory. You can then place obtained item to build a storage tank with the same liquid amount and type. It should work with any liquid-adding mods, but I haven't tested it yet. I have added a GUI button to dump contents of a storage tank, so now you don't need to shoot it to empty it :^)
Disclaimer:
Mod might do some weird stuff sometimes, be sure to save your game every now and then and please report any bugs/errors to this thread.

current issues

Current issues
This section will be deleted when I consider that all's well.
Apparently, storage tanks of the same liquid MERGE into one with conbined contents. I have no idea why this happens, maybe it's the stack behaviour.
Error: if you have a full inventory and all empty slots on quickbar have filters set, the game crashes on attempt to mine a non-empty storage tank. Fixed!
Mod doesn't properly work with construction bots. When deconstructed, behaves normally. Can't be used to construct a blueprint. I don't know if this should be changed or not. When deconstructed, returns an empty tank. Disabled deconstruction for non-empty tanks. When trying to construct a storage tank - always uses and creates only empty storage tank.
Entity health is not retained through mining/placing. Entity health is properly retained.
Possible liquid duplication Fixed! (see credomane's post)

Version history

Version history
- 0.1.0 (2016-09-18): Initial release. Has item generator for all liquid types, but still no icon generator and no handler for a completely full inventory. Locale: en, ru, ja
- 0.1.1 (2016-09-18): Debug flag set to false, you can set it back to true in control.lua
- 0.2.0 (2016-09-19): Rebuilt handler for Storage Tank mining, now you can't mine stuff with full inventory. Fixed a bug with "ghost item" in hand
- 0.2.1 (2016-09-19): Added icon generator. Looks meh, but whatever. Fixed another "ghost item" in hand bug
- 0.2.2 (2016-09-19): Added GUI that allows to dump contents of the storage tank
- 0.2.3 (2016-09-20): Now liquid is properly removed from the entity before it is mined. No longer duplicates liquids in the system
- 0.3.0 (2016-09-23): Rebuilt handler AGAIN. Now it's less spaghetti and more code! Removed various bugs. Construction bots finally can properly place EMPTY Storage Tanks in blueprints (they used to use crude oil tanks because alphabet and reasons). Health is properly retained through mining and placing the storage tank.
- 0.3.1 (2016-09-23): Fixed crash on attempt to mine storage tank with filtered quickbar
- 0.3.2 (2016-09-23): Removed some silly code. Bots can't mine non-empty tanks anymore.
- 0.3.3 (2016-09-23): Added new data table, it should prevent issues with multiplayer (if there was any).
- 0.3.4 (2016-09-24): Fixed an error on deconstruction "Passed index is out of range".
- 0.3.5 (2016-09-24): Fixed an error on GUI click "Attempt to index field 'opened' (a nil value)".
- 0.3.6 (2016-10-17): Replaced .has_filters() with .supports_filters() because Factorio devs like clarity.

ToDo

To do
Main goal is to add a handler for when a player tries to mine a storage tank whilst having a full inventory. I plan to add an error message, kinda like "Can't insert X: inventory full.", and some code to cancel the attempt to mine the storage tank. it is done! Now it returns an error message and replaces the tank.
It would be nice to add icons for every tank with liquid. Icon generator is done!
I also really want to mess around with GUI and add "Dump contents" button, because at the moment there is no proper way to remove tank contents. Simple GUI done! Now you can see contents of a storage tank and dump them if you want.
Maybe it is a good idea to add bot behaviour, so they can mine tanks and keep the liquid inside. Currenlty there is no way to affect bot inventory.
Multiplayer testing? Multiplayer fixes? Different data table?... More questionmarks?

[credomane]

Just so you know vanilla Factorio doesn't actually "lose" the tank contents. If the pipes/tanks attached to the one you are picking up are not full then factorio will move the contents of the tank you are picking up into them. Anything over their filling point is lost though. In this fashion you can quickly "move" liquids around your base.

Not saying your mod doesn't have uses but that there might be a really easy way to duplicate fluids with it.

[Reinard-kun]

Just so you know vanilla Factorio doesn't actually "lose" the tank contents. If the pipes/tanks attached to the one you are picking up are not full then factorio will move the contents of the tank you are picking up into them.

I actually didn't know that liquid gets moved. I usually don't use more than one storage tank.

there might be a really easy way to duplicate fluids with it.

I guess the easy way to fix it is to clear entity.fluidbox before mining the tank. However, easy is not always correct, I'll test it and see if it works.

[credomane]

I normally have more than one light and heavy until I get the ability to crack them. Then I reduce tanks as I can. It was during one of my playthroughs that I noticed this behavior.

[Reinard-kun]

Turns out that the easy way IS the correct way to fix the problem. Now there should be no way to dupe more that 0.99 units of any liquid. Welp, only a few more problems to fix and the mod should be fine to use...

[Philip017]

error deconstructing track with robots - with this mod installed, error message in screen shot attached

[Reinard-kun]

error deconstructing track with robots - with this mod installed, error message in screen shot attached

Which OS, game version, mods and mods versions are you using? Can you try to list steps that will help reproduce the error?
EDIT: Found it, hotfix on it's way.

[The_Mak]

Bug Report

Factorio 0.14.9
Better Storage Tanks 0.3.4
TimeTools 1.0.26

TimeTools has a gui element that looks like a yellow dot and if you click it it is suppose to make it daylight. With Better Storage Tanks, when you click that button the following error pops up:

Code: Select all

Error while running event on_gui_click (ID 1) __better-storage-tanks__/control.lua:166: attempt to index field 'opened' (a nil value)

This can happen if you start a fresh game with the two mods and just click on the daylight button.

[Reinard-kun]

Bug Report

Factorio 0.14.9
Better Storage Tanks 0.3.4
TimeTools 1.0.26

TimeTools has a gui element that looks like a yellow dot and if you click it it is suppose to make it daylight. With Better Storage Tanks, when you click that button the following error pops up:

Code: Select all

Error while running event on_gui_click (ID 1) __better-storage-tanks__/control.lua:166: attempt to index field 'opened' (a nil value)

This can happen if you start a fresh game with the two mods and just click on the daylight button.

Should be fixed now. This issue might have been occuring with other mods that add gui buttons, so please download the latest patch.

[Severant]

Picked up a tank with wires attached to it, probably unrelated.
Lots of other mods on this server

Code: Select all

81182.679 Error MainLoop.cpp:766: Exception at tick 7790896: Error while running event on_player_mined_item (ID 8)
LuaItemStack API call when LuaItemStack was invalid.
stack traceback:
        __better-storage-tanks__/lib.lua:108: in function 'addItem'
        __better-storage-tanks__/control.lua:29: in function <__better-storage-tanks__/control.lua:20>
81182.679 Error ServerMultiplayerManager.cpp:93: MultiplayerManager failed: "Error while running event on_player_mined_item (ID 8)
LuaItemStack API call when LuaItemStack was invalid.
stack traceback:
        __better-storage-tanks__/lib.lua:108: in function 'addItem'
        __better-storage-tanks__/control.lua:29: in function <__better-storage-tanks__/control.lua:20>"
81182.679 Info ServerMultiplayerManager.cpp:649: mapTick(7790896) changing state from(InGame) to(Failed)

[Philip017]

also experiencing error again picking up sulfuric acid tank.

[Reinard-kun]

Heya people, sorry for being afk for like two weeks.
OK so both of these errors are most likely caused by an item stack error. Maybe you have mods that add extra inv types or something like that. I'm not sure if I can fix it without remaking the mod completely. If this error happens frequently I may just take down the mod or recommend not using it with certain mods, because I can't really fix it atm.

What happens is:
- mod sees that you tried to mine a storage tank
- mod tries to find a slot in the inventory, while removing an extra storage tank
in first case it
- finds a slot
- tries to add a storage tank with liquid, but fails
in second case
- mod fails because there is something wrong with the inventory / inventory slots

The code is as easy as it can get, so maybe in one of the latest updates something was changed with all the different inventory parameters.

EDIT 1: Wow. Just WOW. In one of the patches, key .has_filters() was changed to .supports_filters() I have no words. The definition of clarity change itself.

[Philip017]

thankyou for addressing this concern and for the fix, thanks!

[Reinard-kun]

thankyou for addressing this concern and for the fix, thanks!

It's all in the bug reports. This error actually breaks the mod, and I wouldn't have found it myself, because for the last 2.5 weeks I was playing nothing but Dark Souls 1, so thank YOU. If you find anything else please post here asap.

As for Severant's issue, sadly, I couldn't reproduce the bug, so I don't know how to fix the problem. If the mod is installed on the server, you can run the same pack in single, and then run just BST in multi and try to replicate the error in both cases.