GUI frame vertical lengh too long

[osldgoth]

I have a gui frame with children inside, the frame extends well below the last child. I have not been able to figure out how to shorten the frame.
Cut from the red line down:

picture

code snips

my code creating the frame

Code: Select all

...gui.top.add{type="frame", name="EMC_frame", caption="Entity: Color", direction="vertical", style="frame_style"}

frame_style from __core__/prototypes\style.lua

Code: Select all

frame_style =
    {
      type = "frame_style",
      font = "default-frame",
      font_color = {r=1, g=1, b=1},
      -- padding of the title area of the frame, when the frame title
      -- is empty, the area doesn't exist and these values are not used
      title_top_padding = 0,
      title_left_padding = 0,
      title_bottom_padding = 15,
      title_right_padding = 0,
      -- padding of the content area of the frame
      top_padding  = default_container_padding - 6,
      right_padding = default_container_padding,
      bottom_padding = default_container_padding,
      left_padding = default_container_padding,
      graphical_set =
      {
        type = "composition",
        filename = "__core__/graphics/gui.png",
        priority = "extra-high-no-scale",
        corner_size = {3, 3},
        position = {8, 0}
      },
      flow_style=
      {
        horizontal_spacing = default_container_padding,
        vertical_spacing = default_container_padding
      }
    }

on a side issue (maybe related) I'm not even sure how there are two columns. I used to have the children in a table but have since removed the table. Could each child element be adding to the vertical length?

[osldgoth]

perhaps I have discovered something.
if I remove the caption on the frame the child elements extend to the bottom edge of the frame:

no caption

if I make the caption much longer, the frame becomes wider allowing the child elements to reposition making fewer rows, but the frame height stays the same:

long caption

Is that a bug? my thought is that the frame height would be dynamic like frame width seems to be. or is there some frame setting I need to use?

[Helfima]

If u use a vertical frame, it try put all children in vertical before
2 way for ur problem
Use a table type guielement with 2 column
Or use a horizontal flow for label and button by row

[osldgoth]

Nevermind, I figured it out, all I need to do is have each "sprite-button"/"button" pair add to maximal_height.

via wiki

https://wiki.factorio.com/index.php?tit ... mal_height

Once the frame in question is added to the game I'll set the max height to be 50 (aprox height of caption + some padding),

code

Code: Select all

game.player.gui.top.EMC_frame.style.maximal_height = 50

after that it's only a matter of adding a number to that each time a child is added. What could go wrong?

Thanks for all the help

[Helfima]

Maximal value is juste for frame display. If u have more child is displayed out of the frame