[0.14.0] [kovarex] problem with left and top GUI

[binbinhfr]

Hi, it seems that LEFT gui are placed at the left of TOP gui, and not under it like before.

example here : the left window is part of player.gui.left and is inserted at the left of player.gui.top, making all the top bar move to the right.

if you want to reproduce, install my BlackMarket mod (updated to 0.14) and click on the TOP-coin-icon to open LEFT-window-interface
https://mods.factorio.com/mods/binbinhfr/BlackMarket

bug left top gui.jpg (215.3 KiB) Viewed 9927 times

[binbinhfr]

another example :

bug left top gui2.jpg (177.76 KiB) Viewed 9908 times

[Klonan]

Thanks for the report,

I did notice this too, but dismissed it at the time

[binbinhfr]

Dimissed ? Do you mean you corrected it ? Because it's quite annoying and was not corrected in 0.14.1

[Klonan]

Dimissed ? Do you mean you corrected it ? Because it's quite annoying and was not corrected in 0.14.1

You reported it on friday evening, after 0.14.1 was already being released,
It probably won't be fixed until sometime in the working week

[binbinhfr]

OK. Just wanted to understand this "dismissed" word. I thought that maybe you thought it was corrected, and infact it was not. But if it's still in the todo list, that's perfect.

[kovarex]

So the problem isn't that they overlap, but about the priority. Is it really a bug? or just a change.

[Nexela]

I hope this isn't a "change"

No they don't overlap but gui.left is now acting like gui.top_first. The way it is now if you add something to .left everything on .top gets pushed over and sometimes off the screen especially if your like me with way too many mods that add buttons.

Most mods use .top is for accessing the mod and .left is displaying the information.

[binbinhfr]

I agree that it is a bug too.
When several mods open a gui.left, you cannot even see the gui.top (main buttons bar) anymore...

[Mooncat]

Oh, didn't realize we have some discussion here.

It is a bug +1.
For me, and I believe also for most of our modders, gui.left is best for some GUI that doesn't exist permanently, e.g. custom entity GUI, and/or for those that use much space vertically, e.g. a long menu.
If it overlaps with gui.top, it will either
1) affect the position of GUI on gui.top whenever the GUI on gui.left is shown or hidden, which is bad, or
2) overlap with the GUI on gui.top, making it unusable, which is worse.

So, the best solution is to revert back to how it looked like in 0.13.

Furthermore, if you are going to make changes, I prefer a vertically aligned gui.left because we don't really need 2 horizontally aligned GUI.
I know here is for bug reports only, so it is fine if you don't make this change. I will make a request later.

[binbinhfr]

Furthermore, if you are going to make changes, I prefer a vertically aligned gui.left because we don't really need 2 horizontally aligned GUI.

Well, I must admit I do not really agree with this. Some of my mods are opening a large main window on left (spacebook, blackmarket) and then subwindows that could not fit under the previous one, so let just revert to 0.13 classical way of display.

Let just do not mix gui.left in gui.top, that is the main problem from now on.

See with spaceBook : half of the top bar is broken and some icons are out of the screen once the SpaceBook window is opened...

bug left top gui3.jpg (212.92 KiB) Viewed 9481 times

[binbinhfr]

More than that, I noticed that sometimes, closing the gui.left window leaves the gui.top in a strange position, not starting at 0,0 anymore... See :
Original state of gui.top bar :

bug left top gui4a.jpg (55.16 KiB) Viewed 9480 times

I open a gui.left "tools" window

bug left top gui4b.jpg (29.91 KiB) Viewed 9480 times

When I close it, the top bar does not return at the right place...

bug left top gui4c.jpg (25.57 KiB) Viewed 9480 times

[Mooncat]

Well, I must admit I do not really agree with this. Some of my mods are opening a large main window on left (spacebook, blackmarket) and then subwindows that could not fit under the previous one

To align GUI horizontally, I would prefer using a horizontal flow outside and then add GUI inside it. This way, I can adjust the flow's top_padding easily.
We can have a discussion on this topic later. I agree we just wait for gui.left to be reverted to 0.13 first.

[Mooncat]

Hi devs,
sorry if I bother you, but may I know is there any plan to fix this problem? I have tried 0.14.4 but the problem is still here.
I am making a big menu for my mod, so this problem is very visible for me.

[DaveMcW]

This bug is blocking me from migrating Blueprint String to 0.14.

[bk5115545]

Just ran into this and was wondering why the mod developers coded their GUI's like that.

Now I know it's a Factorio bug.

[kovarex]

I changed it, so the top gui is above the left gui for 0.14.5

[Mooncat]

I changed it, so the top gui is above the left gui for 0.14.5

Hope you mean it is gonna to be the same as 0.13. If so, thanks a lot.

[kovarex]

I changed it, so the top gui is above the left gui for 0.14.5

Hope you mean it is gonna to be the same as 0.13. If so, thanks a lot.

I also hope, I'm not sure I know all the ways to test it, so you tell me after a release

[Mooncat]

I also hope, I'm not sure I know all the ways to test it, so you tell me after a release

Sure.