Achievement rounding issue
-
- Filter Inserter
- Posts: 256
- Joined: Wed May 13, 2015 5:28 am
- Contact:
Achievement rounding issue
I recently hit 10k Circuits for the achievement, and noticed the rounding issue.
It should round down to give a more accurate impression of progress.
It should round down to give a more accurate impression of progress.
Re: Achievement rounding issue
hmm, seems fine to mePiggyWhiskey wrote:I recently hit 10k Circuits for the achievement, and noticed the rounding issue.
It should round down to give a more accurate impression of progress.
-
- Filter Inserter
- Posts: 256
- Joined: Wed May 13, 2015 5:28 am
- Contact:
Re: Achievement rounding issue
That was about 30-60 seconds before the achievement triggered. No green background.
Re: Achievement rounding issue
Hmm okayPiggyWhiskey wrote:That was about 30-60 seconds before the achievement triggered. No green background.
Thanks for the report
Re: Achievement rounding issue
I don't see anything in the image, and I don't know what is the issue.
Re: Achievement rounding issue
It's saying 10k/10k but the achievement didn't trigger yet. You're probably rounding these numbers up instead of down?kovarex wrote:I don't see anything in the image, and I don't know what is the issue.
Re: Achievement rounding issue
The problem is that goal is to reach 10k and the display shows there to be 10.0k while in reality it's probably around 9.99k rounded up.kovarex wrote:I don't see anything in the image, and I don't know what is the issue.
Re: Achievement rounding issue
Mirror:kovarex wrote:I don't see anything in the image, and I don't know what is the issue.
Re: Achievement rounding issue
I don't consider it a bug, it is a way rounding works.
Re: Achievement rounding issue
How is this not a bug? If the value is 9999 for example, it should be displayed as 9.9k, not 10.0k. It maybe is the way rounding works, but it's the wrong rounding.
Re: Achievement rounding issue
Same issue with fluids display: often you can see (2.0 of 2) or (3.0 of 3) resources highlighted as red.
Maybe you need to make custom rounding function for displayed values? because rounding up make no sense in context of available resources.
Maybe you need to make custom rounding function for displayed values? because rounding up make no sense in context of available resources.
Re: Achievement rounding issue
That's the thing - rounding doesn't give the result a non-programmer would expect. It should be rounded *down*, not to closest full number.kovarex wrote:I don't consider it a bug, it is a way rounding works.
Alternatively, why not just have higher precision numbers there? Just 3 significant positions doesn't make that much sense when you could fit pretty much anything there without too much trouble.