[0.12.x Steam] [kovarex] Keybindings when switching operating system

[fandingo]

I game on both Windows and Linux, sharing my current save via Steam syncing. I've noticed that when I switch from one to the other (doesn't matter which) a few of the keybindings break. The most important being enter/leave vehicle. It always gets set to a red unknown value.

Screenshot of the most recent Windows -> Linux transition:



I haven't customized any settings. Everything setting is stock.

[Klonan]

Thanks for the report,

Seems like it could be a big problem moving forward

[fandingo]

Here's a screen shot of a Linux -> Windows transition:



One thing I noticed was "show info." On Linux, it seems that the ALT keys show up separately. I use the left alt key in both operating systems. On Linux, Factorio shows the keybinding as ALT_L, but in Widows, it's just ALT. It may be a similar problem with enter/leave vehicle. If I remember correctly, it shows up as RETURN in Linux, but looking at Windows right now, it's ENTER. (That could be wrong. I didn't double check Linux.) (It's probably the same with the Lua console where SHIFT_L + ` is interferring with Windows' SHIFT + `.

I won't speculate too much about the input handling since I obviously don't have the source code. Nonetheless, perhaps there's a more generic representation of these keys available in your libraries that would treat ALT, ALT_L, and ALT_R the same and similarly for ENTER and RETURN.

[kovarex]

They keys are defined by the system, so there isn't easy general solution.

I made a translation table to standardize some of the key codes, I added

Code: Select all

RETURN->ENTER
ALT_L->ALT
ALT_R->ALT

If you give me more info (the config after saving the keys in linux would help. I can put more values there. (Like the numpad +/- or the console key)

[fandingo]

Here's my config in Linux after getting the keys fixed.

Config

Code: Select all

[controls]
editor-show-hard-difficulty=F11
editor-show-normal-difficulty=F10
editor-show-easy-difficulty=F9
editor-show-all-difficulties=F8
editor-edit-entity-details=t
editor-remove-entity=x
editor-tool-secondary-action=mouse-button-2
editor-tool-primary-action=mouse-button-1
cancel-craft-all=SHIFT + mouse-button-1
cancel-craft-5=mouse-button-2
cancel-craft=mouse-button-1
craft-all=SHIFT + mouse-button-1
craft-5=mouse-button-2
craft=mouse-button-1
toggle-console=SHIFT + grave
smaller-terrain-building-area=KP_Subtract
larger-terrain-building-area=KP_Add
pause-game=SHIFT + space
disconnect-train=v
connect-train=g
confirm-message=Tab
toggle-map=m
production-statistics=p
toggle-menu=Escape
zoom-out=mouse-wheel-down
zoom-in=mouse-wheel-up
toggle-driving=Return
shoot-selected=c
shoot-enemy=space
pick-items=f
rotate=r
drop-cursor=z
clean-cursor=q
quickbar-10=SHIFT + 5
quickbar-9=SHIFT + 4
quickbar-8=SHIFT + 3
quickbar-7=SHIFT + 2
quickbar-6=SHIFT + 1
clear-filter=CONTROL + mouse-button-3
fast-entity-split=CONTROL + mouse-button-2
inventory-split=CONTROL + mouse-button-2
stack-split=SHIFT + mouse-button-2
cursor-split=mouse-button-2
change-active-quickbar=x
quickbar-5=5
quickbar-4=4
quickbar-3=3
quickbar-2=2
quickbar-1=1
set-filter=mouse-button-3
fast-entity-transfer=CONTROL + mouse-button-1
inventory-transfer=CONTROL + mouse-button-1
stack-transfer=SHIFT + mouse-button-1
pick-item=mouse-button-1
next-weapon=q
show-info=Alt_L
open-gui=mouse-button-1
select-for-cancel-deconstruct=SHIFT + mouse-button-1
select-for-blueprint=mouse-button-1
paste-entity-settings=SHIFT + mouse-button-1
copy-entity-settings=SHIFT + mouse-button-2
remove-pole-cables=SHIFT + mouse-button-1
build-ghost=SHIFT + mouse-button-1
build=mouse-button-1
mine=mouse-button-2
close-gui=e
open-technology-gui=t
open-character-gui=e
move-down=s
move-left=a
move-right=d
move-up=w

Turns out I was wrong about SHIFT_L; it's always just SHIFT. I was right about ENTER/RETURN, though.

When I switched back to Linux today, I noticed that the Lua console binding wasn't broken, which was a little surprising. The only two with problems were RETURN and ALT_L, and it sounds like your patch covers that perfectly.


Thanks so much for looking into this. It's not a major problem by any stretch, but I'm really thankful how seriously you take the quality.

I doubt this is important, but worth mentioning that I'm using a US QWERTY keyboard with standard "us" layout (reported by setxkbmap).