[0.12.10] [kovarex] Crash on sticker creation.

[Adil]

I've tried attaching sticker to a single entity and game crashed.
Sticker in question is just renamed copy of vanilla one:

Sticker

Code: Select all

local gun_sticker= {type = "sticker",name = "guntrain-gun-sticker",
    flags = {"not-on-map"},flags = {},
    animation =
    { filename = "__base__/graphics/entity/slowdown-sticker/slowdown-sticker.png",
      priority = "extra-high",
      width = 11,height = 11,frame_count = 13,animation_speed = 0.4
    },
    duration_in_ticks = 30 * 60,
    magnitude = 0.5
  }

Capsule used differs in that the target is entity:

Capsule

Code: Select all

local gun_attacher=
{
    type = "capsule",
    name = "guntrain-gun-attacher",
    icon = "__GunTrains__/pic/gun_attacher.png",
    flags = {"goes-to-quickbar"},
    capsule_action =
    {
      type = "throw",
      attack_parameters =
      {
        type = "projectile",
        ammo_category = "capsule",
        cooldown = 60,
        range = 15,
        ammo_type =
        {
            category = "capsule",
            target_type = "entity",
            action =
            {
                type = "direct",
                action_delivery =
                {
                    type = "instant",
                    target_effects =
                    {
                        type = "create-entity",entity_name = "guntrain-gun-sticker",trigger_created_entity="true"
                    },
                }
            }
        }
      }
    },
    subgroup = "capsule",
    order = "b[ropeway-connector]",
    stack_size = 5,

Crash happened both when capsule was used on locomotive entity and when used on biter (of the player force though).

Crashlog_locomotive

Code: Select all

   0.000 2015-10-04 12:33:37; Factorio 0.12.10 (Build 17003, linux64)
   0.000 Operating system: Linux
   0.000 Program arguments: "./factorio" 
   0.000 Read data path: /home/d/Programs/f/factorio2/data
   0.000 Write data path: /home/d/Programs/f/factorio2
   0.000 Binaries path: /home/d/Programs/f/factorio2/bin
   0.013 Available display adapters: 1
   0.013  [0]: resolution 1366x768px at [0,0]
   0.013 Create display on adapter 0. Size 1266x668 at position [40, 32]. Monitor 0
   0.047 Initialised OpenGL:[0] Mesa DRI Intel(R) Haswell Mobile ; driver: 3.0 Mesa 10.1.3
   0.080 Graphics options: [FullScreen: false] [VSync: true] [UIScale: 100%] [MultiSampling: OFF] [Graphics quality: normal] [Video memory usage: all] [Screen: 255]
   0.134 Loading mod core 0.0.0 (data.lua)
   0.138 Loading mod base 0.12.10 (data.lua)
   0.188 Loading mod GunTrains 0.1.0 (data.lua)
   0.229 Loading mod GunTrains 0.1.0 (data-updates.lua)
   0.696 Initial atlas bitmap size is 8192
   0.709 Created atlas bitmap 8192x8188
   0.710 Created atlas bitmap 8192x7007
   9.040 Info Updater.cpp:720: Downloading https://www.factorio.com/updater/get-available-versions?username=di&token=<private>&apiVersion=2
  10.272 0 packages available to download (experimental updates enabled).
  10.314 Factorio initialised
  17.312 Info Scenario.cpp:123: Map version 0.12.10-2
Factorio crashed. Generating symbolized stacktrace, please wait ...
  49.133 Warning Logger.cpp:315: Symbols.size() == 30, usedSize == 23
#0  0x735ac9 in SignalHandler at /tmp/factorio-GYb0pI/src/Util/CrashHandler.cpp:141
#1  0x7fb608d22d40 in ?? at ??:0
#2  0x7c7f68 in _ZN7StickerC4ERK24EntityCreationParameters at /tmp/factorio-GYb0pI/src/Entity/Sticker.cpp:20
#3  0x7c8418 in createInternal at /tmp/factorio-GYb0pI/src/Entity/StickerPrototype.cpp:29
#4  0x48e0b0 in create at /tmp/factorio-GYb0pI/src/Entity/EntityPrototype.cpp:317
#5  0x717549 in applyInternal at /tmp/factorio-GYb0pI/src/Trigger/CreateEntityTriggerEffectItem.cpp:26
#6  0x54ecfd in apply at /tmp/factorio-GYb0pI/src/Trigger/TriggerEffectItem.cpp:43
#7  0x40bfb0 in apply at /tmp/factorio-GYb0pI/src/Trigger/TriggerEffect.cpp:25
#8  0x9706c5 in apply at /tmp/factorio-GYb0pI/src/Trigger/TriggerDelivery.cpp:15
#9  0x9710ac in apply at /tmp/factorio-GYb0pI/src/Trigger/DirectTriggerItem.cpp:15
#10 0x9717e8 in apply at /tmp/factorio-GYb0pI/src/Trigger/Trigger.cpp:18
#11 0x971b46 in doShoot at /tmp/factorio-GYb0pI/src/Trigger/Shooter.cpp:322
#12 0x97236b in doShoot at /tmp/factorio-GYb0pI/src/Trigger/Shooter.cpp:239
#13 0x6f6668 in shootInternal at /tmp/factorio-GYb0pI/src/Trigger/Shooter.cpp:220
#14 0x7d3cb9 in shoot at /tmp/factorio-GYb0pI/src/Trigger/Shooter.cpp:101
#15 0x6e760c in applyCapsule at /tmp/factorio-GYb0pI/src/Item/CapsuleAction.cpp:42
#16 0x7fadd3 in useItem at /tmp/factorio-GYb0pI/src/GameActionHandler.cpp:1208 (discriminator 1)
#17 0xa1dde1 in actionPerformed at /tmp/factorio-GYb0pI/src/GameActionHandler.cpp:205 (discriminator 4)
#18 0x6e6b38 in flushToListeners at /tmp/factorio-GYb0pI/src/Input/InputHandler.cpp:41
#19 0x7f5494 in flushActions at /tmp/factorio-GYb0pI/src/Input/InputHandler.cpp:34
#20 0xd2e2cf in updateCrcCheck at /tmp/factorio-GYb0pI/src/GameActionHandler.cpp:250
#21 0x7fb60a88f182 in update at /tmp/factorio-GYb0pI/src/GameActionHandler.cpp:245
#22 0x7fb608de647d in gameUpdateStep at /tmp/factorio-GYb0pI/src/MainLoop.cpp:244
  49.859 Warning Logger.cpp:315: Symbols.size() == 29, usedSize == 22
  49.859 Error Util.cpp:46: Unexpected error occurred. You can help us to solve the problem by posting the contents of the log file on the Factorio forums.

Crashlog_unit

Code: Select all

   0.000 2015-10-04 12:40:31; Factorio 0.12.10 (Build 17003, linux64)
   0.000 Operating system: Linux
   0.000 Program arguments: "./factorio" 
   0.000 Read data path: /home/d/Programs/f/factorio2/data
   0.000 Write data path: /home/d/Programs/f/factorio2
   0.000 Binaries path: /home/d/Programs/f/factorio2/bin
   0.014 Available display adapters: 1
   0.014  [0]: resolution 1366x768px at [0,0]
   0.014 Create display on adapter 0. Size 1266x668 at position [40, 32]. Monitor 0
   0.049 Initialised OpenGL:[0] Mesa DRI Intel(R) Haswell Mobile ; driver: 3.0 Mesa 10.1.3
   0.085 Graphics options: [FullScreen: false] [VSync: true] [UIScale: 100%] [MultiSampling: OFF] [Graphics quality: normal] [Video memory usage: all] [Screen: 255]
   0.139 Loading mod core 0.0.0 (data.lua)
   0.145 Loading mod base 0.12.10 (data.lua)
   0.203 Loading mod GunTrains 0.1.0 (data.lua)
   0.244 Loading mod GunTrains 0.1.0 (data-updates.lua)
   0.727 Initial atlas bitmap size is 8192
   0.741 Created atlas bitmap 8192x8188
   0.742 Created atlas bitmap 8192x7007
   9.091 Info Updater.cpp:720: Downloading https://www.factorio.com/updater/get-available-versions?username=di&token=<private>&apiVersion=2
  10.196 0 packages available to download (experimental updates enabled).
  10.236 Factorio initialised
  22.775 Info Scenario.cpp:123: Map version 0.12.10-2
Factorio crashed. Generating symbolized stacktrace, please wait ...
 335.038 Warning Logger.cpp:315: Symbols.size() == 30, usedSize == 23
#0  0x735ac9 in SignalHandler at /tmp/factorio-GYb0pI/src/Util/CrashHandler.cpp:141
#1  0x7f5a376b3d40 in ?? at ??:0
#2  0x7c7f68 in _ZN7StickerC4ERK24EntityCreationParameters at /tmp/factorio-GYb0pI/src/Entity/Sticker.cpp:20
#3  0x7c8418 in createInternal at /tmp/factorio-GYb0pI/src/Entity/StickerPrototype.cpp:29
#4  0x48e0b0 in create at /tmp/factorio-GYb0pI/src/Entity/EntityPrototype.cpp:317
#5  0x717549 in applyInternal at /tmp/factorio-GYb0pI/src/Trigger/CreateEntityTriggerEffectItem.cpp:26
#6  0x54ecfd in apply at /tmp/factorio-GYb0pI/src/Trigger/TriggerEffectItem.cpp:43
#7  0x40bfb0 in apply at /tmp/factorio-GYb0pI/src/Trigger/TriggerEffect.cpp:25
#8  0x9706c5 in apply at /tmp/factorio-GYb0pI/src/Trigger/TriggerDelivery.cpp:15
#9  0x9710ac in apply at /tmp/factorio-GYb0pI/src/Trigger/DirectTriggerItem.cpp:15
#10 0x9717e8 in apply at /tmp/factorio-GYb0pI/src/Trigger/Trigger.cpp:18
#11 0x971b46 in doShoot at /tmp/factorio-GYb0pI/src/Trigger/Shooter.cpp:322
#12 0x97236b in doShoot at /tmp/factorio-GYb0pI/src/Trigger/Shooter.cpp:239
#13 0x6f6668 in shootInternal at /tmp/factorio-GYb0pI/src/Trigger/Shooter.cpp:220
#14 0x7d3cb9 in shoot at /tmp/factorio-GYb0pI/src/Trigger/Shooter.cpp:101
#15 0x6e760c in applyCapsule at /tmp/factorio-GYb0pI/src/Item/CapsuleAction.cpp:42
#16 0x7fadd3 in useItem at /tmp/factorio-GYb0pI/src/GameActionHandler.cpp:1208 (discriminator 1)
#17 0xa1dde1 in actionPerformed at /tmp/factorio-GYb0pI/src/GameActionHandler.cpp:205 (discriminator 4)
#18 0x6e6b38 in flushToListeners at /tmp/factorio-GYb0pI/src/Input/InputHandler.cpp:41
#19 0x7f5494 in flushActions at /tmp/factorio-GYb0pI/src/Input/InputHandler.cpp:34
#20 0xd2e2cf in updateCrcCheck at /tmp/factorio-GYb0pI/src/GameActionHandler.cpp:250
#21 0x7f5a39220182 in update at /tmp/factorio-GYb0pI/src/GameActionHandler.cpp:245
#22 0x7f5a3777747d in gameUpdateStep at /tmp/factorio-GYb0pI/src/MainLoop.cpp:244
 335.768 Warning Logger.cpp:315: Symbols.size() == 29, usedSize == 22
 335.768 Error Util.cpp:46: Unexpected error occurred. You can help us to solve the problem by posting the contents of the log file on the Factorio forums.

[kovarex]

Ok, now (the next version 0.12.11) it correctly shows a message:

Code: Select all

Can't create sticker, target not specified.

The sticker can't be used this way, it can be only used on entity targets.

[Adil]

Wait a minute, didn't I use it on entity target?

[Rseding91]

Wait a minute, didn't I use it on entity target?

No, the trigger "create-entity" does not attach to a target/source when created - it simply creates the entity at a given position.

[Adil]

Whoops, I've got no idea how did that sneak in.
"create-sticker" doesn't trigger the "trigger_created_entity" event does it?