[0.12.8] [kovarex] Game crash when loading a save with modified mods

[Athmagor]

It seems the issue reported in another forum (https://forums.factorio.com/forum/vie ... 25&t=15440) has not been resolved.

I am modifying a set of mods (Bob's Mods) for my personal use. When trying to load a save game the game crashes within 3-4 seconds due to some interaction between an assembling machine and inserters.

Environment:
Windows 7 x64
Factorio versions - 12.5, 12.6, 12.7, x64 (confirmed also on 12.7 Win32)

Crash log from x64

Crash log from x64:

Code: Select all

   0.000 2015-09-12 16:56:38; Factorio 0.12.7 (Build 16743, win64)
   0.000 Operating system: Windows 7 Service Pack 1
   0.000 Program arguments: "D:\Games\FactorioBugReport\bin\x64\Factorio.exe" 
   0.000 Read data path: D:/Games/FactorioBugReport/data
   0.000 Write data path: D:/Games/FactorioBugReport
   0.000 Binaries path: D:/Games/FactorioBugReport/bin
   0.058 Initialised Direct3D:[0] NVIDIA GeForce GTX 980; driver: nvd3dumx.dll 9.18.13.4788
   0.058  [0]: \\.\DISPLAY1 - NVIDIA GeForce GTX 980 {0x05, [0,0], 2560x1600, 32bit, 60Hz}
   0.096 Desktop composition is active.
   0.096 Graphics options: [FullScreen: true] [VSync: true] [UIScale: 100%] [MultiSampling: OFF] [Graphics quality: normal] [Video memory usage: all] [Screen: 255]
   0.150 Loading mod core 0.0.0 (data.lua)
   0.152 Loading mod base 0.12.7 (data.lua)
   0.198 Loading mod bobultimate 0.11.1 (data.lua)
  15.235 Loading mod bobultimate 0.11.1 (data-updates.lua)
  16.598 Initial atlas bitmap size is 16384
  16.600 Created atlas bitmap 16384x7988
  28.043 Factorio initialised
  38.117 Loading map D:/Games\FactorioBugReport\saves\save.zip
  38.145 Info Scenario.cpp:160: Map version 0.12.5-3
Factorio crashed. Generating symbolized stacktrace, please wait ...
c:\temp\factorio-492cc159\libraries\stackwalker\stackwalker.cpp (923): StackWalker::ShowCallstack
c:\temp\factorio-492cc159\src\util\logger.cpp (283): Logger::writeStacktrace
c:\temp\factorio-492cc159\src\util\logger.cpp (337): Logger::logStacktrace
c:\temp\factorio-492cc159\src\util\crashhandler.cpp (81): CrashHandler::writeStackTrace
c:\temp\factorio-492cc159\src\util\crashhandler.cpp (90): CrashHandler::SehHandler
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 000000007763B940)
000000007763B940 (kernel32): (filename not available): UnhandledExceptionFilter
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 0000000077753398)
0000000077753398 (ntdll): (filename not available):  ?? ::FNODOBFM::`string'
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00000000776D85C8)
00000000776D85C8 (ntdll): (filename not available): _C_specific_handler
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00000000776E9D2D)
00000000776E9D2D (ntdll): (filename not available): RtlpExecuteHandlerForException
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00000000776D91CF)
00000000776D91CF (ntdll): (filename not available): RtlDispatchException
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 0000000077711248)
0000000077711248 (ntdll): (filename not available): KiUserExceptionDispatcher
c:\temp\factorio-492cc159\src\entity\assemblingmachine.cpp (348): AssemblingMachine::getStackLimit
c:\temp\factorio-492cc159\src\entity\assemblingmachine.cpp (198): AssemblingMachine::canInsert
c:\temp\factorio-492cc159\src\entity\inserter.cpp (568): Inserter::getPickupTarget
c:\temp\factorio-492cc159\src\entity\inserter.cpp (714): Inserter::update
c:\temp\factorio-492cc159\src\surface\chunk.cpp (444): Chunk::update
c:\temp\factorio-492cc159\src\surface\surface.cpp (811): Surface::update
c:\temp\factorio-492cc159\src\map\map.cpp (916): Map::update
c:\temp\factorio-492cc159\src\game.cpp (144): Game::update
c:\temp\factorio-492cc159\src\scenario\scenario.cpp (735): Scenario::update
c:\temp\factorio-492cc159\src\mainloop.cpp (253): MainLoop::gameUpdateStep
c:\temp\factorio-492cc159\src\mainloop.cpp (355): MainLoop::updateLoop
c:\boost_1_58_0\boost\function\function_template.hpp (160): boost::detail::function::void_function_obj_invoker0<boost::_bi::bind_t<void,void (__cdecl*)(ThreadBarrier * __ptr64,boost::chrono::time_point<boost::chrono::steady_clock,boost::chrono::duration<__int64,boost::ratio<1,1000000000> > > * __ptr64,boost::chrono::time_point<boost::chrono::steady_clock,boost::chrono::duration<__int64,boost::ratio<1,1000000000> > > * __ptr64,bool * __ptr64,bool),boost::_bi::list5<boost::_bi::value<ThreadBarrier * __ptr64>,boost::_bi::value<boost::chrono::time_point<boost::chrono::steady_clock,boost::chrono::duration<__int64,boost::ratio<1,1000000000> > > * __ptr64>,boost::_bi::value<boost::chrono::time_point<boost::chrono::steady_clock,boost::chrono::duration<__int64,boost::ratio<1,1000000000> > > * __ptr64>,boost::_bi::value<bool * __ptr64>,boost::_bi::value<bool> > >,void>::invoke
c:\temp\factorio-492cc159\src\util\thread.cpp (34): Thread::loop
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 000000013FD955C3)
000000013FD955C3 (Factorio): (filename not available): boost::`anonymous namespace'::thread_start_function
f:\dd\vctools\crt\crtw32\startup\threadex.c (376): _callthreadstartex
f:\dd\vctools\crt\crtw32\startup\threadex.c (354): _threadstartex
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00000000775B59ED)
00000000775B59ED (kernel32): (filename not available): BaseThreadInitThunk
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00000000776EC541)
00000000776EC541 (ntdll): (filename not available): RtlUserThreadStart
  54.875 Error Util.cpp:46: Unexpected error occurred. You can help us to solve the problem by posting the contents of the log file on the Factorio forums.

Crash log from Win32

Crash log from Win32:

Code: Select all

   0.000 2015-09-12 16:43:51; Factorio 0.12.7 (Build 16743, win32)
   0.000 Operating system: Windows 7 Service Pack 1
   0.000 Program arguments: "D:\Games\FactorioBugReport32\bin\Win32\Factorio.exe" 
   0.000 Read data path: D:/Games/FactorioBugReport32/data
   0.000 Write data path: D:/Games/FactorioBugReport32
   0.000 Binaries path: D:/Games/FactorioBugReport32/bin
   0.057 Initialised Direct3D:[0] NVIDIA GeForce GTX 980; driver: nvd3dum.dll 9.18.13.4788
   0.057  [0]: \\.\DISPLAY1 - NVIDIA GeForce GTX 980 {0x05, [0,0], 2560x1600, 32bit, 60Hz}
   0.088 Desktop composition is active.
   0.088 Graphics options: [FullScreen: false] [VSync: true] [UIScale: 100%] [MultiSampling: OFF] [Graphics quality: normal] [Video memory usage: all] [Screen: 0]
   0.134 Loading mod core 0.0.0 (data.lua)
   0.136 Loading mod base 0.12.7 (data.lua)
   0.187 Loading mod bobultimate 0.11.1 (data.lua)
   0.749 Loading mod bobultimate 0.11.1 (data-updates.lua)
   9.687 Initial atlas bitmap size is 16384
   9.690 Created atlas bitmap 16384x7993
  16.975 Factorio initialised
  23.905 Loading map D:/Games\FactorioBugReport32\saves\d35.zip
  23.948 Info Scenario.cpp:160: Map version 0.12.5-3
Factorio crashed. Generating symbolized stacktrace, please wait ...
c:\temp\factorio-cda79e67\libraries\stackwalker\stackwalker.cpp (904): StackWalker::ShowCallstack
c:\temp\factorio-cda79e67\src\util\logger.cpp (283): Logger::writeStacktrace
c:\temp\factorio-cda79e67\src\util\logger.cpp (337): Logger::logStacktrace
c:\temp\factorio-cda79e67\src\util\crashhandler.cpp (81): CrashHandler::writeStackTrace
c:\temp\factorio-cda79e67\src\util\crashhandler.cpp (90): CrashHandler::SehHandler
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 76970303)
76970303 (kernel32): (filename not available): GetProfileStringW
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 779174FF)
779174FF (ntdll): (filename not available): RtlKnownExceptionFilter
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 778D9F45)
778D9F45 (ntdll): (filename not available): RtlInitializeExceptionChain
  34.885 Error Util.cpp:46: Unexpected error occurred. You can help us to solve the problem by posting the contents of the log file on the Factorio forums.

Savegame and a mod zip:
https://drive.google.com/folderview?id= ... sp=sharing

Repro - just load a game and wait. Within 3-4 seconds the game freezes and then crashes. Upon loading there is a message box about removal of many items - this is expected as the modification is still a work in progress. Additionally I removed a lot of items to simplified the mod content and still have a repro.

The same gamesave is fine when loaded with the original set of mods.

Note: The game itself loads _much_ faster when the mod is unpacked.

[kovarex]

Woa, it took me most of the day to get through this one, as I was on the wrong lead for most of the time.

This actually revealed pretty big problem related to assembling machines, that could become whenever recipes are changed and assembling machines used these.

Basically, whenever recipe is changed (it now happens only when you change mods, but in the future, we plan it to be possible to change it in game through research), this problem would arise.

Anyway, thank you for the report and the files, it is fixed for 0.12.8

[Athmagor]

Woa, it took me most of the day to get through this one, as I was on the wrong lead for most of the time.

This actually revealed pretty big problem related to assembling machines, that could become whenever recipes are changed and assembling machines used these.

Basically, whenever recipe is changed (it now happens only when you change mods, but in the future, we plan it to be possible to change it in game through research), this problem would arise.

Anyway, thank you for the report and the files, it is fixed for 0.12.8

Glad to be of help Congratulations on squishing that one down!

[kovarex]

Note: The game itself loads _much_ faster when the mod is unpacked.

Hm, I had to investiage this problem. And it is now fixed for 0.12.9. Zip packages will load as fast, or even faster than the unpacked version in 0.12.9

[Athmagor]

Note: The game itself loads _much_ faster when the mod is unpacked.

Hm, I had to investiage this problem. And it is now fixed for 0.12.9. Zip packages will load as fast, or even faster than the unpacked version in 0.12.9

Super sweet

The crash problem is confirmed as fixed.