[0.12.7] [Rseding91] CTD when shift+clicking cannon shells while in tank

[StiffarmSoy]

I was able to reproduce this successfully, and I vaguely recall a similar issue in previous versions related to moving things into power armor slots by shift+clicking, maybe related?

Steps to reproduce:

1. Have cannon shells in inventory
2. Enter tank
3. Open inventory
4. Attempt to move shells into tank ammo inventory from player inventory by shift clicking on them
5. Crash to desktop

It's a minor edge-case type issue, but I thought I would report it anyway. My apologies if this has been reported previously, I did attempt to search but couldn't find anything that looked related.

[Klonan]

What is needed:

Mods
Log file
Save game
System info

[jeroon]

can confirm, Win 10 - x64 zip

Without mods it's fine, but when I do it with launch-control_0.1.1 mod it crashes with "Unexpected error" message.

launch-control_0.1.1.zip

(14 KiB) Downloaded 192 times

_autosave2.zip

(12.12 MiB) Downloaded 194 times

factorio-current.log

(5.13 KiB) Downloaded 209 times

[Rseding91]

I'm not able to reproduce the crash using that save and the mod. I tried:

Shift click ammo in tank ammo slot
Put some ammo in the main inventory and shift click it/control click it
Control click entire inventory
Control click ammo in tank
Move all ammo to tank inventory, main inventory or drop it and shift click it around

No matter what I do I can't get it to crash. Do you have any other save files with steps to reproduce the issue?

[StiffarmSoy]

I'm not able to reproduce the crash using that save and the mod. I tried:

Shift click ammo in tank ammo slot
Put some ammo in the main inventory and shift click it/control click it
Control click entire inventory
Control click ammo in tank
Move all ammo to tank inventory, main inventory or drop it and shift click it around

No matter what I do I can't get it to crash. Do you have any other save files with steps to reproduce the issue?

This is in vanilla. Were you inside the tank when you tried to reproduce?

[Rseding91]

I'm not able to reproduce the crash using that save and the mod. I tried:

Shift click ammo in tank ammo slot
Put some ammo in the main inventory and shift click it/control click it
Control click entire inventory
Control click ammo in tank
Move all ammo to tank inventory, main inventory or drop it and shift click it around

No matter what I do I can't get it to crash. Do you have any other save files with steps to reproduce the issue?

This is in vanilla. Were you inside the tank when you tried to reproduce?

Yes.

[Rseding91]

This is in vanilla. Were you inside the tank when you tried to reproduce?

Can you please upload the save where you have the crash?

[StiffarmSoy]

My apologies, I wasn't at the PC where the save was located when I posted before.

I'm also wondering if there is still some confusion on the reproduction, as I was able to do it again just before uploading the save. I'm not opening the tank's inventory while I'm inside it, I'm opening the player inventory and attempting to move the cannon shells from there by shift+clicking.

Attached is the log file I just produced with this most recent crash, and the save file. I've placed the player right outside the tank, all you should have to do to reproduce is jump in the tank, open the player inventory, and shift+click the shells.

factorio-current.log

Log File

(1.41 KiB) Downloaded 143 times

patch1.zip

Save File

(3.87 MiB) Downloaded 163 times

EDIT: I just tested, and I was able to reproduce the issue using the same steps but substituting ctrl+click instead.

[Rseding91]

Ok, I found out how to reproduce it. Now to figure out what the proper fix is for it.

[StiffarmSoy]

I did a little more testing and it seems to affect both the tank and the car for all of their respective ammo types.

[Rseding91]

Thanks for the report. This is now fixed for 0.12.8.