[MOD 0.12.x] Corpse Collector (Dytech)

Topics and discussion about specific mods
SpeedyBrain
Long Handed Inserter
Long Handed Inserter
Posts: 77
Joined: Wed May 20, 2015 12:08 am
Contact:

[MOD 0.12.x] Corpse Collector (Dytech)

Post by SpeedyBrain »

Type: Mod
Name: Dytech Corpse Collector
Description: A chest that picks up Dytech Corpses and SupremeWarfare SmallAlienArtifacts from the ground.
License: MIT
Version: 1.13.0
Release: 2015-08-24
Tested-With-Factorio-Version: 0.12.4
Category: Other
Tags: Dytech, Cropse, Collector, SMA
Made by: DOSorDIE and SpeedyBrain
License
Long description
Download:
Dytech_Corpse_Collector_1.13.0.zip
(22.43 KiB) Downloaded 504 times
[/size]
ImageImageImageImage
grifter1
Inserter
Inserter
Posts: 37
Joined: Sat Aug 08, 2015 5:53 am
Contact:

Re: [MOD 0.12.x] Corpse Collector (Dytech)

Post by grifter1 »

Hi

Thanks for the mod but im having trouble finding the chest is there a research pre reck
SpeedyBrain
Long Handed Inserter
Long Handed Inserter
Posts: 77
Joined: Wed May 20, 2015 12:08 am
Contact:

Re: [MOD 0.12.x] Corpse Collector (Dytech)

Post by SpeedyBrain »

grifter1 wrote:Hi

Thanks for the mod but im having trouble finding the chest is there a research pre reck
No research needed. :)
Image
I realised it's a bit expensive... Don't you think?
ImageImageImageImage
Rseding91
Factorio Staff
Factorio Staff
Posts: 14286
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [MOD 0.12.x] Corpse Collector (Dytech)

Post by Rseding91 »

Interesting :) Where did you get the code and license for this mod?

I did notice there are a few problems with the way you've changed the mod:
  • You hard-coded all of the surface references to the default game surface so it won't work with modded surfaces
  • The way the mod is written it won't work with anything other than the default player force (0.12 added support for more than the default forces)
  • The way you've implemented the filters creates a lot of extra LuaItemStack objects (extra CPU time and memory cleanup to create and dispose of them)
I updated my mod for 0.12 and multi-surface + multi-force support here if you'd like to look at it.
Form post: https://forums.factorio.com/forum/vie ... 0&start=20
Github page to the 0.12 update: https://github.com/Rseding91/Item-Colle ... 6c97bdbeb9

Also if you wanted to implement filters this is how I'd recommend doing them: https://github.com/Rseding91/Item-Colle ... 27f2e63c7a
If you want to get ahold of me I'm almost always on Discord.
Post Reply

Return to “Mods”