[0.16.2] Crash on save on: "Chunk::preSaveHook"

[SilentStorm]

c:\cygwin64\tmp\factorio-6zv5gs\src\surface\chunk.cpp:160

Had the map open and was going to look for things elsewhere (zoomed out), according to the dump file, the auto save was kicking in and the game crashed.

Code: Select all

>	factorio.exe!Chunk::preSaveHook(MapSerialiser & output) Line 160	C++	Symbols loaded.
 	factorio.exe!Surface::preSaveHook(MapSerialiser & output) Line 578	C++	Symbols loaded.
 	factorio.exe!Map::save(MapSerialiser & output, ProgressObserver * savingObserver) Line 1109	C++	Symbols loaded.
 	factorio.exe!Scenario::saveMap(SaveType saveType, ZipPackageWriter & packageWriter, TargetSerialiser & targetSerialiser, ProgressObserver * savingObserver, bool & gameStateCorruptionDetected) Line 624	C++	Symbols loaded.
 	factorio.exe!Scenario::saveAs(const std::experimental::filesystem::Path & savePath, const std::basic_string<char,std::char_traits<char>,std::allocator<char> > & saveName, const std::experimental::filesystem::Path & previewFullPath, ProgressObserver * savingObserver, SaveType saveType) Line 551	C++	Symbols loaded.
 	factorio.exe!ParallelScenarioSaver::doSave(ParallelScenarioSaver * saver) Line 92	C++	Symbols loaded.
 	[Inline Frame] factorio.exe!std::_Invoker_functor::_Call(void(*)(ParallelScenarioSaver *) &&) Line 232	C++	Symbols loaded.
 	[Inline Frame] factorio.exe!std::invoke(void(*)(ParallelScenarioSaver *) &&) Line 232	C++	Symbols loaded.
 	[Inline Frame] factorio.exe!std::_LaunchPad<std::unique_ptr<std::tuple<void (__cdecl*)(ParallelScenarioSaver *),ParallelScenarioSaver *>,std::default_delete<std::tuple<void (__cdecl*)(ParallelScenarioSaver *),ParallelScenarioSaver *> > > >::_Execute(std::tuple<void (__cdecl*)(ParallelScenarioSaver *),ParallelScenarioSaver *> &) Line 240	C++	Symbols loaded.
 	[Inline Frame] factorio.exe!std::_LaunchPad<std::unique_ptr<std::tuple<void (__cdecl*)(ParallelScenarioSaver *),ParallelScenarioSaver *>,std::default_delete<std::tuple<void (__cdecl*)(ParallelScenarioSaver *),ParallelScenarioSaver *> > > >::_Run(std::_LaunchPad<std::unique_ptr<std::tuple<void (__cdecl*)(ParallelScenarioSaver *),ParallelScenarioSaver *>,std::default_delete<std::tuple<void (__cdecl*)(ParallelScenarioSaver *),ParallelScenarioSaver *> > > > *) Line 247	C++	Symbols loaded.
 	factorio.exe!std::_LaunchPad<std::unique_ptr<std::tuple<void (__cdecl*)(ParallelScenarioSaver * __ptr64),ParallelScenarioSaver * __ptr64>,std::default_delete<std::tuple<void (__cdecl*)(ParallelScenarioSaver * __ptr64),ParallelScenarioSaver * __ptr64> > > >::_Go() Line 232	C++	Symbols loaded.
 	factorio.exe!std::_Pad::_Call_func(void * _Data) Line 211	C++	Symbols loaded.
 	[Inline Frame] factorio.exe!invoke_thread_procedure(unsigned int(*)(void *) context, void * const) Line 91	C++	Symbols loaded.
 	factorio.exe!thread_start<unsigned int (__cdecl*)(void * __ptr64)>(void * const parameter) Line 115	C++	Symbols loaded.
 	[External Code]		Annotated Frame

[posila]

Thanks for the report.
Unfortunatelly stacktrace was not very helpful in determining cause of the crash. Do you have save that would crash more frequently?
It's also possible the game state got corrupted due to bugs in electric network, or logistic network that have been already fixed.

[SilentStorm]

I only ever had two crashes playing Factorio, this was the first, the other was the NPE in the electric network.
So unfortunately (from a developer pov) this didn't happen more than that one time. I do not know which save had this crash. I should however still have the crashdump. If that would help any, it can be provided in private.