[1.1.5] take_screenshot with anti-alias produces partially blurred image

[eradicator]

What?

When using {anti_aliasing = true} some objects, but not all, are slightly shifted in position and heavily blurred. The effect gets stronger with lower graphics quality settings.

Examples

I took two screenshots (with and without anti-aliasing) on low texture settings and made a before-after gif. When taken on high settings the trees aren't blurred, but the decorations still are.

Code: Select all

   0.174 Graphics options: [Graphics quality: normal] [Video memory usage: all] [Light scale: 25%] [DXT: low-quality] [Color: 32bit]
   0.175                   [Max threads (load/render): 32/4] [Max texture size: 4096] [Tex.Stream.: 0] [Rotation quality: low] [Other: sTDCwt] [B:0,C:0,S:105]

Code: Select all

/c
  local player = game.player
  game.take_screenshot {
  allow_in_replay = false,
  anti_alias = true,
  by_player = player,
  daytime = 1,
  force_render = true,
  path = "screenshot_066h_01m_35s.png",
  player = player,
  position = {
    x = 438.5,
    y = 28.5
  },
  quality = 80,
  resolution = {
    416,
    288
  },
  show_entity_info = true,
  show_gui = false,
  surface = player.surface,
  zoom = 1
}

anti_aliasing_blurred.gif (111.58 KiB) Viewed 787 times

[posila]

Meh. I don't know who convinced me to not get rid of the anti-alias parameter, all it does is to render the screenshot in twice the size and then scales it down to half the size using basic bilinear filter. So, what I am considering a bug is that the image is not fully blurred.

Also, the way things shift a little bit is a bit weird and clearly a flaw. However this is due to some "rounding to pixels" logic, which is there so that things don't change width and/or height by 1px when scrolling through the world causing wobbling effect ... so I am not gonna mess with that either.

[eradicator]

Meh.

Agreed.

I don't know who convinced me to not get rid of the anti-alias parameter

't wasn't me, that i know .

basic bilinear filter

Oh my. That settles it then, i'll remove the option from my mod and give users a chance to use an external program with a modern scaling algorithm .

Thanks for looking into it, and cheers to another one for the archive.