[2.0.23] Technology give-item Effect Reapplied upon mod change

[Sarahtoma12354]

Reproduction Steps:

• Load into a save with a mod using the give-item technology effect (I've used Speedstart by Sarahtoma)
• Research a technology with the give-item technology effect
• Save and exit the save
• Add or remove a mod with a technology (I've added Text Plates by Earendel in my testing) and reload mods
• Load the save, and receive the items again

What did you do?

• Added a mod while having a give-item technology researched.

What happened?

• The character was given the items a second time after reloading.

What did you expect to happen instead? It might be obvious to you, but do it anyway!

• The character not to be given the technology effect a second time

Does it happen always, once, or sometimes?

• Always, only with give-item effects, also tested with recipe and mining speed bonus effects.

Other info

• Two log files and a save included. The first log contains loading the game with Speedstart and researching the give-item technology.
• The second log is after reloading with Text Plates enabled.
• The save is after researching the technology, before enabling Text Plates. I don't guarantee this save to give the same effects, as this is loading dependent (But doesn't take long to replicate)

[boskid]

This is so marginal i do not know if its even a bug. When technologies are changed, all effects are reapplied since if there were new effects added they should unlock. Give item is annoying because it is hard to track if it was already given. If there was a mod added that changed given item, should new item be given or not since old item was given. How should the game even tell if this technology had a give-item effect before - if it was just added it must trigger. Maybe that new item is mandatory to finish the game while old one was not. This effect cannot simply be reverted because it would need to take away those items from you wherever thosr items are or if thet were used to craft or build stuff.

I am going to say that its Not a bug and simply an inherent limitation of give-item effect. If mods want something more robust they can track on their own if items were already given regardless of technology tree changes and decide if new items should be given again or not.

[Sarahtoma12354]

understandable, though this is all without un-researching the technology or removing the mod its from. the only changes are with other unrelated mods.

[boskid]

It does not matter, game has no access to prototypes as they were before so it cannot tell which specific effects were already applied and which ones were just added. 99% of issues there were was that a mod was added, it added new recipe and injected a recipe unlock into one of existing technologies. Players kept complaining they have a technology researched so they cannot research it again, but recipe remained locked. Because of that when technologies are changed, all effects are reapplied.