[Klonan] [1.1.6] Issues with empty furnace input slot tooltip

This subforum contains all the issues which we already resolved.
Post Reply
User avatar
Deadlock989
Smart Inserter
Smart Inserter
Posts: 2374
Joined: Fri Nov 06, 2015 7:41 pm

[Klonan] [1.1.6] Issues with empty furnace input slot tooltip

Post by Deadlock989 »

This was partly picked up in the 1.1.1 release thread but I don't think it ever got formally reported.

1.1.1 added a tooltip to empty furnace input slots. If (in a modded situation) the list of furnace recipes is large enough, the tooltip just shows a massive vertical list that's cut off by available screen space.

In addition, if the "furnace" has fluid boxes and multiple input slots (one for the single allowed solid ingredient, one or more for the fluid box inputs) then the list is completely unpopulated. The item ingredient slot shows the empty tooltip shown below despite multiple valid recipes being unlocked; the fluid slots just say "Ingredient". Furnace recipes are only permitted one item ingredient but there is no restriction on fluid ingredients: the "furnace" (or whatever it is the entity represents) switches correctly between recipes as long as it never gets "blocked" by having the wrong fluid in it. (Please don't change this. It works very well.)

To be honest - I think you could lose this feature completely and few folks would be particularly exercised by it. That's why we have the "Made in:" part of recipe tooltips. Ammo slots need the attention more than furnace slots ever did.

Untitled.jpg
Untitled.jpg (22.75 KiB) Viewed 1494 times
"If Stalin had a good writeup on programming, would linking that be dangerous?"

User avatar
Klonan
Factorio Staff
Factorio Staff
Posts: 4893
Joined: Sun Jan 11, 2015 2:09 pm
Contact:

Re: [Klonan] [1.1.6] Issues with empty furnace input slot tooltip

Post by Klonan »

Ok, I am working on this, what do you think of this solution:
factorio-run_2021-01-11_17-34-20.png
factorio-run_2021-01-11_17-34-20.png (53.22 KiB) Viewed 1368 times
factorio-run_2021-01-11_17-35-00.png
factorio-run_2021-01-11_17-35-00.png (52.77 KiB) Viewed 1366 times

User avatar
Deadlock989
Smart Inserter
Smart Inserter
Posts: 2374
Joined: Fri Nov 06, 2015 7:41 pm

Re: [Klonan] [1.1.6] Issues with empty furnace input slot tooltip

Post by Deadlock989 »

I think that looks really good.
"If Stalin had a good writeup on programming, would linking that be dangerous?"

User avatar
Klonan
Factorio Staff
Factorio Staff
Posts: 4893
Joined: Sun Jan 11, 2015 2:09 pm
Contact:

Re: [Klonan] [1.1.6] Issues with empty furnace input slot tooltip

Post by Klonan »

Making some attempt at making the large categories work, some sucess:
factorio-run_2021-01-12_10-30-10.png
factorio-run_2021-01-12_10-30-10.png (443.54 KiB) Viewed 1272 times
The scrapping however is obviously too much, not sure how to solve it, probably not worth any deeper effort:
devenv_2021-01-12_10-30-21.png
devenv_2021-01-12_10-30-21.png (884.24 KiB) Viewed 1272 times

User avatar
Klonan
Factorio Staff
Factorio Staff
Posts: 4893
Joined: Sun Jan 11, 2015 2:09 pm
Contact:

Re: [Klonan] [1.1.6] Issues with empty furnace input slot tooltip

Post by Klonan »

I guess we will just tell people to buy a 4k monitor
devenv_2021-01-12_10-46-21.png
devenv_2021-01-12_10-46-21.png (1.86 MiB) Viewed 1269 times

User avatar
Deadlock989
Smart Inserter
Smart Inserter
Posts: 2374
Joined: Fri Nov 06, 2015 7:41 pm

Re: [Klonan] [1.1.6] Issues with empty furnace input slot tooltip

Post by Deadlock989 »

Klonan wrote:
Tue Jan 12, 2021 9:43 am
Making some attempt at making the large categories work, some sucess:

The scrapping however is obviously too much, not sure how to solve it, probably not worth any deeper effort:
I mean, on the one hand, I don't think this feature needs to exist in the first place, though you've made it a lot better by the looks of it.

Some random ideas off the top of my head:

1. Don't show a tooltip at all if the number of items in the list is above X. I don't really know what X would be, maybe some gueestimate about whether or not the tooltip blots out more than half the screen or something, maybe actually base it on the number of item prototypes in the game - e.g. when you hit the point where it would be economical to show what can't be put in this slot

2. Don't show these tooltips for crafting categories that have an opt-out flag in their RecipeCategory prototype. Or you could even make it opt-in, and set it to true for the vanilla "smelting" category which (IIRC) is the only category used in furnace-type entities in vanilla.

3. Call it good enough / done and do the same thing with ammo tooltips
"If Stalin had a good writeup on programming, would linking that be dangerous?"

Kyralessa
Filter Inserter
Filter Inserter
Posts: 340
Joined: Thu Sep 29, 2016 5:58 pm
Contact:

Re: [Klonan] [1.1.6] Issues with empty furnace input slot tooltip

Post by Kyralessa »

Klonan wrote:
Tue Jan 12, 2021 9:46 am
I guess we will just tell people to buy a 4k monitor
Maybe it would be shorter to show them a list of things that can't go in there? :D

User avatar
Klonan
Factorio Staff
Factorio Staff
Posts: 4893
Joined: Sun Jan 11, 2015 2:09 pm
Contact:

Re: [Klonan] [1.1.6] Issues with empty furnace input slot tooltip

Post by Klonan »

Deadlock989 wrote:
Tue Jan 12, 2021 12:27 pm
3. Call it good enough / done and do the same thing with ammo tooltips
Yea I am already working on the ammo
factorio-run_2021-01-12_13-06-43.png
factorio-run_2021-01-12_13-06-43.png (33.24 KiB) Viewed 1217 times
Next question, how far do we feature creep? Should gun slots have it? Armor slots? Module slots?

User avatar
Deadlock989
Smart Inserter
Smart Inserter
Posts: 2374
Joined: Fri Nov 06, 2015 7:41 pm

Re: [Klonan] [1.1.6] Issues with empty furnace input slot tooltip

Post by Deadlock989 »

Klonan wrote:
Tue Jan 12, 2021 12:35 pm
Yea I am already working on the ammo

Next question, how far do we feature creep? Should gun slots have it? Armor slots? Module slots?
Those vanilla items ("Shotgun shells", "Piercing shotgun shells") have both the {"hidden","hide-from-bonus-gui"} flags set on them to stop them from appearing anywhere else, because there is no unlockable recipe for them in that mod - I guess these tooltips should be looking at one of those too?

Gun slots - maybe? Eh.

Armour slots - don't reckon so.

Module slots - would get messy due to recipe limitations on specific modules.

Ammo slots is the one I've seen people asking for for years and I reckon it would really help in mods that have unfamiliar weapons and turrets, loads of different ammo categories etc. Armour - can it even have categories? Isn't there only one armour slot in the game, period?
"If Stalin had a good writeup on programming, would linking that be dangerous?"

User avatar
Klonan
Factorio Staff
Factorio Staff
Posts: 4893
Joined: Sun Jan 11, 2015 2:09 pm
Contact:

Re: [Klonan] [1.1.6] Issues with empty furnace input slot tooltip

Post by Klonan »

Deadlock989 wrote:
Tue Jan 12, 2021 12:39 pm
Those vanilla items ("Shotgun shells", "Piercing shotgun shells") have both the {"hidden","hide-from-bonus-gui"} flags set on them to stop them from appearing anywhere else, because there is no unlockable recipe for them in that mod - I guess these tooltips should be looking at one of those too?
Alright, they will check the "hidden" flag:
factorio-run_2021-01-12_14-06-23.png
factorio-run_2021-01-12_14-06-23.png (28.5 KiB) Viewed 1180 times
If in the future it needs some more precise differentiation, we can add a specific flag like the fuel tooltip flag

User avatar
Deadlock989
Smart Inserter
Smart Inserter
Posts: 2374
Joined: Fri Nov 06, 2015 7:41 pm

Re: [Klonan] [1.1.6] Issues with empty furnace input slot tooltip

Post by Deadlock989 »

Klonan wrote:
Tue Jan 12, 2021 1:07 pm
If in the future it needs some more precise differentiation, we can add a specific flag like the fuel tooltip flag
I never even noticed that fuel one, good to know. Might be a nice thing to have for the massive scrapping recipe issue as well. If there was something like "hide-from-furnace-tooltip" then we could just set it on every item that isn't something genuinely furnace-y if we want to prevent tooltips from blotting out the sun accidentally.
"If Stalin had a good writeup on programming, would linking that be dangerous?"

Amarula
Filter Inserter
Filter Inserter
Posts: 383
Joined: Fri Apr 27, 2018 1:29 pm
Contact:

Re: [Klonan] [1.1.6] Issues with empty furnace input slot tooltip

Post by Amarula »

This attention to detail, responsiveness, and player engagement, set you in a class of your own - no-one else comes close. You are amazing! Thank you!

@Deadlock989: how about blotting out the sun deliberately? Like fog of war only better...

@Klonan: oh yeah a reason to say I _need_ a 4k monitor!
Luck is not a robust control.

User avatar
ptx0
Smart Inserter
Smart Inserter
Posts: 1052
Joined: Wed Jan 01, 2020 7:16 pm
Contact:

Re: [Klonan] [1.1.6] Issues with empty furnace input slot tooltip

Post by ptx0 »

Deadlock989 wrote:
Mon Dec 28, 2020 6:00 pm
To be honest - I think you could lose this feature completely and few folks would be particularly exercised by it. That's why we have the "Made in:" part of recipe tooltips.
hard disagree.
Ammo slots need the attention more
feature request, not a bug - but i agree.
My Mods - Fish Per Minute base size metric - Use your crashed spaceship as a belt balancer?
• • •
Base: Bob's @ 1 Million SPM
• • •
Linear search and overflows are indicative of sloppy coding practices.

User avatar
ptx0
Smart Inserter
Smart Inserter
Posts: 1052
Joined: Wed Jan 01, 2020 7:16 pm
Contact:

Re: [Klonan] [1.1.6] Issues with empty furnace input slot tooltip

Post by ptx0 »

Klonan wrote:
Tue Jan 12, 2021 9:46 am
I guess we will just tell people to buy a 4k monitor
devenv_2021-01-12_10-46-21.png
you could make the ingredient slot a clickable entity that brings up a UI similar to the Logistics overview with a scrollbar for vertical overflow.
My Mods - Fish Per Minute base size metric - Use your crashed spaceship as a belt balancer?
• • •
Base: Bob's @ 1 Million SPM
• • •
Linear search and overflows are indicative of sloppy coding practices.

User avatar
Klonan
Factorio Staff
Factorio Staff
Posts: 4893
Joined: Sun Jan 11, 2015 2:09 pm
Contact:

Re: [Klonan] [1.1.6] Issues with empty furnace input slot tooltip

Post by Klonan »

I did gun and modules, because why not if i'm already here doing it
factorio-run_2021-01-13_11-53-22.png
factorio-run_2021-01-13_11-53-22.png (37.17 KiB) Viewed 841 times
factorio-run_2021-01-13_11-54-03.png
factorio-run_2021-01-13_11-54-03.png (40.1 KiB) Viewed 841 times

User avatar
Klonan
Factorio Staff
Factorio Staff
Posts: 4893
Joined: Sun Jan 11, 2015 2:09 pm
Contact:

Re: [Klonan] [1.1.6] Issues with empty furnace input slot tooltip

Post by Klonan »

So all of this is now in the next release

Post Reply

Return to “Resolved Problems and Bugs”