Ah yeah that's my fault for forgetting I had an update I haven't let happen

I was looking at how the foundry did the sound waypoints I remember hearing in a FFF. Just to see if I could somehow piggyback off that system to do smoke (doesn't look possible).

I noticed that the base game defines an `audible_distance_modifier` on the SoundAccent s it provides, which is missing ...

curiosity wrote: Fri Jan 17, 2025 12:51 am This belongs in bug reports.

Maybe it does, but I put it here since the overall behavior is fine, it's just *how* it errors can be confusing.

There's a number of prototypes that expect only an ElectricEnergySource, which is fine. My problem is that the error messages will complain about missing usage_priority before it'll mention that the type is incorrect.

The golden solution would be to complain that the incorrect type of EnergySource ...

Got added in 2.0.29 :D

Scripting

• Changed LuaEntity::get_logistic_point() and LuaEntity::get_logistic_sections() to work with ghosts.

I realized a bug in my mod, so I was writing some code to expand a few key ingredients when I opened the game, and then the nearby ghost to check if it worked

It of course, then decided it didn't like that change and crashed :P

Further testing has proven that it's when the number of ingredients ...

When you make an entity-ghost and set its recipe all in create_entity, it then will crash when you open the ghost.
If you set it on the entity rather than in the create_entity function, it works fine. So it might just not be setting the quality level of the recipe properly.

This issue does survive ...

MapGenPreset.default lists its default as `true`, when this seems clearly incorrect.
The engine itself doesn't set them, despite documentation saying it can't set any other fields if it's true: __base__/prototypes/map-gen-presets.lua

GameViewSettings.default_show_value very specifically says it is the default for all other values. Yet all other values say `true` is their default. They should probably be changed to "Value of `default_show_value`" just like SpriteSheet.line_length with the default setting having an actual default ...

can_recycle is the paramater to the generate_recycling_recipe function, it should be true, false, or nil (the last two are the same as ommitting it).

Neither auto_recycle nor can_recycle should be a function


Passing true to can_recycle will cause it to crash.
It is supposed to be an ...

I knew about the chunk generation request
I thought about it while writing that

I still forgot to mention it..


Also IO problems are a myth (aka I've been lucky enough to not have much issue with them. Most I've had is my backup drive filesystem got a tad corrupt which was easily fixable with fsck)

If the Engine actually crashes, it's always the Engine's fault. Even if the solution is to then tell the mod to not do that by throwing a lua error.

If Factorio is telling you something went wrong, it's a Lua error. If it's a popup saying the game crashed, it's a C++ error.

There is undescribed behavior with removing an action.

What I've found is that removing a 'removed-entity' action will also remove the paired 'built-entity' action.
I don't know if this needs to be within the built event, or even the same tick. I also haven't checked if the inverse will work either ...

Bah :(

I can kind of understand it.. with a get physical inventory, I think I'd be more okay

There is an angle where this is a bug rather than a documentation issue. I think I sit in that angle

First of all, it wouldn't crash even if Quality didn't remove the field. Extra fields are ignored and don't cause an exception.

Second, see also: 120859

Can confirm that it crashes on 2.0.24 linux as well, and yeah it seems to be every time with that specific version of PM.

And while we're talking about it. It doesn't mention that there's a prototype for CustomEvent that adds another avenue making a valid event to throw.

I personally think it's fairly obvious that it would raise it instantly, but it doesn't hurt to be explicit about it.

So my little snippet of code doing this works fine

local flag = false

function some_func()
flag = true
script.raise_event("my-event", {})
flag = false
end

function other_func ...

That would force the get_prototype function to be in util and that's honestly the one I feel needs to be in there more

But yeah I do think they are simple and useful enough functions to deserve to be canon utilities