[Dominik][0.17.63] Shared fluid system with separate pipes

This subforum contains all the issues which we already resolved.
Post Reply
User avatar
boskid
Factorio Staff
Factorio Staff
Posts: 706
Joined: Thu Dec 14, 2017 6:56 pm
Contact:

[Dominik][0.17.63] Shared fluid system with separate pipes

Post by boskid »

I am not sure how this happend, but i have save file with custom "control.lua" that performs bunch of randomized actions with fluid systems. At some point (tick 74430) two disjoint fluid networks managed to connect (both locked by sulfuric-acid and share same system ID) when they should not be (there is cutter underground pipe present).

Steps to reproduce:
  1. Open fluid_fuzzer_zip.zip
    fluid_fuzzer_zip.zip
    (133.49 KiB) Downloaded 16 times
  2. Increase speed in editor to x64
  3. Wait 18 seconds
  4. At tick 74430 my custom script should print error message and stop itself
    74252-disjoint-network-with-shared-filter.png
    74252-disjoint-network-with-shared-filter.png (116.45 KiB) Viewed 819 times
  5. Fluid network on right is now connected to sulfuric acid even in presence of cutter underground pipe that should prevent it from connecting to filter
After this issue happend, is it possible to remove many pipes, change assembler to petrol unbarrel and all isolated pipes will also change its fluid filter (proves they share same fluid system):
74252-state-is-persistent-and-filter-is-truly-shared.png
74252-state-is-persistent-and-filter-is-truly-shared.png (102.43 KiB) Viewed 819 times
-- edit:
- Is it possible to extend consistency check onto this case? To check if all fluidboxes in one fluid system are in fact somehow connected?
- Is there a switch (something like toggle-heavy-mode) that would run consistency check every tick? "toggle-consistency-mode" ?

User avatar
boskid
Factorio Staff
Factorio Staff
Posts: 706
Joined: Thu Dec 14, 2017 6:56 pm
Contact:

Re: [0.17.63] Shared fluid system with separate pipes

Post by boskid »

[0.17.64] Manual reproduction
74252-manual-network-split.gif
74252-manual-network-split.gif (933.57 KiB) Viewed 690 times
Issue looks to be with placing pipe-to-ground ghost that should split fluid system (solution 1) or that should be part of fluid system so its removal should perform full split network logic and create new fluid system.

Compact reproduction:
74252-manual-network-split-simple.gif
74252-manual-network-split-simple.gif (200.48 KiB) Viewed 690 times

Dominik
Former Staff
Former Staff
Posts: 658
Joined: Sat Oct 12, 2013 9:08 am
Contact:

Re: [Dominik][0.17.63] Shared fluid system with separate pipes

Post by Dominik »

This one is a good catch, a very realistic and also serious issue. Thanks.
It is quite certainly connected to the 74269. I will check it out now.

Post Reply

Return to “Resolved Problems and Bugs”

Who is online

Users browsing this forum: Anon2k, Bing [Bot]