[Rseding91] original_damage_amount and final_damage_amount output the same value

This subforum contains all the issues which we already resolved.
Post Reply
User avatar
ownlyme
Filter Inserter
Filter Inserter
Posts: 400
Joined: Thu Dec 21, 2017 8:02 am
Contact:

[Rseding91] original_damage_amount and final_damage_amount output the same value

Post by ownlyme »

I thought original_damage_amount was supposed to output the amount of damage before armor mitigation?
It would also be nice if some value was provided where we can read the absorbed damage by shields.
Ty
mods.factorio.com/user/ownlyme
My requests: uiAbove||Grenade arc||Blueprint allies||Creeps forget command/ don't get removed||Player Modifiers||textbox::selection||Better Heat IF||Singleplayer RCON||tank bug w/ min_range >= projectile_creation_distance

Ultros
Fast Inserter
Fast Inserter
Posts: 129
Joined: Thu Apr 04, 2019 4:25 pm
Contact:

Re: original_damage_amount and final_damage_amount output the same value

Post by Ultros »

Why would this be a bug? If your armor doesn't defend against that damage type (eg impact on power armor, laser on biters), one would obviously expect the two values to be identical.

Rseding91
Factorio Staff
Factorio Staff
Posts: 12214
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: original_damage_amount and final_damage_amount output the same value

Post by Rseding91 »

Thanks for the report. It's now fixed for the next version of 0.17.
If you want to get ahold of me I'm almost always on Discord.

User avatar
ownlyme
Filter Inserter
Filter Inserter
Posts: 400
Joined: Thu Dec 21, 2017 8:02 am
Contact:

Re: [Rseding91] original_damage_amount and final_damage_amount output the same value

Post by ownlyme »

O... M.. G!
THANK YOU!!!!
I think we can now even calculate how much hp an entity had before the killing blow (at least if it has no shields) :)
Awesome!
Last edited by ownlyme on Wed Jul 03, 2019 1:18 pm, edited 2 times in total.
mods.factorio.com/user/ownlyme
My requests: uiAbove||Grenade arc||Blueprint allies||Creeps forget command/ don't get removed||Player Modifiers||textbox::selection||Better Heat IF||Singleplayer RCON||tank bug w/ min_range >= projectile_creation_distance

User avatar
ownlyme
Filter Inserter
Filter Inserter
Posts: 400
Joined: Thu Dec 21, 2017 8:02 am
Contact:

Re: [Rseding91] original_damage_amount and final_damage_amount output the same value

Post by ownlyme »

hmm nope final_damage_amount doesn't get limited by the entity's hp..
mods.factorio.com/user/ownlyme
My requests: uiAbove||Grenade arc||Blueprint allies||Creeps forget command/ don't get removed||Player Modifiers||textbox::selection||Better Heat IF||Singleplayer RCON||tank bug w/ min_range >= projectile_creation_distance

User avatar
ownlyme
Filter Inserter
Filter Inserter
Posts: 400
Joined: Thu Dec 21, 2017 8:02 am
Contact:

Re: original_damage_amount and final_damage_amount output the same value

Post by ownlyme »

Rseding91 wrote:
Sat May 25, 2019 1:03 am
Thanks for the report. It's now fixed for the next version of 0.17.
interestingly, when calling LuaEntity.damage(), that function returns the correct damage amount, when the entity's hp get reduced to 0.
(But final_damage_amount doesn't)

Can you fix that too? would give the event another edge in usefulness
mods.factorio.com/user/ownlyme
My requests: uiAbove||Grenade arc||Blueprint allies||Creeps forget command/ don't get removed||Player Modifiers||textbox::selection||Better Heat IF||Singleplayer RCON||tank bug w/ min_range >= projectile_creation_distance

Post Reply

Return to “Resolved Problems and Bugs”