Auto-barrel doesn't take into account icons with size > 32

This subforum contains all the issues which we already resolved.
Post Reply
User avatar
bobingabout
Smart Inserter
Smart Inserter
Posts: 6832
Joined: Fri May 09, 2014 1:01 pm
Contact:

Auto-barrel doesn't take into account icons with size > 32

Post by bobingabout » Wed May 22, 2019 10:08 pm

Firstly, the auto-barrel (data-updates.lua creates a filled barrel item, fill and empty recipes, and assigns icons to them all) icon generation for the fill and empty recipes doesn't take into account icons with a size other than 32.
https://www.dropbox.com/s/qss8qzvvwef7h ... 4.png?dl=0
in this example screenshot, pure water is icon_size 64.

Also, if a fluid doesn't have an icon= tag (EG, it has an icons= tag), the function refuses to run on it at all.
Creator of Bob's mods. Expanding your gameplay since version 0.9.8.
I also have a Patreon.

posila
Factorio Staff
Factorio Staff
Posts: 3922
Joined: Thu Jun 11, 2015 1:35 pm
Contact:

Re: Auto-barrel doesn't take into account icons with size > 32

Post by posila » Thu May 23, 2019 11:56 am

Thanks for fixing it for 0.17.43

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 3633
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: Auto-barrel doesn't take into account icons with size > 32

Post by eradicator » Thu May 23, 2019 12:55 pm

Btw, barreling also doesn't account for fluids with localised_name like it could:

Code: Select all

localised_name = {"recipe-name.fill-barrel", fluid.localised_name or  {"fluid-name." .. fluid.name}},
Author of: Hand Crank Generator, Screenshot Hotkey 2.0
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

User avatar
bobingabout
Smart Inserter
Smart Inserter
Posts: 6832
Joined: Fri May 09, 2014 1:01 pm
Contact:

Re: Auto-barrel doesn't take into account icons with size > 32

Post by bobingabout » Thu May 23, 2019 8:41 pm

eradicator wrote:
Thu May 23, 2019 12:55 pm
Btw, barreling also doesn't account for fluids with localised_name like it could:

Code: Select all

localised_name = {"recipe-name.fill-barrel", fluid.localised_name or  {"fluid-name." .. fluid.name}},
because if no localised_name is specified, that will return nil and use the or condition to use the default.
simple fix.

is it localised or localized? there's a lot of American in the code.
Creator of Bob's mods. Expanding your gameplay since version 0.9.8.
I also have a Patreon.

User avatar
bobingabout
Smart Inserter
Smart Inserter
Posts: 6832
Joined: Fri May 09, 2014 1:01 pm
Contact:

Re: Auto-barrel doesn't take into account icons with size > 32

Post by bobingabout » Thu May 23, 2019 9:45 pm

eradicator wrote:
Thu May 23, 2019 12:55 pm
Btw, barreling also doesn't account for fluids with localised_name like it could:

Code: Select all

localised_name = {"recipe-name.fill-barrel", fluid.localised_name or  {"fluid-name." .. fluid.name}},
you should probably make a new bug report, as this one is in the resolved bin, and further conversation will likely be ignored.
Creator of Bob's mods. Expanding your gameplay since version 0.9.8.
I also have a Patreon.

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 3633
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: Auto-barrel doesn't take into account icons with size > 32

Post by eradicator » Fri May 24, 2019 11:28 am

Author of: Hand Crank Generator, Screenshot Hotkey 2.0
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

Post Reply

Return to “Resolved Problems and Bugs”

Who is online

Users browsing this forum: No registered users