[0.17.14] " function on_player_rotated_entity(event)" only works when fluid connection is present

This subforum contains all the issues which we already resolved.
FacelessDE
Manual Inserter
Manual Inserter
Posts: 4
Joined: Fri Mar 15, 2019 11:08 pm
Contact:

[0.17.14] " function on_player_rotated_entity(event)" only works when fluid connection is present

Post by FacelessDE »

Dear support staff,
Assembly machines can only be rotated once the fluid connection is present. My mod uses heat pipe connections (picture attached), that were rotateable in 0.16. Now in 0.17 it rotates fine while on the cursor, but cannot be changed anymore once placed.
Is this intended or is there a way to rotate an assembler without a fluid pipe?
Regards
Faceless

Image

Code: Select all

Test script:

function on_player_rotated_entity(event)

local entity = event.entity
if not entity.valid then return end

	if entity.name == "assembling-machine-1" then
		--game.print(entity.direction)
		local direction = entity.direction + 2
		if direction > 6 then
		    direction = 0
		end
		entity.direction = direction
		--game.print(direction)
	end
end
	
script.on_event(defines.events.on_player_rotated_entity, on_player_rotated_entity)
Bilka
Factorio Staff
Factorio Staff
Posts: 3310
Joined: Sat Aug 13, 2016 9:20 am
Contact:

Re: [0.17.14] " function on_player_rotated_entity(event)" only works when fluid connection is present

Post by Bilka »

Thank you for the report, fixed for the next version.
I'm an admin over at https://wiki.factorio.com. Feel free to contact me if there's anything wrong (or right) with it.
FacelessDE
Manual Inserter
Manual Inserter
Posts: 4
Joined: Fri Mar 15, 2019 11:08 pm
Contact:

Re: [0.17.73] " function on_player_rotated_entity(event)" only works when fluid connection is present

Post by FacelessDE »

Dear support staff,

in Factorio versison 0.17.73 have we my old problem again. I cant rotateabled my assambling machine after build.

Regards

Faceless
Bilka
Factorio Staff
Factorio Staff
Posts: 3310
Joined: Sat Aug 13, 2016 9:20 am
Contact:

Re: [0.17.14] " function on_player_rotated_entity(event)" only works when fluid connection is present

Post by Bilka »

@Whoever solves this: The assembler direction changes, but the heat pipe connection stays in the same place. Test RotateAssemblerWithHeatEnergySource in ManualBuilding suite does not currently check for that.
I'm an admin over at https://wiki.factorio.com. Feel free to contact me if there's anything wrong (or right) with it.
User avatar
boskid
Factorio Staff
Factorio Staff
Posts: 3031
Joined: Thu Dec 14, 2017 6:56 pm
Contact:

Re: [0.17.14] " function on_player_rotated_entity(event)" only works when fluid connection is present

Post by boskid »

Heat connector is properly rotated, but adjacent heat pipes are not updated
User avatar
boskid
Factorio Staff
Factorio Staff
Posts: 3031
Joined: Thu Dec 14, 2017 6:56 pm
Contact:

Re: [0.17.14] " function on_player_rotated_entity(event)" only works when fluid connection is present

Post by boskid »

Thanks. It is now fixed for [0.17.74]

Issue was introduced in [0.17.70] by some mistake. Immediate workaround is to rebuild heat pipes adjacent to previous and new position of heat connection.

-- edit:
btw, this second issue was different and is not related to topic's subject. Next time please make new bug report to not violate 3638. I do not want to split this because i already commited changelog entry with link to this topic.
Post Reply

Return to “Resolved Problems and Bugs”