[Rseding91] [0.16.39] Crash on placing rolling_stock w. large joint_dist

This subforum contains all the issues which we already resolved.
Post Reply
rude_grass
Inserter
Inserter
Posts: 20
Joined: Tue May 01, 2018 3:29 pm
Contact:

[Rseding91] [0.16.39] Crash on placing rolling_stock w. large joint_dist

Post by rude_grass » Tue May 01, 2018 3:47 pm

When i place a modded cargo_wagon with a joint_distance > ~9.5 on a diagonal track the game crashes with the error "85.483 Error RollingStock.cpp:974: Couldn't find the back joint rail".
This does not happen when placing the same wagon on straight (south-north, west-east) tracks.

I'm using a Linux the system and the modded cargo_wagon corresponds to the "cargo_ship" of the Cargo Ships mods (https://mods.factorio.com/mod/cargo-ships)
Attachments
factorio-current.log
(8.29 KiB) Downloaded 36 times

kovarex
Factorio Staff
Factorio Staff
Posts: 7424
Joined: Wed Feb 06, 2013 12:00 am
Contact:

Re: [16.39] Crash on placing rolling_stock w. large joint_dist

Post by kovarex » Tue May 01, 2018 8:20 pm

I checked the code, and yes, the limit for the search is 5 rails, if it isn't found in 5 rails radius, it is expected to be an internal bug. We kind of didn't expect this kind of setup.
The question is, what to do with that?

We might just increase the radius a bit, which would help in this case, but it would be just a matter of time until someone made it even larger.

I would say that we could increase the radius and also limit the joint distance to prevent crashes with too crazy values.

rude_grass
Inserter
Inserter
Posts: 20
Joined: Tue May 01, 2018 3:29 pm
Contact:

Re: [0.16.39] Crash on placing rolling_stock w. large joint_dist

Post by rude_grass » Wed May 02, 2018 4:52 pm

Thanks so much for taking the time to solve unexpected mod related issues like this one!

Rseding91
Factorio Staff
Factorio Staff
Posts: 9983
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [16.39] Crash on placing rolling_stock w. large joint_dist

Post by Rseding91 » Wed May 02, 2018 6:09 pm

kovarex wrote:I would say that we could increase the radius and also limit the joint distance to prevent crashes with too crazy values.
I agree. We can limit it to some upper value then make the search dynamic based off the largest joint distance defined in a rolling stock prototype.
If you want to get ahold of me I'm almost always on Discord.

Post Reply

Return to “Resolved Problems and Bugs”

Who is online

Users browsing this forum: No registered users