Friday Facts #287 - Just bugs again

Regular reports on Factorio development.

User avatar
darkfrei
Smart Inserter
Smart Inserter
Posts: 2028
Joined: Thu Nov 20, 2014 11:11 pm
Contact:

Re: Friday Facts #287 - Just bugs again

Post by darkfrei » Fri Mar 22, 2019 4:00 pm

Changes: old bugs fixed, new bugs added.

User avatar
steinio
Smart Inserter
Smart Inserter
Posts: 2196
Joined: Sat Mar 12, 2016 4:19 pm
Contact:

Re: Friday Facts #287 - Just bugs again

Post by steinio » Fri Mar 22, 2019 4:05 pm

Oh Sanqui that was your chance to bring XKCD on again: https://xkcd.com/327/
Image
Transport Belt Repair Man
My little mods: Link | My favourite mods: Bob's Mods | Angel's Mods | Yuoki Railway Core | EvoGUI | Logistic Train Network
Factorio Cheat Sheet by Denis Zholob

View unread Posts

User avatar
mexmer
Filter Inserter
Filter Inserter
Posts: 830
Joined: Wed Aug 03, 2016 2:00 pm
Contact:

Re: Friday Facts #287 - Just bugs again

Post by mexmer » Fri Mar 22, 2019 4:06 pm

well, since factorio login didn't accept my steam name in kanji, spaces in name are less issue imo :D

User avatar
Raiguard
Long Handed Inserter
Long Handed Inserter
Posts: 52
Joined: Wed Dec 13, 2017 8:29 pm
Contact:

Re: Friday Facts #287 - Just bugs again

Post by Raiguard » Fri Mar 22, 2019 4:09 pm

99 little bugs in the code.
99 little bugs in the code.
Take one down, patch it around,
117 little bugs in the code.
Don't forget, you're here forever.

User avatar
burisk
Burner Inserter
Burner Inserter
Posts: 16
Joined: Sun Mar 12, 2017 1:58 pm
Contact:

Re: Friday Facts #287 - Just bugs again

Post by burisk » Fri Mar 22, 2019 4:11 pm

That's awesome that bug fix! I notices it many times. But that usernames.. really? No server-side validation? :/ I hope that you store our passwords in slow hashes like 'bcrypt' (or another alternatives) and not in MD5 or at worst in plaintext.

glee8e
Burner Inserter
Burner Inserter
Posts: 18
Joined: Sat Dec 30, 2017 7:26 am
Contact:

Re: Friday Facts #287 - Just bugs again

Post by glee8e » Fri Mar 22, 2019 4:13 pm

For some reason every pic/webm went 404. Is it my local ISP blocking stuff? Anyone else with same problem?

EDIT: it's gone. Refresh do the trick. Perhaps I came too earliy that cdn didn't fetch stuff properly yet.
Last edited by glee8e on Fri Mar 22, 2019 4:18 pm, edited 1 time in total.

Jap2.0
Smart Inserter
Smart Inserter
Posts: 1993
Joined: Tue Jun 20, 2017 12:02 am
Contact:

Re: Friday Facts #287 - Just bugs again

Post by Jap2.0 » Fri Mar 22, 2019 4:13 pm

I think just hearing some of those usernames must have made that mistake more than worth it.

Was ' or 1=1; -- the cause of your matching server problems yesterday? ;)

Anyway, good work continuing to fix bugs and tell me my 1-in-a-million flukes aren't going to get fixed. It's also nice to hear of (hopefully) an end to the obscure splitter bugs.
There are 10 types of people: those who get this joke and those who don't.

User avatar
Sanqui
Factorio Staff
Factorio Staff
Posts: 100
Joined: Mon May 07, 2018 7:22 pm
Contact:

Re: Friday Facts #287 - Just bugs again

Post by Sanqui » Fri Mar 22, 2019 4:18 pm

burisk wrote:
Fri Mar 22, 2019 4:11 pm
That's awesome that bug fix! I notices it many times. But that usernames.. really? No server-side validation? :/ I hope that you store our passwords in slow hashes like 'bcrypt' (or another alternatives) and not in MD5 or at worst in plaintext.
Server-side validation is the thing that got accidentally broken (bypassed).

Passwords are hashed with bcrypt.
ovo

User avatar
SuperSandro2000
Filter Inserter
Filter Inserter
Posts: 675
Joined: Sun Jan 12, 2014 3:54 am
Contact:

Re: Friday Facts #287 - Just bugs again

Post by SuperSandro2000 » Fri Mar 22, 2019 4:22 pm

Press F for NOT THE BEES!!!!!, your mum lives in a tent, and ' or 1=1; --

User avatar
ledow
Long Handed Inserter
Long Handed Inserter
Posts: 86
Joined: Sat Sep 24, 2016 3:00 pm
Contact:

Re: Friday Facts #287 - Just bugs again

Post by ledow » Fri Mar 22, 2019 4:24 pm

Would have been simpler, and a better idea, to just let the ban commands have proper quoting applied, so you can ban "awkward user name".

The restrictions on usernames just suggest laziness around the "we don't want to have to care about sanitising our string-handling, we'll just limit what the user can put in a username", with knock-on effects like unbannable users because of a string-handling mistake in an entirely different service months before.

Seriously, guys, there are TONS of sensible string-handling libraries that could have managed this for you, and then people could have spaces in their names... like... ooh... I don't know... 99% of the English-speaking populations out there?

It's all very Windows 3.1. What next, we can't have more than 8 characters?

someone1337
Long Handed Inserter
Long Handed Inserter
Posts: 81
Joined: Wed Apr 26, 2017 11:29 pm
Contact:

Re: Friday Facts #287 - Just bugs again

Post by someone1337 » Fri Mar 22, 2019 4:37 pm

Code: Select all

' or 1=1; -- '
Is a legitimate username!!11!1!11oneeleven

https://xkcd.com/327/

User avatar
Sanqui
Factorio Staff
Factorio Staff
Posts: 100
Joined: Mon May 07, 2018 7:22 pm
Contact:

Re: Friday Facts #287 - Just bugs again

Post by Sanqui » Fri Mar 22, 2019 4:48 pm

ledow wrote:
Fri Mar 22, 2019 4:24 pm
Would have been simpler, and a better idea, to just let the ban commands have proper quoting applied, so you can ban "awkward user name".

The restrictions on usernames just suggest laziness around the "we don't want to have to care about sanitising our string-handling, we'll just limit what the user can put in a username", with knock-on effects like unbannable users because of a string-handling mistake in an entirely different service months before.

Seriously, guys, there are TONS of sensible string-handling libraries that could have managed this for you, and then people could have spaces in their names... like... ooh... I don't know... 99% of the English-speaking populations out there?

It's all very Windows 3.1. What next, we can't have more than 8 characters?
There's some quite good reasons to disallow spaces in usernames on principle. The question is if we should have usernames at all. In my opinion the best setup is permanent id + email (for login) + display name, where the display name can be anything. But that is quite difficult to change at this point, even though it's on my roadmap.
ovo

User avatar
BlueTemplar
Smart Inserter
Smart Inserter
Posts: 1079
Joined: Fri Jun 08, 2018 2:16 pm
Contact:

Re: Friday Facts #287 - Just bugs again

Post by BlueTemplar » Fri Mar 22, 2019 6:17 pm

michael wrote:Our UX guy is asking us to allow spaces in usernames. The caveat is that they should be allowed anywhere.
user568458 wrote:suppose I enter my username as Experts Exchange, the system will silently translate it into expertsexchange, and the system will direct queries for a user with username Expert Sex Change to my account?
:lol:

P.S.: Doesn't "email (for login)" have its own set of problems ?
(Albeit, a much smaller set... mostly an issue when email change is not allowed ad/or that email gets undesirable/unavailable...)

dee-
Filter Inserter
Filter Inserter
Posts: 386
Joined: Mon Jan 19, 2015 9:21 am
Contact:

Re: Friday Facts #287 - Just bugs again

Post by dee- » Fri Mar 22, 2019 6:34 pm

Just hash the username on the way in and store that in the DB.

User avatar
Dixi
Long Handed Inserter
Long Handed Inserter
Posts: 83
Joined: Sat Nov 04, 2017 1:47 pm
Contact:

Re: Friday Facts #287 - Just bugs again

Post by Dixi » Fri Mar 22, 2019 7:43 pm

I don't see a difference between 1st and 2nd animated gif with splitters.
I see fully filled belt of fuel, where you inserting plates, two in a row. They fit like ...fffffPfPfff... Splitter takes one from each side and move to output. What else could we expect? Actually I never thought how splitters merge two belts, now I see - they do it one by one. Other possible way was, that they works like inserters, and grab several items at once.
Do you mean that on 1st picture output belt becomes not fully compressed, and there was a gap at some point?

coderpatsy
Inserter
Inserter
Posts: 41
Joined: Tue Apr 17, 2018 11:45 pm
Contact:

Re: Friday Facts #287 - Just bugs again

Post by coderpatsy » Fri Mar 22, 2019 7:47 pm

Dixi wrote:
Fri Mar 22, 2019 7:43 pm
I don't see a difference between 1st and 2nd animated gif with splitters.
I see fully filled belt of fuel, where you inserting plates, two in a row. They fit like ...fffffPfPfff... Splitter takes one from each side and move to output. What else could we expect? Actually I never thought how splitters merge two belts, now I see - they do it one by one. Other possible way was, that they works like inserters, and grab several items at once.
Do you mean that on 1st picture output belt becomes not fully compressed, and there was a gap at some point?
In the first gif, the splitter introduces gaps in the output when it merges in the iron plates, highlighted by the debug option (the white lines). In the second gif it's fully compressed.

azurill_used_splash
Burner Inserter
Burner Inserter
Posts: 6
Joined: Fri Mar 01, 2019 5:11 am
Contact:

Re: Friday Facts #287 - Just bugs again

Post by azurill_used_splash » Fri Mar 22, 2019 8:24 pm

I notice that you're using a loader in the belt compression examples, albeit with the placeholder asset. Loaders also show up in the NPE, although they cannot be crafted by players. Is this indicative of plans to fully implement loaders, or are you planning on leaving them as 'campaign only' items? Will there be any benefit to using a loader for, say, side-loading a belt, as in the example you're using compared to direct belt side loading or using a stack inserter?

User avatar
Jon8RFC
Filter Inserter
Filter Inserter
Posts: 360
Joined: Tue May 10, 2016 3:39 pm
Contact:

Re: Friday Facts #287 - Just bugs again

Post by Jon8RFC » Fri Mar 22, 2019 9:17 pm

Very interesting to see the crash data graph, especially since the changelogs aren't showing as many "fixed crash" lines in the past week.
Image

User avatar
5thHorseman
Filter Inserter
Filter Inserter
Posts: 695
Joined: Fri Jun 10, 2016 11:21 pm
Contact:

Re: Friday Facts #287 - Just bugs again

Post by 5thHorseman » Sat Mar 23, 2019 1:50 am

Jon8RFC wrote:
Fri Mar 22, 2019 9:17 pm
Very interesting to see the crash data graph, especially since the changelogs aren't showing as many "fixed crash" lines in the past week.
Maybe one bug caused 1000 crashes.
"So you completed the game with a spaghetti factory? Well I hand crafted a rocket and threw it into space with my bare hands!"

Post Reply

Return to “News”

Who is online

Users browsing this forum: mcirish3