[1.1.36] Changes in CTRL-F behavior when using mods

Bugs that are actually features.
Post Reply
DarkShadow44
Filter Inserter
Filter Inserter
Posts: 339
Joined: Thu Jun 01, 2017 12:05 pm
Contact:

[1.1.36] Changes in CTRL-F behavior when using mods

Post by DarkShadow44 »

I'm using the what is it really used for mod to view recipes.
When pressing CTRL-F, it opens a search box to search recipes.
When the inventory is open, the inventory search has priority, which is okay.

Starting with 1.3.36 (just tested), CTRL-F always open the mod search box, even when the inventory is open. That is a bit confusing to me, since I'd expect search to affect the currently open window.
Is this an intended change, and is there something we could do about it? Either in factorio or the mod, so the behavior stays the same as pre 1.1.36.

Regards,
DarkShadow44

Rseding91
Factorio Staff
Factorio Staff
Posts: 13793
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [1.1.36] Changes in CTRL-F behavior when using mods

Post by Rseding91 »

Thanks for the report however this is somewhat intended. It's related to this fix: 98851

If the mod wants to override the games hotkey it has to set the prototype flag to do so. Otherwise the behavior it's going now is "correct".
If you want to get ahold of me I'm almost always on Discord.

DarkShadow44
Filter Inserter
Filter Inserter
Posts: 339
Joined: Thu Jun 01, 2017 12:05 pm
Contact:

Re: [1.1.36] Changes in CTRL-F behavior when using mods

Post by DarkShadow44 »

Thanks for the quick response.
Rseding91 wrote:
Sun Oct 31, 2021 11:35 pm
If the mod wants to override the games hotkey it has to set the prototype flag to do so.
I don't understand, isn't the problem here that the mod overrides the games hotkey accidentally?

Rseding91
Factorio Staff
Factorio Staff
Posts: 13793
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [1.1.36] Changes in CTRL-F behavior when using mods

Post by Rseding91 »

DarkShadow44 wrote:
Mon Nov 01, 2021 3:34 am
Thanks for the quick response.
Rseding91 wrote:
Sun Oct 31, 2021 11:35 pm
If the mod wants to override the games hotkey it has to set the prototype flag to do so.
I don't understand, isn't the problem here that the mod overrides the games hotkey accidentally?
The mod sets "consuming = "game-only"" which means work exactly as it does now: if it fires it blocks the game hotkeys. If the mod doesn't want to do that then it should just remove that line from it's prototype.
If you want to get ahold of me I'm almost always on Discord.

DarkShadow44
Filter Inserter
Filter Inserter
Posts: 339
Joined: Thu Jun 01, 2017 12:05 pm
Contact:

Re: [1.1.36] Changes in CTRL-F behavior when using mods

Post by DarkShadow44 »

I see... Without the "consuming" flag, the inventor search opens - but also the mod's search, which has priority.
Is there a way to have only the game process the input, and not the mod?

Rseding91
Factorio Staff
Factorio Staff
Posts: 13793
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [1.1.36] Changes in CTRL-F behavior when using mods

Post by Rseding91 »

DarkShadow44 wrote:
Mon Nov 01, 2021 2:16 pm
I see... Without the "consuming" flag, the inventor search opens - but also the mod's search, which has priority.
Is there a way to have only the game process the input, and not the mod?
Currently no. There's an order to inputs being processed and something always comes first. In this case it's mod inputs.
If you want to get ahold of me I'm almost always on Discord.

DarkShadow44
Filter Inserter
Filter Inserter
Posts: 339
Joined: Thu Jun 01, 2017 12:05 pm
Contact:

Re: [1.1.36] Changes in CTRL-F behavior when using mods

Post by DarkShadow44 »

I see. A flag for priority would work though, to put that mod in order behind the game. But I understand if you don't want to add that.

Post Reply

Return to “Not a bug”