[MOD 0.13.x] Shuttle Train v1.1.0

Topics and discussion about specific mods
User avatar
Roktaal
Long Handed Inserter
Long Handed Inserter
Posts: 79
Joined: Sat Mar 26, 2016 6:42 pm
Contact:

Re: [MOD 0.12.x] Shuttle Train v1.0.1

Post by Roktaal »

StanFear wrote:first, here, you're adding the button to all player even those not in the force that did the research
Good point. This should be better...

Code: Select all

script.on_event(defines.events.on_research_finished, function(event)
   addPlayerGui(game.get_player(event.player_index), event.research.name)
end)
StanFear wrote:seccound, instead of passing the tech name as a parameter, why don't you do the check in the on_research_finished ?
For no particular reason except that I don't like doing anything inside event handlers. I know it's the same, it's just personal preference.
User avatar
StanFear
Fast Inserter
Fast Inserter
Posts: 236
Joined: Sun Dec 15, 2013 2:49 pm
Contact:

Re: [MOD 0.12.x] Shuttle Train v1.0.1

Post by StanFear »

Roktaal wrote:
StanFear wrote:first, here, you're adding the button to all player even those not in the force that did the research
Good point. This should be better...

Code: Select all

script.on_event(defines.events.on_research_finished, function(event)
   addPlayerGui(game.get_player(event.player_index), event.research.name)
end)
errr ... sorry but nop, the event from on_research_finished does not contain a player index ... (I'm working on this issue btw)
User avatar
Roktaal
Long Handed Inserter
Long Handed Inserter
Posts: 79
Joined: Sat Mar 26, 2016 6:42 pm
Contact:

Re: [MOD 0.12.x] Shuttle Train v1.0.1

Post by Roktaal »

StanFear wrote:
Roktaal wrote:
StanFear wrote:first, here, you're adding the button to all player even those not in the force that did the research
Good point. This should be better...

Code: Select all

script.on_event(defines.events.on_research_finished, function(event)
   addPlayerGui(game.get_player(event.player_index), event.research.name)
end)
errr ... sorry but nop, the event from on_research_finished does not contain a player index ... (I'm working on this issue btw)
indeed...I failed
Didn't have time to test it. Just wrote it out of my head
orzelek
Smart Inserter
Smart Inserter
Posts: 3928
Joined: Fri Apr 03, 2015 10:20 am
Contact:

Re: [MOD 0.12.x] Shuttle Train v1.0.1

Post by orzelek »

Roktaal wrote:
StanFear wrote:
Roktaal wrote:
StanFear wrote:first, here, you're adding the button to all player even those not in the force that did the research
Good point. This should be better...

Code: Select all

script.on_event(defines.events.on_research_finished, function(event)
   addPlayerGui(game.get_player(event.player_index), event.research.name)
end)
errr ... sorry but nop, the event from on_research_finished does not contain a player index ... (I'm working on this issue btw)
indeed...I failed
Didn't have time to test it. Just wrote it out of my head
You didn't :D
Research event has technology and it gives you access to it's force. Through it you can access all the players that belong to it's force - can modify all players that were affected by the research.
User avatar
StanFear
Fast Inserter
Fast Inserter
Posts: 236
Joined: Sun Dec 15, 2013 2:49 pm
Contact:

Re: [MOD 0.12.x] Shuttle Train v1.0.1

Post by StanFear »

orzelek wrote:
Roktaal wrote:
StanFear wrote:
Roktaal wrote:
StanFear wrote:first, here, you're adding the button to all player even those not in the force that did the research
Good point. This should be better...

Code: Select all

script.on_event(defines.events.on_research_finished, function(event)
   addPlayerGui(game.get_player(event.player_index), event.research.name)
end)
errr ... sorry but nop, the event from on_research_finished does not contain a player index ... (I'm working on this issue btw)
indeed...I failed
Didn't have time to test it. Just wrote it out of my head
You didn't :D
Research event has technology and it gives you access to it's force. Through it you can access all the players that belong to it's force - can modify all players that were affected by the research.
But, while in the event, checking for the researched value of the technology returns false...
Anyways, this has been solved (in a pending merge)

Oh, and actually, I tried to access the players, sometimes the player list was empty...
orzelek
Smart Inserter
Smart Inserter
Posts: 3928
Joined: Fri Apr 03, 2015 10:20 am
Contact:

Re: [MOD 0.12.x] Shuttle Train v1.0.1

Post by orzelek »

StanFear wrote: Oh, and actually, I tried to access the players, sometimes the player list was empty...
If you can reproduce it I'd go and post a bug report.
Considering that in single player you are there in the force I'd expect that there is always a player in there.
Eonasdan
Manual Inserter
Manual Inserter
Posts: 2
Joined: Sat May 07, 2016 4:45 pm
Contact:

Re: [MOD 0.12.x] Shuttle Train v1.0.1

Post by Eonasdan »

Could you please make the shuttle go back to manual drive mode after it reaches a station?

As it is now, once the shuttle reaches the requested station, you have to go into the train and click "Stop the train" before it is player drive-able.

Thanks!
simwir
Inserter
Inserter
Posts: 23
Joined: Wed Mar 16, 2016 7:24 pm
Contact:

Re: [MOD 0.12.x] Shuttle Train v1.0.1

Post by simwir »

Eonasdan wrote:Could you please make the shuttle go back to manual drive mode after it reaches a station?

As it is now, once the shuttle reaches the requested station, you have to go into the train and click "Stop the train" before it is player drive-able.

Thanks!
Hmm yeah, it should probably do that. I've added it as a feature request on the github page
bchmura
Burner Inserter
Burner Inserter
Posts: 10
Joined: Fri May 27, 2016 3:22 pm
Contact:

Re: [MOD 0.12.x] Shuttle Train v1.0.1

Post by bchmura »

Hey, thanks for the mod! being able to easily suggest a destination will save me countless errors on turning the wrong way cause the train is going down the screen :)

I had a few ideas of what the mod may give me that I'll throw out as suggestions:

[*] A small personal shuttle train - game mechanics wise: Smaller sprite on screen, less resources to build, takes less damage, less fuel capacity, less fuel use.

[*] Electric version of the above, basically uses electricity from the grid and has a built in "accumulator" for going off grid for short distances.

I have some other ideas for train mods, but these fit in with what you are doing. I have a programming background and would be willing to try to make these for inclusion in your mod - here is the catch, I have no graphics skills at all. Prepared to be horrified level of skill :) I can ask around and see if anyone I know in that skill set would be willing to help me out with that part. In the meantime i can crop existing images down... maybe half of your image. anyway...

let me know what you think & thanks again
simwir
Inserter
Inserter
Posts: 23
Joined: Wed Mar 16, 2016 7:24 pm
Contact:

Re: [MOD 0.12.x] Shuttle Train v1.0.1

Post by simwir »

bchmura wrote:Hey, thanks for the mod! being able to easily suggest a destination will save me countless errors on turning the wrong way cause the train is going down the screen :)

I had a few ideas of what the mod may give me that I'll throw out as suggestions:

[*] A small personal shuttle train - game mechanics wise: Smaller sprite on screen, less resources to build, takes less damage, less fuel capacity, less fuel use.

[*] Electric version of the above, basically uses electricity from the grid and has a built in "accumulator" for going off grid for short distances.

I have some other ideas for train mods, but these fit in with what you are doing. I have a programming background and would be willing to try to make these for inclusion in your mod - here is the catch, I have no graphics skills at all. Prepared to be horrified level of skill :) I can ask around and see if anyone I know in that skill set would be willing to help me out with that part. In the meantime i can crop existing images down... maybe half of your image. anyway...

let me know what you think & thanks again
What purpose would the small train have? Is the train size really a problem? Would it then also have a lower top speed or is there no drawbacks to a smaller train? Not really sure I see where the need is, but feel free to elaborate :)

As for the electric I really like the idea, I just have no idea how it would be done. It seems like there are some in the 5dim's mod, but haven't looked at how it's implemented.

As for art, I my self is not very good at graphics. When I first released the mod it was just with standard train textures, the green train texture that's on the trains now are from Roktaal. If you want to help out with the mod you totally can, just fork the github page, and make a pull request when you have a feature you think the mod needs. :)
You could also create issues over there for the features. I have created one for the electric trains for now.
bNarFProfCrazy
Fast Inserter
Fast Inserter
Posts: 194
Joined: Sat Apr 23, 2016 7:11 am
Contact:

Re: [MOD 0.12.x] Shuttle Train

Post by bNarFProfCrazy »

Here a proposal for a German translation:
https://github.com/simwir/Shuttle-Train/pull/23

PS: Thanks for this awesome mod.
simwir
Inserter
Inserter
Posts: 23
Joined: Wed Mar 16, 2016 7:24 pm
Contact:

Re: [MOD 0.12.x] Shuttle Train

Post by simwir »

bNarFProfCrazy wrote:Here a proposal for a German translation:
https://github.com/simwir/Shuttle-Train/pull/23

PS: Thanks for this awesome mod.
I believe you when you say it's right, my German is not good enough to proof read it :D
bchmura
Burner Inserter
Burner Inserter
Posts: 10
Joined: Fri May 27, 2016 3:22 pm
Contact:

Re: [MOD 0.12.x] Shuttle Train v1.0.1

Post by bchmura »

simwir wrote:
bchmura wrote:Hey, thanks for the mod! being able to easily suggest a destination will save me countless errors on turning the wrong way cause the train is going down the screen :)

I had a few ideas of what the mod may give me that I'll throw out as suggestions:

[*] A small personal shuttle train - game mechanics wise: Smaller sprite on screen, less resources to build, takes less damage, less fuel capacity, less fuel use.

[*] Electric version of the above, basically uses electricity from the grid and has a built in "accumulator" for going off grid for short distances.

I have some other ideas for train mods, but these fit in with what you are doing. I have a programming background and would be willing to try to make these for inclusion in your mod - here is the catch, I have no graphics skills at all. Prepared to be horrified level of skill :) I can ask around and see if anyone I know in that skill set would be willing to help me out with that part. In the meantime i can crop existing images down... maybe half of your image. anyway...

let me know what you think & thanks again
What purpose would the small train have? Is the train size really a problem? Would it then also have a lower top speed or is there no drawbacks to a smaller train? Not really sure I see where the need is, but feel free to elaborate :)

As for the electric I really like the idea, I just have no idea how it would be done. It seems like there are some in the 5dim's mod, but haven't looked at how it's implemented.

As for art, I my self is not very good at graphics. When I first released the mod it was just with standard train textures, the green train texture that's on the trains now are from Roktaal. If you want to help out with the mod you totally can, just fork the github page, and make a pull request when you have a feature you think the mod needs. :)
You could also create issues over there for the features. I have created one for the electric trains for now.

the 5DIM mods have a lot going for them, I plan on checking those out. It looks like some of those were some of the mods I had in mind, but for the small train I was thinking it would be a smaller little thing for inside ones base itself. I was thinking of what I thought was the DART at the Dallas Airport, but it is called skylink https://upload.wikimedia.org/wikipedia/ ... _plane.jpg

So i was thinking it could function as a within the base transport - smaller in size, I would suggest something like (balancing would need to be done)

* Smaller footprint (half size)
* Takes less engines / resources to build
* has half hitpoints
* slower than real train
* your awesome "goto this station" controls

I could see the point that you already had to put down track, just having a bigger train is not a big deal. I think for this it is the aesthetics of having a smaller tram type car to ride around the base...

the fact 5DIM's stuff exists takes a bit of wind out of my sails :)
Bizobinator
Fast Inserter
Fast Inserter
Posts: 193
Joined: Fri May 06, 2016 10:35 pm
Contact:

Re: [MOD 0.12.x] Shuttle Train v1.0.1

Post by Bizobinator »

I LOVE this mod (especially that you can call the train to a station!).

Any chance you could update it for 0.13.1 & put it on the portal? :) Pleeeeeeeease?


Also, a random question: Do you guys do a single train & use R to flip it? Or two, back-to-back trains?
DanaScully
Burner Inserter
Burner Inserter
Posts: 10
Joined: Mon May 16, 2016 1:16 pm
Contact:

Re: [MOD 0.12.x] Shuttle Train v1.0.1

Post by DanaScully »

simwir, I also want to sign the petition for you making a 0.13 version of your awesome Shuttle Train mod! :mrgreen:

@ Bizobinator: I always have a two-faced shuttle train (i.e. 2 trains). Never tried it any other way. Works just right. No hassle with needing to change direction.
The Truth is out there
simwir
Inserter
Inserter
Posts: 23
Joined: Wed Mar 16, 2016 7:24 pm
Contact:

Re: [MOD 0.13.x] Shuttle Train v1.1.0

Post by simwir »

Bizobinator wrote:Any chance you could update it for 0.13.1 & put it on the portal? :) Pleeeeeeeease?
DanaScully wrote:simwir, I also want to sign the petition for you making a 0.13 version of your awesome Shuttle Train mod! :mrgreen:
Well you guys are in luck. Version 1.1.0 for Factorio 0.13 have now been released. I have tested it a bit, but there might still be bugs, if you experience any please post them here or on Github issues

v.1.1.0
  • Updated for Factorio version 0.13
  • Changed train to use the 0.13 train model, but still in green
  • Changed stacksize from 1 to 5
  • Made the train reset to manual mode upon arrival at destination station
  • German translation, courtesy of bNarFProfCrazy
simwir
Inserter
Inserter
Posts: 23
Joined: Wed Mar 16, 2016 7:24 pm
Contact:

Re: [MOD 0.13.x] Shuttle Train v1.1.0

Post by simwir »

Support on this thread is not guaranteed, please use the mod portal.
Post Reply

Return to “Mods”