[0.17.7] Crash when loading a save file - Controller::checkConsistency

[attichicco]

I tried with 4 different saves made with 0.17.5 or 0.17.6 and the game crash on loading, here is one of the crash reports:

[Loewchen]

Post a save that does this please.

Code: Select all

   0.000 2019-03-06 20:51:14; Factorio 0.17.7 (build 43421, win64, steam)
   0.000 Operating system: Windows 10 (build 17763) 
   0.001 Program arguments: "C:\Program Files (x86)\Steam\steamapps\common\Factorio\bin\x64\Factorio.exe" 
   0.001 Read data path: C:/Program Files (x86)/Steam/steamapps/common/Factorio/data
   0.001 Write data path: C:/Users/attic/AppData/Roaming/Factorio [252712/475521MB]
   0.001 Binaries path: C:/Program Files (x86)/Steam/steamapps/common/Factorio/bin
   0.009 System info: [CPU: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz, 8 cores, RAM: 7193/16340 MB, page: 13521/24276 MB, virtual: 4332/134217727 MB, extended virtual: 0 MB]
   0.009 Display options: [FullScreen: 1] [VSync: 1] [UIScale: automatic (100.0%)] [MultiSampling: OFF] [Screen: 255] [Lang: it]
   0.016 Available displays: 2
   0.016  [0]: \\.\DISPLAY6 - NVIDIA GeForce GTX 1080 {0x05, [0,0], 2560x1080, 32bit, 75Hz}
   0.016  [1]: \\.\DISPLAY7 - NVIDIA GeForce GTX 1080 {0x01, [-1920,0], 1920x1080, 32bit, 60Hz}
   0.058 [Direct3D11] Display: 0, Output: 0, DisplayAdapter: 0, RenderingAdapter: 0; d3dcompiler_47.dll
   0.134 Initialised Direct3D[0]: NVIDIA GeForce GTX 1080; id: 10de-1b80; driver: nvldumdx.dll 25.21.14.1935
   0.134   D3D Feature Level: 11.1, DXGI 1.5+
   0.134   [Local Video Memory] Budget: 6867MB, CurrentUsage: 2MB, Reservation: 0/3635MB
   0.134   [Non-Local Vid.Mem.] Budget: 7353MB, CurrentUsage: 0MB, Reservation: 0/3880MB
   0.134   Tiled resources: Tier 2
   0.134   Unified Memory Architecture: No
   0.134   BGR 565 Supported: Yes
   0.134   MaximumFrameLatency: 3, GPUThreadPriority: 0
   0.189 Desktop composition is active.
   0.189 Graphics settings preset: very-high
   0.189   Dedicated video memory size 8079 MB
   0.189 Graphics options: [Graphics quality: high] [Video memory usage: all] [Light scale: 100%] [DXT: high-quality]
   0.189                   [Max load threads: 32] [Max texture size: 0] [Tex.Stream.: 0] [Low quality rotation: 0]
   0.274 DSound: Starting _dsound_update thread
   0.275 DSound: Enter _dsound_update; tid=21704
   0.448 Loading mod core 0.0.0 (data.lua)
   0.525 Loading mod base 0.17.7 (data.lua)
   0.715 Loading mod base 0.17.7 (data-updates.lua)
   0.810 Checksum for core: 2736929835
   0.810 Checksum of base: 3541142062
   1.250 Loading sounds...
   1.315 Info PlayerData.cpp:69: Local player-data.json unavailable
   1.315 Info PlayerData.cpp:72: Cloud player-data.json available, timestamp 1551827974
   1.425 Initial atlas bitmap size is 16384
   1.448 Created atlas bitmap 16384x16384 [none]
   1.452 Created atlas bitmap 16384x11296 [none]
   1.452 Created atlas bitmap 16384x2116 [decal]
   1.453 Created atlas bitmap 16384x3808 [low-object]
   1.454 Created atlas bitmap 16384x1888 [mipmap, linear-minification, linear-magnification, linear-mip-level, no-crop, no-scale]
   1.454 Created atlas bitmap 16384x6880 [terrain, mipmap, linear-minification, linear-mip-level, no-crop]
   1.455 Created atlas bitmap 16384x480 [smoke, mipmap, linear-minification, linear-magnification]
   1.455 Created atlas bitmap 16384x456 [not-compressed, mipmap, linear-minification, linear-magnification, linear-mip-level, no-crop, no-scale]
   1.455 Created atlas bitmap 16384x748 [alpha-mask]
   1.458 Created atlas bitmap 16384x12640 [shadow, linear-magnification, alpha-mask]
   1.458 Created atlas bitmap 16384x1264 [shadow, mipmap, linear-magnification, alpha-mask]
   1.464 Texture processor created. GPU accelerated compression Supported: yes, Enabled: yes/yes. Test passed. YCoCgDXT PSNR: 35.83, BC3 PSNR: 33.82
   2.443 Parallel Sprite Loader initialized (threads: 7)
  12.286 Sprites loaded
  12.330 Generated mipmaps for atlas of size 16384x3808
  12.352 Generated mipmaps for atlas of size 16384x1888
  12.363 Generated mipmaps for atlas of size 16384x6880
  12.374 Generated mipmaps for atlas of size 16384x480
  12.384 Generated mipmaps for atlas of size 16384x456
  12.395 Generated mipmaps for atlas of size 16384x1264
  12.400 Custom inputs active: 0
  12.459 Factorio initialised
  28.516 Info ServerSynchronizer.cpp:29: nextHeartbeatSequenceNumber(0) initialized Synchronizer nextTickClosureTick(0).
  28.516 Info ServerMultiplayerManager.cpp:714: updateTick(4294967295) changing state from(Ready) to(PreparedToHostGame)
  28.516 Info ServerMultiplayerManager.cpp:714: updateTick(4294967295) changing state from(PreparedToHostGame) to(CreatingGame)
  28.517 Loading map C:\Users\attic\AppData\Roaming\Factorio\saves\_autosave1.zip: 9020049 bytes.
  28.588 Loading Level.dat: 18256396 bytes.
  28.591 Info Scenario.cpp:147: Map version 0.17.6-1
Factorio crashed. Generating symbolized stacktrace, please wait ...
c:\cygwin64\tmp\factorio-build-hr9tdu\libraries\stackwalker\stackwalker.cpp (924): StackWalker::ShowCallstack
c:\cygwin64\tmp\factorio-build-hr9tdu\src\util\logger.cpp (415): Logger::writeStacktrace
c:\cygwin64\tmp\factorio-build-hr9tdu\src\util\logger.cpp (566): Logger::logStacktrace
c:\cygwin64\tmp\factorio-build-hr9tdu\src\util\logging.cpp (89): Logging::logAndAbortOrThrow
c:\cygwin64\tmp\factorio-build-hr9tdu\src\util\logging.cpp (83): Logging::logAndAbortOrThrow
c:\cygwin64\tmp\factorio-build-hr9tdu\src\controller\controller.cpp (398): Controller::checkConsistency
c:\cygwin64\tmp\factorio-build-hr9tdu\src\controller\charactercontroller.cpp (883): CharacterController::checkConsistency
c:\cygwin64\tmp\factorio-build-hr9tdu\src\map\map.cpp (1960): Map::checkConsistency
c:\cygwin64\tmp\factorio-build-hr9tdu\src\map\map.cpp (1058): Map::setupEntities
c:\cygwin64\tmp\factorio-build-hr9tdu\src\scenario\scenario.cpp (226): Scenario::loadFactory
c:\cygwin64\tmp\factorio-build-hr9tdu\src\scenario\parallelscenarioloader.cpp (155): ParallelScenarioLoader::doLoad
c:\program files (x86)\microsoft visual studio\2017\buildtools\vc\tools\msvc\14.15.26726\include\thr\xthread (230): std::_LaunchPad<std::unique_ptr<std::tuple<void (__cdecl*)(ParallelScenarioLoader *,MapDeserialiser *,enum InputType,InputHandler *,MultiplayerManagerBase *,bool),ParallelScenarioLoader *,MapDeserialiser *,enum InputType,InputHandler *,MultiplayerManagerBase *,bool>,std::default_delete<std::tuple<void (__cdecl*)(ParallelScenarioLoader *,MapDeserialiser *,enum InputType,InputHandler *,MultiplayerManagerBase *,bool),ParallelScenarioLoader *,MapDeserialiser *,enum InputType,InputHandler *,MultiplayerManagerBase *,bool> > > >::_Go
c:\program files (x86)\microsoft visual studio\2017\buildtools\vc\tools\msvc\14.15.26726\include\thr\xthread (209): std::_Pad::_Call_func
minkernel\crts\ucrt\src\appcrt\startup\thread.cpp (115): thread_start<unsigned int (__cdecl*)(void * __ptr64)>
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFA2EB681F4)
00007FFA2EB681F4 (KERNEL32): (filename not available): BaseThreadInitThunk
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFA308BA251)
00007FFA308BA251 (ntdll): (filename not available): RtlUserThreadStart
Stack trace logging done
  30.878 Error Controller.cpp:398: mainInventory->getHandPosition() == NO_ITEM_STACK_INDEX was not true
Logger::writeStacktrace skipped.
  30.878 Error Util.cpp:97: Unexpected error occurred. If you're running the latest version of the game you can help us solve the problem by posting the contents of the log file on the Factorio forums.
Please also include the save file(s), any mods you may be using, and any steps you know of to reproduce the crash.
  37.124 Uploading log file
  37.129 Error CrashHandler.cpp:221: Heap validation: success.
  37.130 Creating crash dump.
  37.352 CrashDump success

[attichicco]

Downgrading back to 0.17.6 and then returning to 0.17.7 fixed it for me, and I am unable to reproduce it anymore, may be related to an update bug.
it was doing it with every save game, even new ones, so I don't think it mattered at the time.
Note: before downgrading i tested it twice, so it was not a bad start of the game or anything similar, something during the first time the game was updated caused it; the downgrade and then upgrade again fixed it

[wheybags]

For reference: viewtopic.php?f=226&t=65499
The save in that thread triggers an assert in Controller::checkConsistency()