[posila] [2.0.10] Graphics bug mirroring biochamber (MR)

[DerNickname01]

I mirrored a biochamber and weird shadows appear around it. Also one of the input pipes looks weird.

10-25-2024, 13-46-45.png (867.1 KiB) Viewed 661 times

[Kidninja]

I'm getting the same bug, it looks like graphics for the two fluid inputs are swapped when you mirror the biochamber. The simplest setup I found for reproduction was to just place a bio-chamber, set it to a recipe that has fluid inputs (I used the "Rocket fuel from jelly" recipe, so you don't even need one with unique inputs), and mirror it (using either mirror button). I encountered it when I wanted to mirror a setup I just planned, and ended up with weird shadow
s.

Left is a normal biochamber (set to the rocket fuel from jelly recipe), while on the right is one that has been mirrored after setting the recipe.

biochamber-glitch.png (381.17 KiB) Viewed 585 times

The weird shadow that the OP mentioned.

biochamber-glitch-shadow.png (470.22 KiB) Viewed 585 times

This visual glitch of input pipe graphics swapping seems to occur in all orientations, but is most noticeable when the pipes are facing north, as what is normally the north-eastern pipe has quite a large model that renders over the biochamber. There are also weird shadows that are disconnected from the biochamber or its own shadow.

Specific reproduction steps:

1. Place a biochamber
2. Set the recipe to something that uses fluid inputs
3. Use the horizontal mirror hotkey (H by default) to mirror it horizontally
4. observe weird graphics/shadows

Vertically mirroring it also produces the glitch, and it will retain its glitched state even if rotated or blueprinted, and will only be un-glitched by mirroring it again (which will switch the fluid inputs back to default, possibly removing the entire point of mirroring it).

[boskid]

Ref 120472 120113 121111

[Muche]

Ref 122187.

[robot256]

This is probably related to something observed my some mod makers. The pipe cover graphics are attached to the pipe connection prototype, which becomes connected to the recipe. Flipping the assembler moves the pipe connections, and moves the pipe covers with them. What the user/modder expects is for flipping to reassign which recipe entry goes to which pipe connection, and for the pipe connection itself to stay in one place with its pipe cover. I understand that would have some other consequences of messing up indexing. So you really do need to dynamically remap the pipe covers to the "new" pipe connection that is now at the coordinates of that pipe cover.

[posila]

Thanks for the report.

Fixed for 2.0.24 by adding FluidBox::mirrored_pipe_picture and mirrored_pipe_picture_frozen.