[1.0.0] Nuclear Reactor top-east-facing heat ending misalignment

Things that we don't consider worth fixing at this moment.
Post Reply
User avatar
kirazy
Filter Inserter
Filter Inserter
Posts: 416
Joined: Tue Mar 06, 2018 12:18 am
Contact:

[1.0.0] Nuclear Reactor top-east-facing heat ending misalignment

Post by kirazy »

nuclear-reactor-heat-ending-misalignment.png
nuclear-reactor-heat-ending-misalignment.png (253.05 KiB) Viewed 2667 times
The sprite is misaligned in the spritesheet hr-reactor-connect-patches.png:
hr-reactor-connect-patches.png
hr-reactor-connect-patches.png (46.47 KiB) Viewed 2667 times
You can see how it's a few pixels down (fourth column) from the other two east-facing ends.

User avatar
NotRexButCaesar
Smart Inserter
Smart Inserter
Posts: 1120
Joined: Sun Feb 16, 2020 12:47 am
Contact:

Re: [1.0.0] Nuclear Reactor top-east-facing heat ending misalignment

Post by NotRexButCaesar »

This looks like a mod issue to me: probably the same mod that changes the reactor color. Vanilla reactors look like this:
1.jpg
1.jpg (62.79 KiB) Viewed 2664 times
—Crevez, chiens, si vous n'étes pas contents!

User avatar
kirazy
Filter Inserter
Filter Inserter
Posts: 416
Joined: Tue Mar 06, 2018 12:18 am
Contact:

Re: [1.0.0] Nuclear Reactor top-east-facing heat ending misalignment

Post by kirazy »

Those are connected. I am speaking of the disconnected state. The image in the OP is edited to move the two reactors next to each other to more clearly show the issue.

The hr-reactor-connect-patch.png file posted here, where the misalignment is very obvious, is straight out of base/graphics/entity/nuclear-reactor.

User avatar
valneq
Smart Inserter
Smart Inserter
Posts: 1150
Joined: Fri Jul 12, 2019 7:43 am
Contact:

Re: [1.0.0] Nuclear Reactor top-east-facing heat ending misalignment

Post by valneq »

How relevant is this if you never see them next to each other in this disconnected state? Just wondering …

User avatar
kirazy
Filter Inserter
Filter Inserter
Posts: 416
Joined: Tue Mar 06, 2018 12:18 am
Contact:

Re: [1.0.0] Nuclear Reactor top-east-facing heat ending misalignment

Post by kirazy »

The misalignment is with respect to the grid that all heat pipes are aligned to. It's not misaligned to the nuclear reactor specifically. It's a bug, but not a very serious one...

It would be analogous to a pipe cover being 5 pixels down-shifted from the pipe it's trying to cover.

User avatar
Klonan
Factorio Staff
Factorio Staff
Posts: 5150
Joined: Sun Jan 11, 2015 2:09 pm
Contact:

Re: [1.0.0] Nuclear Reactor top-east-facing heat ending misalignment

Post by Klonan »

Gonna call this a 'who cares'

User avatar
kirazy
Filter Inserter
Filter Inserter
Posts: 416
Joined: Tue Mar 06, 2018 12:18 am
Contact:

Re: [1.0.0] Nuclear Reactor top-east-facing heat ending misalignment

Post by kirazy »

Well, if you change your mind, here's the fix which took 60 seconds:
Attachments
reactor-connect-patches-heated.png
reactor-connect-patches-heated.png (13.86 KiB) Viewed 2472 times
reactor-connect-patches.png
reactor-connect-patches.png (16.89 KiB) Viewed 2472 times
hr-reactor-connect-patches-heated.png
hr-reactor-connect-patches-heated.png (37.99 KiB) Viewed 2472 times
hr-reactor-connect-patches.png
hr-reactor-connect-patches.png (49.57 KiB) Viewed 2472 times

User avatar
Optera
Smart Inserter
Smart Inserter
Posts: 2916
Joined: Sat Jun 11, 2016 6:41 am
Contact:

Re: [1.0.0] Nuclear Reactor top-east-facing heat ending misalignment

Post by Optera »

You could release the fix as mod.
I'd be one to download it.

User avatar
MakeItGraphic
Fast Inserter
Fast Inserter
Posts: 237
Joined: Sat Jan 06, 2018 7:53 am
Contact:

Re: [1.0.0] Nuclear Reactor top-east-facing heat ending misalignment

Post by MakeItGraphic »

Optera wrote:
Mon Nov 16, 2020 1:05 pm
You could release the fix as mod.
I'd be one to download it.
Nah, I saw this when it was first posted and I agree with Kirazy it is a 60 second fix. No reason it can't be fixed in 1.1 IMO. Pride of ownership and all that, at least acknowledge it as a minor issue.

Post Reply

Return to “Won't fix.”