[0.18.1] Mod: rocket-silo gets stuck with fluid energy source

This subforum contains all the issues which we already resolved.
Post Reply
CaveGrinder
Inserter
Inserter
Posts: 35
Joined: Fri Aug 24, 2018 7:42 pm
Contact:

[0.18.1] Mod: rocket-silo gets stuck with fluid energy source

Post by CaveGrinder »

Hi,

i have observed the following bug, both with 0.18.1 and 0.17.79.
When the rocket-silo is made to burn liquids, rather than electricity, it doesn't advance from rocket crafting to launching.

steps to reproduce:
1. copy minimal mod for 0.18.1 to the mods and the savegame to the saves. launch game and load save.
2. observe that the crafting of the rocket parts works fine
3. wait 5 seconds
4. observe that the silo doesn't launch a rocket

expected behavior:
the silo burns the fluid to power itself through the launching phase

mod prototype changes:

Code: Select all

data:extend(
{
    --fluid, which acts as the fuel
    {
        type = "fluid",
        name = "custom-fluid",
        default_temperature = 25,
        fuel_value = "1kJ",
        base_color = {r=0, g=0.4, b=0},
        flow_color = {r=0, g=0.5, b=0},
        max_temperature = 100,
        icon = "__base__/graphics/icons/fluid/water.png",
        icon_size = 32,
        order = "a[fluid]-h[robot-labor]"
    },
})

data.raw["rocket-silo"]["rocket-silo"].energy_source =
    {
        type = "fluid",
        emissions_per_minute = 0,
        render_no_power_icon = true,
        fluid_box =
        {
          base_area = 1000000,
          height = 1,
          base_level = 0,
          pipe_connections =
          {
          },
          production_type = "input",
          filter = "custom-fluid"
        },
        burns_fluid = true,
        scale_fluid_usage = true,
        effectivity = 1,
    }
all the control.lua does is fill the fluid box automatically.
specifying the energy source like this worked for assemblers and furnaces
(also it is intentional that i didn't specify a pipe connection as my mod is not supposed to have one)
Attachments
screenshot
screenshot
screenshot.png (2.82 MiB) Viewed 2049 times
FluidPoweredSiloBug_1.zip
save game for 0.18.1
(1.43 MiB) Downloaded 58 times
FluidPoweredSiloBug_0.1.1.zip
minimal mod for 0.18.1
(2.46 KiB) Downloaded 63 times
FluidPoweredSiloBug_0.1.1.zip
minimal mod for 0.17.79
(2.46 KiB) Downloaded 59 times
factorio-current.log
log file from 0.17.79
(4.93 KiB) Downloaded 63 times
factorio-current.log
log file from 0.18.1
(5.35 KiB) Downloaded 69 times

Honktown
Smart Inserter
Smart Inserter
Posts: 1025
Joined: Thu Oct 03, 2019 7:10 am
Contact:

Re: [0.18.1] Mod: rocket-silo gets stuck with fluid energy source

Post by Honktown »

The rocket-silo is one of three entities that uses active_energy_usage (the other two being combinators?!), and that is the value which is used for preparing the rocket. The crafting energy is based on energy_usage (which is normally what entities use). Getting an impression active_energy_usage wasn't prepared for a non-electric source or something.

Uhhh not to steal your thread, but fluid was definitely not intended as an energy source for certain things.

Remember how I mentioned combinators being the other two active_energy_usage entities? I attached your energy_source table to a decider combinator.
crash
I have mods! I guess!
Link

Rseding91
Factorio Staff
Factorio Staff
Posts: 13209
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [0.18.1] Mod: rocket-silo gets stuck with fluid energy source

Post by Rseding91 »

Thanks for the report. I'm willing to "handle" this report in 1 of 2 ways: I can remove support to use fluid energy sources from rocket silos or I can move this to "won't fix".

The rocket silo entity was designed to use electric energy sources and if it happens to work with any other types that's "fine". If issues show up with those other energy types then I'm going to just start hard-coding it to not support them. It's outside of what I want to support modding wise.

The fluid energy source type was a mistake and we shouldn't have added it. It has been nothing but pain points and bugs since it was put in.
If you want to get ahold of me I'm almost always on Discord.

Rseding91
Factorio Staff
Factorio Staff
Posts: 13209
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [0.18.1] Mod: rocket-silo gets stuck with fluid energy source

Post by Rseding91 »

As for the crash when trying to define fluid energy sources on combinators: i've fixed that. Now it just reports an error on startup and says "you can't do that".
If you want to get ahold of me I'm almost always on Discord.

CaveGrinder
Inserter
Inserter
Posts: 35
Joined: Fri Aug 24, 2018 7:42 pm
Contact:

Re: [0.18.1] Mod: rocket-silo gets stuck with fluid energy source

Post by CaveGrinder »

that's fair enough; in my opinion rejecting the prototype is then preferable as it gives early, clear feedback.
(I hope at some point a mod comes around making the fluid energy source at least somewhat worth it; i am exploring it a bit at the moment. The reason why for my design i chose fluid over burner energy source is that players can't access it directly)

User avatar
ptx0
Smart Inserter
Smart Inserter
Posts: 1507
Joined: Wed Jan 01, 2020 7:16 pm
Contact:

Re: [0.18.1] Mod: rocket-silo gets stuck with fluid energy source

Post by ptx0 »

in bob's, we burn barrels and bottles of fluids for fuel. it works well.

Bilka
Factorio Staff
Factorio Staff
Posts: 3130
Joined: Sat Aug 13, 2016 9:20 am
Contact:

Re: [0.18.1] Mod: rocket-silo gets stuck with fluid energy source

Post by Bilka »

Looks like this was fixed with the fix for 93640. At least, it works in 1.1.94.
I'm an admin over at https://wiki.factorio.com. Feel free to contact me if there's anything wrong (or right) with it.

Post Reply

Return to “Resolved Problems and Bugs”