Bob's Logistics locale

Some mods, made by Bob. Basically streaks every Factroio-area.

Moderator: bobingabout

User avatar
DRY411S
Filter Inserter
Filter Inserter
Posts: 731
Joined: Sun Mar 13, 2016 9:48 am
Contact:

Bob's Logistics locale

Post by DRY411S »

On your next release, would you mind either moving or duplicating entries for your bob-valve into the entity-name section of your locale please?

My Recycling Machines Mod checks every item prototype for certain properties. Your bob-valve have the 'place_result' property which suggests that there is an entity prototype associated, and that the locale should be in the entity-name section. As a result, my Recycling Machine gives an ugly error display when i hover over your entity in the Recycling Machines menus.
bob-valve.png
bob-valve.png (219.45 KiB) Viewed 2990 times
To put this into context, this is the only example I can find in all of your Mods where this happens. So far I've discovered it in only 3 places across dozens of other Mods.
User avatar
bobingabout
Smart Inserter
Smart Inserter
Posts: 7352
Joined: Fri May 09, 2014 1:01 pm
Contact:

Re: Bob's Logistics locale

Post by bobingabout »

I'll have to look at what I did.
Creator of Bob's mods. Expanding your gameplay since version 0.9.8.
I also have a Patreon.
User avatar
bobingabout
Smart Inserter
Smart Inserter
Posts: 7352
Joined: Fri May 09, 2014 1:01 pm
Contact:

Re: Bob's Logistics locale

Post by bobingabout »

Alright, I'm adding the following to entity, and item, and apparently already existed for recipe.

Code: Select all

bob-valve=__ITEM__valve__
bob-valve=__ENTITY__valve__
This should fix the issue without boblocale having to be updated, as using this method should map to the active locale.

It will be in the next release.
Creator of Bob's mods. Expanding your gameplay since version 0.9.8.
I also have a Patreon.
User avatar
DRY411S
Filter Inserter
Filter Inserter
Posts: 731
Joined: Sun Mar 13, 2016 9:48 am
Contact:

Re: Bob's Logistics locale

Post by DRY411S »

Thank you
User avatar
DRY411S
Filter Inserter
Filter Inserter
Posts: 731
Joined: Sun Mar 13, 2016 9:48 am
Contact:

Re: Bob's Logistics locale

Post by DRY411S »

Actually, because you have a localised_name property set for the valve prototype, I don't actually need the change in your locale. My code should test for that and use it where it finds it.

That's not true for any other modders I have contacted though.
User avatar
bobingabout
Smart Inserter
Smart Inserter
Posts: 7352
Joined: Fri May 09, 2014 1:01 pm
Contact:

Re: Bob's Logistics locale

Post by bobingabout »

DRY411S wrote:Actually, because you have a localised_name property set for the valve prototype, I don't actually need the change in your locale. My code should test for that and use it where it finds it.

That's not true for any other modders I have contacted though.
I was going to say it has that... however... I've deleted it now for the next version.... honestly, it wasn't really needed there when I could have done what I just changed it to in the begining.
Creator of Bob's mods. Expanding your gameplay since version 0.9.8.
I also have a Patreon.
Post Reply

Return to “Bob's mods”