[0.11.16] Updater doesn't follow Read/Write/Binary Paths

[pcmaster160]

The autoupdater is broken on linux unless it is installed to a certain directory. Different distros of linux handle directories differently, the config field for read data path, write data path, and binary paths are useful for this. Though the updater does not follow these paths and will crash when trying to update.

Log:
At the start of the output:

Code: Select all

123898.758194  Info Logger.cpp:156: Operating system: Linux
123898.758201  Info Paths.cpp:202: Read data path: /usr/share/factorio
123898.758207  Info Paths.cpp:203: Write data path: /home/matt/.factorio
123898.758212  Info Paths.cpp:204: Binaries path: /home

After hitting update:

Code: Select all

124363.570089  Info Updater.cpp:716: Downloading https://www.factorio.com/updater/get-available-versions?username=pcmaster160&token=<private>&apiVersion=2
124364.135962  Notice Updater.cpp:147: 2 packages available to download (experimental updates enabled).
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
124365.902672  Info Updater.cpp:716: Downloading https://www.factorio.com/updater/get-download-link?username=pcmaster160&token=<private>&package=core-linux64&from=0.11.14&to=0.11.15&isTarget=false&apiVersion=2
124366.445500  Info Updater.cpp:198: Downloading <updateurl>
124372.409465  Info Updater.cpp:209:  => 200
124372.424190  Error Util.cpp:43: Error when opening /home/x64/factorio for reading: No such file or directory
124372.920105  Info GlobalContext.cpp:471: Goodbye

The updater tries to install to /home/x64/factorio. I use arch linux and install the binary to /usr/bin, the data to /usr/share/factorio and write data to /home/matt/.factorio. There are already configuration settings for the data read and write paths, and it seems a setting that can not be configured in the configuration file for the binaries location. The updater simply needs to be made aware of these values when updating.

[MF-]

So, basically, you're requesting another config item to set the "binary path" for the autoupdater?

From what's posted it looks that the autoupdater detects the binary path as "/home"
and correctly tries to write to /home/x64/factorio

[kovarex]

From what I remember, the autoupdater is desinged to work only for the zip installation. The problems related to autoupdating the regulary installed linux app were the main reason to drop the package distribution.

[cube]

... and this goes to minor issues :-) Sorry. Maybe some day there will be enough time to fix problems like this.