[0.12.4] God controller results in crash in inventory

[theit8514]

I've been testing some changes to a mod, and I've been getting a crash in God mode that I don't get in regular mode.

I can replicate this crash by:
Start sandbox mode, place chest and put item in.
Open chest, close chest, open chest, attempt to shift click item out. Several repetitions may be needed.

Log output

Factorio crashed. Generating symbolized stacktrace, please wait ...
c:\temp\factorio-061386bd\libraries\stackwalker\stackwalker.cpp (923): StackWalker::ShowCallstack
c:\temp\factorio-061386bd\src\util\logger.cpp (283): Logger::writeStacktrace
c:\temp\factorio-061386bd\src\util\logger.cpp (337): Logger::logStacktrace
c:\temp\factorio-061386bd\src\util\crashhandler.cpp (79): CrashHandler::writeStackTrace
c:\temp\factorio-061386bd\src\util\crashhandler.cpp (88): CrashHandler::SehHandler
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFFB20E02CE)
00007FFFB20E02CE (KERNELBASE): (filename not available): UnhandledExceptionFilter
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFFB5248992)
00007FFFB5248992 (ntdll): (filename not available): memset
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFFB5233F66)
00007FFFB5233F66 (ntdll): (filename not available): _C_specific_handler
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFFB524633D)
00007FFFB524633D (ntdll): (filename not available): _chkstk
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFFB51C3C00)
00007FFFB51C3C00 (ntdll): (filename not available): RtlWalkFrameChain
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFFB524544A)
00007FFFB524544A (ntdll): (filename not available): KiUserExceptionDispatcher
ERROR: SymGetSymFromAddr64, GetLastError: 126 (Address: 000000B6A6079490)
ERROR: SymGetLineFromAddr64, GetLastError: 126 (Address: 000000B6A6079490)
ERROR: SymGetModuleInfo64, GetLastError: 1114 (Address: 000000B6A6079490)
000000B6A6079490 ((module-name not available)): (filename not available): (function-name not available)
c:\temp\factorio-061386bd\src\item\inventoryhighlights.cpp (79): InventoryHighlights::add
c:\temp\factorio-061386bd\src\item\inventoryhighlights.cpp (227): InventoryHighlights::MaintainerOfInventoryChanges::~MaintainerOfInventoryChanges
c:\temp\factorio-061386bd\src\controller\godcontroller.cpp (381): GodController::transferFromInternal
c:\temp\factorio-061386bd\src\controller\godcontroller.cpp (514): GodController::transferFrom
c:\temp\factorio-061386bd\src\gameactionhandler.cpp (1053): GameActionHandler::performTransfer
c:\temp\factorio-061386bd\src\gameactionhandler.cpp (997): GameActionHandler::stackTransfers
c:\temp\factorio-061386bd\src\gameactionhandler.cpp (204): GameActionHandler::actionPerformed
c:\temp\factorio-061386bd\src\input\inputhandler.cpp (36): InputHandler::flushToListeners
c:\temp\factorio-061386bd\src\input\inputhandler.cpp (29): InputHandler::flushActions
c:\temp\factorio-061386bd\src\gameactionhandler.cpp (243): GameActionHandler::update
c:\temp\factorio-061386bd\src\mainloop.cpp (244): MainLoop::gameUpdateStep
c:\temp\factorio-061386bd\src\mainloop.cpp (353): MainLoop::updateLoop
c:\boost_1_58_0\boost\function\function_template.hpp (160): boost::detail::function::void_function_obj_invoker0<boost::_bi::bind_t<void,void (__cdecl*)(ThreadBarrier * __ptr64,boost::chrono::time_point<boost::chrono::steady_clock,boost::chrono::duration<__int64,boost::ratio<1,1000000000> > > * __ptr64,boost::chrono::time_point<boost::chrono::steady_clock,boost::chrono::duration<__int64,boost::ratio<1,1000000000> > > * __ptr64,bool * __ptr64,bool),boost::_bi::list5<boost::_bi::value<ThreadBarrier * __ptr64>,boost::_bi::value<boost::chrono::time_point<boost::chrono::steady_clock,boost::chrono::duration<__int64,boost::ratio<1,1000000000> > > * __ptr64>,boost::_bi::value<boost::chrono::time_point<boost::chrono::steady_clock,boost::chrono::duration<__int64,boost::ratio<1,1000000000> > > * __ptr64>,boost::_bi::value<bool * __ptr64>,boost::_bi::value<bool> > >,void>::invoke
c:\temp\factorio-061386bd\src\util\thread.cpp (34): Thread::loop
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FF6E881EB53)
00007FF6E881EB53 (Factorio): (filename not available): boost::`anonymous namespace'::thread_start_function
f:\dd\vctools\crt\crtw32\startup\threadex.c (376): _callthreadstartex
f:\dd\vctools\crt\crtw32\startup\threadex.c (354): _threadstartex
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFFB4D72D92)
00007FFFB4D72D92 (KERNEL32): (filename not available): BaseThreadInitThunk
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFFB51B9F64)
00007FFFB51B9F64 (ntdll): (filename not available): RtlUserThreadStart

[EditorRUS]

I am more than sure it's because in god mode there is no player character and game tries to use null entity.
I may be wrong, I haven't coded for Factorio for a while.


Apparently.

[Oxyd]

Sounds like a duplicate to me. Should be fixed in 0.12.5.