Recursive table serialization

[Honktown]

Have to re-do my mod a little bit because the devs detect if you try to store tables recursively and actually put nil the in the table.

@BILKA I KNOW IT WAS YOU

Code: Select all

train changed state Global:
{
  combinators = {
    [-225.5] = {
      [-161.5] = {
        entity = {
          __self = "userdata"
        },
        signal = 1,
        stop = {
          entity = {
            __self = "userdata"
          },
          unit_number = 467616
        },
        x = -225.5,
        y = -161.5
      }
    }
  },
  inventory_size = {
    ["cargo-wagon"] = 40
  },
  on_tick_combinators = {},
  players = {
    {
      combinator = nil,
      stop = nil
    }
  },
  watched_stops = {
    [467616] = {
      nil,
      entity = nil
    }
  }
}

After some sleep.

[eradicator]

Have to re-do my mod a little bit because the devs detect if you try to store tables recursively and actually put nil the in the table.

@BILKA I KNOW IT WAS YOU

[...]
After some sleep.

Dear Mr. Troll. Please RTFM before you start blaming random people on random threads for your own inability to correctly interpret serpent output. ><((((*>

(Edit: Moved part of the post back to the original slot-reader thread.)

[Honktown]

Have to re-do my mod a little bit because the devs detect if you try to store tables recursively and actually put nil the in the table.

@BILKA I KNOW IT WAS YOU

[...]
After some sleep.

Dear Mr. Troll. Please RTFM before you start blaming random people on random threads for your own inability to correctly interpret serpent output. ><((((*>

Bro, the mod isn't working because literally after I put the table in something recursively the previous reference gets nil'd. It's not serpent, I'm actually getting in-game errors that my shit is nil, when it was valid and the variable wasn't re-assigned. Recursive tables aren't serializable. It makes sense they'd have protection. I can link you the exact code, and step-by-step you'll see the engine blocking the recursion.

[Rseding91]

Recursive tables aren't serializable.

Yes they are.

[Honktown]

Recursive tables aren't serializable.

Yes they are.

I don't even know what's going on anymore.

wall of log

Code: Select all

40239.289 Script @__TrainWagonCombinators__/wagonreader/wagonreader.lua:368: 
started on_gui_click Global:
{
  combinators = {},
  inventory_size = {
    ["cargo-wagon"] = 40
  },
  on_tick_combinators = {},
  players = {
    {
      combinator = {
        entity = {
          __self = "userdata"
        },
        x = -48.5,
        y = -34.5
      },
      stop = {
        entity = {
          __self = "userdata"
        },
        unit_number = 115861
      }
    }
  },
  watched_stops = {}
}
40239.289 Script @__TrainWagonCombinators__/wagonreader/wagonreader.lua:399: 
started train stops table Global:
{
  combinators = {},
  inventory_size = {
    ["cargo-wagon"] = 40
  },
  on_tick_combinators = {},
  players = {
    {
      combinator = {
        entity = {
          __self = "userdata"
        },
        x = -48.5,
        y = -34.5
      },
      stop = {
        entity = {
          __self = "userdata"
        },
        unit_number = 115861
      }
    }
  },
  watched_stops = {
    [115861] = {}
  }
}
40239.289 Script @__TrainWagonCombinators__/wagonreader/wagonreader.lua:400: selected is: 1 which is a : string tonumber: 1 which is a number
40239.289 Script @__TrainWagonCombinators__/wagonreader/wagonreader.lua:402: c before storing: {
  entity = {
    __self = "userdata"
  },
  x = -48.5,
  y = -34.5
}
40239.289 Script @__TrainWagonCombinators__/wagonreader/wagonreader.lua:404: 
stored c at selected index
{
  combinators = {},
  inventory_size = {
    ["cargo-wagon"] = 40
  },
  on_tick_combinators = {},
  players = {
    {
      combinator = {
        entity = {
          __self = "userdata"
        },
        x = -48.5,
        y = -34.5
      },
      stop = {
        entity = {
          __self = "userdata"
        },
        unit_number = 115861
      }
    }
  },
  watched_stops = {
    [115861] = {
      nil
    }
  }
}
40239.289 Script @__TrainWagonCombinators__/wagonreader/wagonreader.lua:405: c after storing: {
  entity = {
    __self = "userdata"
  },
  x = -48.5,
  y = -34.5
}
40239.289 Script @__TrainWagonCombinators__/wagonreader/wagonreader.lua:406: pstop.unit number: 115861 tonumber(selected): 1
40239.289 Script @__TrainWagonCombinators__/wagonreader/wagonreader.lua:408: 
stored pstop.entity in watched stops entityGlobal:
{
  combinators = {},
  inventory_size = {
    ["cargo-wagon"] = 40
  },
  on_tick_combinators = {},
  players = {
    {
      combinator = {
        entity = {
          __self = "userdata"
        },
        x = -48.5,
        y = -34.5
      },
      stop = {
        entity = {
          __self = "userdata"
        },
        unit_number = 115861
      }
    }
  },
  watched_stops = {
    [115861] = {
      nil,
      entity = nil
    }
  }
}
40239.290 Script @__TrainWagonCombinators__/wagonreader/wagonreader.lua:411: 
c.stop = pstop Global:
{
  combinators = {},
  inventory_size = {
    ["cargo-wagon"] = 40
  },
  on_tick_combinators = {},
  players = {
    {
      combinator = {
        entity = {
          __self = "userdata"
        },
        stop = {
          entity = {
            __self = "userdata"
          },
          unit_number = 115861
        },
        x = -48.5,
        y = -34.5
      },
      stop = nil
    }
  },
  watched_stops = {
    [115861] = {
      nil,
      entity = nil
    }
  }
}
40239.290 Script @__TrainWagonCombinators__/wagonreader/wagonreader.lua:413: 
recorded signalGlobal:
{
  combinators = {},
  inventory_size = {
    ["cargo-wagon"] = 40
  },
  on_tick_combinators = {},
  players = {
    {
      combinator = {
        entity = {
          __self = "userdata"
        },
        signal = 1,
        stop = {
          entity = {
            __self = "userdata"
          },
          unit_number = 115861
        },
        x = -48.5,
        y = -34.5
      },
      stop = nil
    }
  },
  watched_stops = {
    [115861] = {
      nil,
      entity = nil
    }
  }
}
40239.290 Script @__TrainWagonCombinators__/wagonreader/wagonreader.lua:416: 
started x combinators Global:
{
  combinators = {
    [-48.5] = {}
  },
  inventory_size = {
    ["cargo-wagon"] = 40
  },
  on_tick_combinators = {},
  players = {
    {
      combinator = {
        entity = {
          __self = "userdata"
        },
        signal = 1,
        stop = {
          entity = {
            __self = "userdata"
          },
          unit_number = 115861
        },
        x = -48.5,
        y = -34.5
      },
      stop = nil
    }
  },
  watched_stops = {
    [115861] = {
      nil,
      entity = nil
    }
  }
}
40239.290 Script @__TrainWagonCombinators__/wagonreader/wagonreader.lua:419: 
started y and stored c
{
  combinators = {
    [-48.5] = {
      [-34.5] = {
        entity = {
          __self = "userdata"
        },
        signal = 1,
        stop = {
          entity = {
            __self = "userdata"
          },
          unit_number = 115861
        },
        x = -48.5,
        y = -34.5
      }
    }
  },
  inventory_size = {
    ["cargo-wagon"] = 40
  },
  on_tick_combinators = {},
  players = {
    {
      combinator = nil,
      stop = nil
    }
  },
  watched_stops = {
    [115861] = {
      nil,
      entity = nil
    }
  }
}

the function

Code: Select all

local function on_gui_click(event)
  local stop = nil
  local c = nil
  local pid = event.player_index
  local selected = ""
  local i = 1
  local pstop = nil

  -- table is only made when either stop or combinator is opened
  if not global.players[pid] then return end

  log("\nstarted on_gui_click Global:\n" .. serpent.block(global))


  if event.element.name == "button_apply" then
    if global.players[pid].stop and global.players[event.player_index].combinator then
      pstop = global.players[pid].stop
      c = global.players[pid].combinator
      selected = game.players[pid].gui.screen.wagonreader.flow.fl_stop.wagonN.selected_index
      game.players[1].print("selected:" .. selected)
      selected = game.players[pid].gui.screen.wagonreader.flow.fl_stop.wagonN.get_item(selected)
      game.players[1].print("selected: " .. selected .. " type: " .. type(selected))
      if pstop.entity.valid == false then
        remove_stop(pstop)
        remove_combinator_entirely(global.players[pid].combinator)
        return
      end
      
      if c.entity.valid == false then
        remove_combinator_entirely(global.players[pid].combinator)
        return
      end

      if global.on_tick_combinators[c.x] and global.on_tick_combinators[c.x][c.y] then
        global.on_tick_combinators[c.x][c.y] = nil
      end

      if selected == "nil" then
        remove_combinator_entirely(global.players[pid].combinator)
        return
      else
        global.watched_stops[pstop.unit_number] = global.watched_stops[pstop.unit_number] or {}
        log("\nstarted train stops table Global:\n" .. serpent.block(global))
        log("selected is: " .. selected .. " which is a : " .. type(selected) .. " tonumber: " .. tonumber(selected) .. " which is a " .. type(tonumber(selected)))

        log("c before storing: " .. serpent.block(c))
        global.watched_stops[pstop.unit_number][tonumber(selected)] = c
        log("\nstored c at selected index\n" .. serpent.block(global))
        log("c after storing: " .. serpent.block(c))
        log("pstop.unit number: " .. pstop.unit_number .. " tonumber(selected): " .. tonumber(selected))
        global.watched_stops[pstop.unit_number].entity = pstop.entity
        log("\nstored pstop.entity in watched stops entityGlobal:\n" .. serpent.block(global))

        c.stop = pstop
        log("\nc.stop = pstop Global:\n" .. serpent.block(global))
        c.signal = game.players[pid].gui.screen.wagonreader.flow.fl_combinator.signal.selected_index
        log("\nrecorded signalGlobal:\n" .. serpent.block(global))

        global.combinators[c.x] = global.combinators[c.x] or {}
        log("\nstarted x combinators Global:\n" .. serpent.block(global))

        global.combinators[c.x][c.y] = c
        log("\nstarted y and stored c\n" .. serpent.block(global))

        game.players[pid].print("wagon " .. selected .. " assigned to combinator at " .. c.x .. "x" .. c.y)
        log("\nassigned combinator and stop Global:\n" .. serpent.block(global))
      end
    end
  end
end

[Koub]

[Koub] I Split these posts from the empty inventory slot reader thread because it started getting off topic, and became a subject of discussion of its own. I hope my limited understanding is correct.

[Honktown]

[Koub] I Split these posts from the empty inventory slot reader thread because it started getting off topic, and became a subject of discussion of its own. I hope my limited understanding is correct.

The mod is for empty slot reading, but there's something weird going on. Some of my tables get replaced with nil metatables.

Code: Select all

38957.044 Error MainLoop.cpp:1195: Exception at tick 2038839: Error while running command "stops": __TrainWagonCombinators__/control.lua:25: bad argument #2 of 3 to '__index' (string expected, got number)
stack traceback:
	[C]: in function '__index'
	__TrainWagonCombinators__/control.lua:25: in function <__TrainWagonCombinators__/control.lua:19>

Edit: In particular, I can move the table containing the entity, but not the entity. It's not a recursion issue I think. there's multiple weird things.

[Bilka]

It makes sense they'd have protection. I can link you the exact code, and step-by-step you'll see the engine blocking the recursion.

Please do. Explain it step by step please.

[Honktown]

It makes sense they'd have protection. I can link you the exact code, and step-by-step you'll see the engine blocking the recursion.

Please do. Explain it step by step please.

lol. Out-of-the-bigger log, some of the prints imply I can't store the entity in two places, which would allow me to have the entity in another table which also contains the entity. With more of the data being printed step-by-step, it's probably not right at all :^). Would you be upset if I admitted I am wrong?

Also, was this bullshit you. The entity wasn't being assigned at the desired index, and I get some nil that isn't that entity.

This bullshit:

Code: Select all

        global.watched_stops[pstop.unit_number].entity = pstop.entity

That line in the above code don't work.

Edit, also yeah: I'm storing the entities in recursive tables. combinator->stop with up to 5 combinators ->combinators -> the stop...

[Bilka]

Also, was this bullshit you. The entity wasn't being assigned at the desired index, and I get some nil that isn't that entity.

This bullshit:

Code: Select all

        global.watched_stops[pstop.unit_number].entity = pstop.entity

That line in the above code don't work.

No idea what you're talking about, assigning an entity "a" to [a.unit_number].entity works perfectly fine.

images with code execution

Oh I see, you are not using something comfirmed to be a LuaEntity, you are using pstop = global.players[pid].stop and pstop.entity. Sadly you don't log pstop or global.players so that we could find out what pstop.entity is and if it is or isn't nil.

[Honktown]

Also, was this bullshit you. The entity wasn't being assigned at the desired index, and I get some nil that isn't that entity.

This bullshit:

Code: Select all

        global.watched_stops[pstop.unit_number].entity = pstop.entity

That line in the above code don't work.

No idea what you're talking about, assigning an entity "a" to [a.unit_number].entity works perfectly fine.

images with code execution

Oh I see, you are not using something comfirmed to be a LuaEntity, you are using pstop = global.players[pid].stop and pstop.entity. Sadly you don't log pstop or global.players so that we could find out what pstop.entity is and if it is or isn't nil.

Code: Select all

      stop = {
        entity = {
          __self = "userdata"
        },
        unit_number = 115861
      }

Code: Select all

      pstop = global.players[pid].stop

Code: Select all

      if pstop.entity.valid == false then
        remove_stop(pstop)
        remove_combinator_entirely(global.players[pid].combinator)
        return
      end

Code: Select all

        c.stop = pstop
        log("\nc.stop = pstop Global:\n" .. serpent.block(global))

Code: Select all

c.stop = pstop Global:
{
  combinators = {},
  inventory_size = {
    ["cargo-wagon"] = 40
  },
  on_tick_combinators = {},
  players = {
    {
      combinator = {
        entity = {
          __self = "userdata"
        },
        stop = {
          entity = {
            __self = "userdata"
          },
          unit_number = 115861
        },
        x = -48.5,
        y = -34.5
      },
      stop = nil
    }
  },
  watched_stops = {
    [115861] = {
      nil,
      entity = nil
    }
  }
}

[Bilka]

Code: Select all

Global:
{
  ...
  players = {
    {
      combinator = {
        entity = {
          __self = "userdata"
        },
        x = -48.5,
        y = -34.5
      },
      stop = {
        entity = {
          __self = "userdata"
        },
        unit_number = 115861
      }
    }
  },

That's not global.players[pid].stop. That's global.players[1].stop. We don't know if pid == 1. You are also still using a way to dump tables that doesn't show duplicate references properly. Just log pstop. I mean, you have your code, shouldn't be that hard.

[Honktown]

https://drive.google.com/open?id=1ly49A ... bVerqxnFYH

fffffffff I sent the whole damn function. There's the whole mod.

/testgui brings up the gui. Open a combinator. Open a train station. Select 1 in the drop-down. Click the check. Use /wr_reset if you want to clear the table before hitting check again.

[Bilka]

Code: Select all

49.092 Script @__TrainWagonCombinators__/wagonreader/wagonreader.lua:423: 
assigned combinator and stop Global:
do
local _={players={{stop={unit_number=8,entity={__self="userdata"}},combinator={y=3.5,x=-6.5,entity={__self="userdata"},stop=nil,signal=1}}},watched_stops={nil,nil,nil,nil,nil,nil,nil,{[1]=nil,entity=nil}},combinators={[-6.5]={[3.5]=nil}},on_tick_combinators={},inventory_size={["cargo-wagon"]=80}};

local __={};
_.players[1].combinator.stop=_.players[1].stop;
_.watched_stops[8][1]=_.players[1].combinator;
_.watched_stops[8].entity=_.players[1].stop.entity;
_.combinators[-6.5][3.5]=_.players[1].combinator;
return _;
end

Seems fine to me, the references are stored properly.

[Honktown]

Code: Select all

49.092 Script @__TrainWagonCombinators__/wagonreader/wagonreader.lua:423: 
assigned combinator and stop Global:
do
local _={players={{stop={unit_number=8,entity={__self="userdata"}},combinator={y=3.5,x=-6.5,entity={__self="userdata"},stop=nil,signal=1}}},watched_stops={nil,nil,nil,nil,nil,nil,nil,{[1]=nil,entity=nil}},combinators={[-6.5]={[3.5]=nil}},on_tick_combinators={},inventory_size={["cargo-wagon"]=80}};

local __={};
_.players[1].combinator.stop=_.players[1].stop;
_.watched_stops[8][1]=_.players[1].combinator;
_.watched_stops[8].entity=_.players[1].stop.entity;
_.combinators[-6.5][3.5]=_.players[1].combinator;
return _;
end

Seems fine to me, the references are stored properly.

If a train enters the watched stop, I get errors I think. I don't remember. I have to get to bed.

Edit, don't use /stops, there's a typo : P

[Honktown]

Ahhh so many bugs. If only I had more hammers. I did the thing.

thething

https://mods.factorio.com/mod/TrainWagonCombinators

Thank you for your motivation.

[Honktown]

On topic, what would be useful is a pretty-printer for serpent.dump. I don't understand why someone would want to pretty print everything but repeated-entries OR have one long line with everything in it.

Edit: getting there. Wonder if there's an option for the varname.

Code: Select all

/c

local a = {1, nil, 3, x=1, ['true'] = 2, [not true]=3}
a[a] = a

log("\n" .. serpent.dump(a, {compact = false, nocode = true, indent = "\t"})) 

Code: Select all

4953.657 Script  local a = {1, nil, 3, x=1, ['true'] = 2, [not true]=3} a[a] = a  log("\n" .. serpent.dump(a, {compact = false, nocode = true, indent = "\t"})):1: 
do local _ = {
	[1] = 1,
	[3] = 3,
	x = 1,
	["true"] = 2,
	[false] = 3
}
local __={}
_[_] = _
return _
end