[Mod Portal] Idea: Include factorio version when deprecating a mod

[shadow0133]

Currently, Nullius Momenti modpack (https://mods.factorio.com/mod/nullius-momenti-modpack) is not possible to install, because some of the dependant mods have been deprecated. But the deprecation only matters for factorio 2.0, as these mods still are useful for 1.1

One idea I have is to add "Since Factorio Version" field for the mod deprecation, so that it wouldn't break older mods and modpacks

[shadow0133]

here is the list of 409 mods and modpacks which cannot be currently installed with dependencies in versions <= 1.1 of factorio because of this issue: https://github.com/Shadlock0133/factori ... broken.txt

[robot256]

I thought the whole purpose of marking a mod deprecated was so that it doesn't show up in search but can still be synced to saves that use it. It would make sense for deprecated mods to also be downloaded when they are required dependencies of non-deprecated mods.

In this case, I believe the author was wrong to mark https://mods.factorio.com/mod/FuelTrainStop as deprecated. They rightly did not publish a release for 2.0, so it won't show up in any searches for 2.0 mods. In 1.1 the functionality is still needed. You don't need to mark a mod deprecated simply because you stopped maintaining it

[robot256]

here is the list of 409 mods and modpacks which cannot be currently installed with dependencies in versions <= 1.1 of factorio because of this issue: https://github.com/Shadlock0133/factori ... broken.txt

Magu fixed Train Fuel Stop just now. How many does that fix?

[shadow0133]

How many does that fix?

4 modpacks:

• as2_pyanodons
• geekbattery-ocean-pvp
• greysmod_bobs
• salocraft

[robot256]

Most useful would be the list of dependencies that are marked deprecated. I'm interested in finding out if any of them have versions for 2.0. I think this is worth bringing up to Wube in the bug report forum or discord.

Now that I think about, it *might* be possible for the Mod Portal backend to deliver a different "deprecated" flag depending on what version of the game is asking for it, but that would add a lot of complications on their end.

[robot256]

I've found your file broken_with_reason.txt

A bunch of those deprecated mods are correctly marked deprecated, and it's on the depending mod author to update their dependency to a more current release.

I'll see how many look like they are really an issue. It could be that we only have to ask a few authors to change their flags and it will be fine.

[shadow0133]

I've found your file broken_with_reason.txt

make sure you go to newest commit https://github.com/Shadlock0133/factori ... reason.txt

[robot256]

I've found your file broken_with_reason.txt

make sure you go to newest commit https://github.com/Shadlock0133/factori ... reason.txt

Can you check the dependencies for only the mods that have a version for 1.1? I think we can treat anyone downloading mods for a new game in 0.18 as an outlier.

[shadow0133]

Can you check the dependencies for only the mods that have a version for 1.1? I think we can treat anyone downloading mods for a new game in 0.18 as an outlier.

that gives 304 mods:

https://github.com/Shadlock0133/factori ... or_1.1.txt