[1.0.0] Crash on end-of-session save as client

[quote_jester]

The fam were playing 1.0.0 (cool!) and going for the "lazy" achievement.

My machine was not the server. When the server started to save, I started saving, too. We have all the Angels and Bobs extensions stored but were playing stock this time (see the "achievement" item). During or just after the save, factorio crashed and showed the "post a bug" dialog.

Pastebin of factorio-current.log is: https://pastebin.com/eqN45XtW
Do you want any more?

[Loewchen]

Code: Select all

  0.035 2020-09-12 13:55:05; Factorio 1.0.0 (build 54889, linux64, steam)
   0.112 Operating system: Linux (Arch rolling)
   0.112 Program arguments: "/home/akla/.local/share/Steam/steamapps/common/Factorio/bin/x64/factorio" 
   0.112 Read data path: /home/akla/.local/share/Steam/steamapps/common/Factorio/data
   0.112 Write data path: /home/akla/.factorio [326244/910520MB]
   0.112 Binaries path: /home/akla/.local/share/Steam/steamapps/common/Factorio/bin
   0.226 System info: [CPU: Intel(R) Core(TM) i5-4690K CPU @ 3.50GHz, 4 cores, RAM: 15953 MB]
   0.226 Environment: DISPLAY=:0 WAYLAND_DISPLAY=<unset> DESKTOP_SESSION=cinnamon XDG_SESSION_DESKTOP=cinnamon XDG_CURRENT_DESKTOP=X-Cinnamon __GL_FSAA_MODE=<unset> __GL_LOG_MAX_ANISO=<unset> __GL_SYNC_TO_VBLANK=<unset> __GL_SORT_FBCONFIGS=<unset> __GL_YIELD=<unset>
   0.227 Display options: [FullScreen: 1] [VSync: 0] [UIScale: custom (225.0%)] [Native DPI: 1] [Screen: 255] [Special: lmw] [Lang: en]
   0.615 Available displays: 2
   0.615  [0]: ASUS VP28U 28" - {[0,0], 3840x2160, SDL_PIXELFORMAT_RGB888, 60Hz}
   0.615  [1]: BenQ BL2411 24" - {[3840,0], 1920x1200, SDL_PIXELFORMAT_RGB888, 60Hz}
   0.840 Initialised OpenGL:[0] GeForce GTX 770/PCIe/SSE2; driver: 3.3.0 NVIDIA 450.66
   0.840   [Extensions] s3tc:yes; KHR_debug:yes; ARB_clear_texture:yes, ARB_copy_image:yes
   0.840   [Version] 3.3
   0.869 Graphics settings preset: high
   0.869   Dedicated video memory size 2048 MB
   1.301 Graphics options: [Graphics quality: high] [Video memory usage: high] [Light scale: 25%] [DXT: high-quality] [Color: 32bit]
   1.301                   [Max threads (load/render): 32/4] [Max texture size: 0] [Tex.Stream.: 1] [Rotation quality: low] [Other: STDCWT] [B:0,C:0,S:100]
   1.315 [Audio] Backend:default; Depth:16, Channel:2, Frequency:44100; MixerQuality:linear
   5.117 Loading mod core 0.0.0 (data.lua)
   5.392 Loading mod base 1.0.0 (data.lua)
   7.014 Loading mod base 1.0.0 (data-updates.lua)
   7.172 Checksum for core: 2630831588
   7.172 Checksum of base: 3509992273
   8.085 Prototype list checksum: 3301461508
   8.119 Loading sounds...
  14.279 Info PlayerData.cpp:70: Local player-data.json unavailable
  14.279 Info PlayerData.cpp:73: Cloud player-data.json available, timestamp 1598155586
  14.766 Initial atlas bitmap size is 16384
  14.796 Created atlas bitmap 16384x16376 [none]
  14.796 Created atlas bitmap 16384x4300 [none]
  14.796 Created atlas bitmap 8192x4188 [decal]
  14.797 Created atlas bitmap 16384x5568 [low-object, linear-minification]
  14.797 Created atlas bitmap 8192x3744 [mipmap, linear-minification, linear-magnification, linear-mip-level]
  14.797 Created atlas bitmap 16384x5920 [terrain, mipmap, linear-minification, linear-mip-level]
  14.798 Created atlas bitmap 4096x3216 [terrain-effect-map, mipmap, linear-minification, linear-mip-level]
  14.798 Created atlas bitmap 4096x1856 [smoke, mipmap, linear-minification, linear-magnification]
  14.798 Created atlas bitmap 4096x3088 [mipmap]
  14.798 Created atlas bitmap 4096x2336 [icon, not-compressed, mipmap, linear-minification, linear-magnification, linear-mip-level]
  14.798 Created atlas bitmap 2048x224 [icon-background, not-compressed, mipmap, linear-minification, linear-magnification, linear-mip-level, ]
  14.798 Created atlas bitmap 8192x1428 [alpha-mask]
  14.800 Created atlas bitmap 16384x13500 [shadow, linear-magnification, alpha-mask]
  14.800 Created atlas bitmap 8192x2352 [shadow, mipmap, linear-magnification, alpha-mask]
  14.856 Created virtual atlas pages 4096x4096x7
  14.867 Texture processor created (2048). GPU accelerated compression Supported: yes, Enabled: yes/yes. Test passed. YCoCgDXT PSNR: 35.83, BC3 PSNR: 33.82
  90.643 Parallel Sprite Loader initialized (threads: 3)
 103.902 Sprites loaded
 103.999 Generated mipmaps (4) for atlas [3] of size 16384x5568   
 104.008 Generated mipmaps (3) for atlas [4] of size 8192x3744   
 104.326 Generated mipmaps (3) for atlas [5] of size 16384x5920   
 104.370 Generated mipmaps (3) for atlas [6] of size 4096x3216   
 104.399 Generated mipmaps (3) for atlas [7] of size 4096x1856   
 104.427 Generated mipmaps (3) for atlas [8] of size 4096x3088   
 104.486 Generated mipmaps (5) for atlas [9] of size 4096x2336   
 104.494 Generated mipmaps (3) for atlas [13] of size 8192x2352   
 104.508 Custom mipmaps uploaded.
 104.639 Generated mipmaps for virtual atlas of size 8192x16384
 105.063 Factorio initialised
 110.727 Info UDPSocket.cpp:27: Opening socket at (IP ADDR:({0.0.0.0:34196}))
 110.738 Info UDPSocket.cpp:27: Opening socket at (IP ADDR:({0.0.0.0:0}))
 116.745 Info UDPSocket.cpp:218: Closing socket
 116.745 Info UDPSocket.cpp:248: Socket closed
 116.745 Info UDPSocket.cpp:218: Closing socket
 116.771 Info UDPSocket.cpp:218: Closing socket
 116.771 Info UDPSocket.cpp:248: Socket closed
 116.771 Info UDPSocket.cpp:218: Closing socket
 119.591 Joining game IP ADDR:({192.168.1.50:34197})
 119.591 Info UDPSocket.cpp:33: Opening socket
 119.593 Info ClientMultiplayerManager.cpp:578: UpdateTick(4294967295) changing state from(Ready) to(Connecting)
 119.630 Info ClientSynchronizer.cpp:33: Initialized Synchronizer local peer(1) latency(32).
 119.631 Info ClientMultiplayerManager.cpp:578: UpdateTick(4294967295) changing state from(Connecting) to(ConnectedWaitingForMap)
 119.631 Info ClientRouter.cpp:221: ConnectionAccepted
 120.163 Info ClientMultiplayerManager.cpp:750: Received mapReadyForDownload
 120.163 Downloading file /home/akla/.factorio/temp/mp-download.zip (7834577 B, 15576 blocks)
 120.171 Info ClientMultiplayerManager.cpp:578: UpdateTick(4294967295) changing state from(ConnectedWaitingForMap) to(ConnectedDownloadingMap)
 120.921 Finished download (0 s, 7.8 MB, 10.4 MB/s)
 120.943 Info ClientMultiplayerManager.cpp:730: updateTick(4294967295) map download finished creating scenario
 120.943 Info ClientMultiplayerManager.cpp:578: UpdateTick(4294967295) changing state from(ConnectedDownloadingMap) to(ConnectedLoadingMap)
 120.963 Loading map /home/akla/.factorio/temp/mp-download.zip: 7834577 bytes.
 120.985 Loading level.dat: 19374328 bytes.
 120.990 Info Scenario.cpp:187: Map version 1.0.0-0
 121.426 Loading script.dat: 427 bytes.
 121.479 Checksum for script /home/akla/.factorio/temp/currently-playing/control.lua: 3931528263
 121.498 Info ClientMultiplayerManager.cpp:578: UpdateTick(850362) changing state from(ConnectedLoadingMap) to(TryingToCatchUp)
 121.648 Info ClientMultiplayerManager.cpp:578: UpdateTick(850453) changing state from(TryingToCatchUp) to(WaitingForCommandToStartSendingTickClosures)
 121.730 Info ClientMultiplayerManager.cpp:578: UpdateTick(850453) changing state from(WaitingForCommandToStartSendingTickClosures) to(InGame)
 121.780 Info GameActionHandler.cpp:4725: UpdateTick (850456) processed PlayerJoinGame peerID(4) playerIndex(4) mode(connect) 
 137.463 Info ClientSynchronizer.cpp:318: Latency changed to (10)

...

14156.096 Info ClientSynchronizer.cpp:318: Latency changed to (6)
14161.063 Info ClientSynchronizer.cpp:318: Latency changed to (10)
14165.455 Error CrashHandler.cpp:621: Received SIGSEGV
Factorio crashed. Generating symbolized stacktrace, please wait ...
Raw stacktrace: 0xcbd047, 0xe9aced, 0xd13d75, 0xd1418d, 0xd141e9, 0x3d6a0, 0x50309
14177.333 Warning Logger.cpp:522: Symbols.size() == 11, usedSize == 6
#0  0x0000000000e9aced in std::__uniq_ptr_impl<LoggerFileWriteStream, std::default_delete<LoggerFileWriteStream> >::_M_ptr() const at /home/build/gcc-9.2/include/c++/9.2.0/bits/unique_ptr.h:154
#1  0x0000000000d13d75 in std::unique_ptr<LoggerFileWriteStream, std::default_delete<LoggerFileWriteStream> >::get() const at /home/build/gcc-9.2/include/c++/9.2.0/bits/unique_ptr.h:353
#2  0x0000000000d1418d in std::unique_ptr<LoggerFileWriteStream, std::default_delete<LoggerFileWriteStream> >::operator->() const at /home/build/gcc-9.2/include/c++/9.2.0/bits/unique_ptr.h:347
#3  0x0000000000d141e9 in Logger::flush() at /tmp/factorio-build-jo6Nmq/src/Util/Logger.cpp:562
#4  0x000000000003d6a0 in Logger::logStacktrace(StackTraceInfo*) at /tmp/factorio-build-jo6Nmq/src/Util/Logger.cpp:548
#5  0x0000000000050309 in GlobalContext::getMap() at /tmp/factorio-build-jo6Nmq/src/GlobalContext.cpp:1985
#6  (nil) in CrashHandler::writeStackTrace(CrashHandler::CrashReason) at /tmp/factorio-build-jo6Nmq/src/Util/CrashHandler.cpp:188
#7  (nil) in CrashHandler::commonSignalHandler(int) at /tmp/factorio-build-jo6Nmq/src/Util/CrashHandler.cpp:624
#8  (nil) in CrashHandler::SignalHandler(int) at /tmp/factorio-build-jo6Nmq/src/Util/CrashHandler.cpp:638
#9  (nil) in ?? at ??:0
#10 (nil) in ?? at ??:0
Stack trace logging done
14187.157 Warning Logger.cpp:522: Symbols.size() == 6, usedSize == 5
14187.157 Error CrashHandler.cpp:189: Map tick at moment of crash: 1692780
14187.157 Error Util.cpp:97: Unexpected error occurred. If you're running the latest version of the game you can help us solve the problem by posting the contents of the log file on the Factorio forums.
Please also include the save file(s), any mods you may be using, and any steps you know of to reproduce the crash.
14213.478 Info SystemUtil.cpp:547: Started /usr/bin/xdg-open; trampoline PID: 32481
14213.478 Uploading log file
14213.499 Info SystemUtil.cpp:547: Started /home/akla/.local/share/Steam/steamapps/common/Factorio/bin/x64/factorio; trampoline PID: 32483

[quote_jester]

Tried a repro, and I think we got the same problem, especially the stack crawl.

Steps to repro:

1. Load big game on server (needs to be big? maybe, just for the timing)
2. Client connects
3. Start to save on client
4. Server quits before save finishes.
5. Client hangs and crashes.

[Twinsen]

I can't seem to reproduce the crash.
In my case the saving is canceled on the client and a message that server quit appears.

It seems that in your case the map no longer exists. Not sure how to reach that state.